From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61750 invoked by alias); 29 Jun 2016 08:58:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61644 invoked by uid 89); 29 Jun 2016 08:58:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Best X-HELO: mail-wm0-f44.google.com Received: from mail-wm0-f44.google.com (HELO mail-wm0-f44.google.com) (74.125.82.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 29 Jun 2016 08:58:00 +0000 Received: by mail-wm0-f44.google.com with SMTP id r201so62866968wme.1 for ; Wed, 29 Jun 2016 01:58:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=Jddyh1zaOSIdd42x8/NJbc4hcjHrCMHZobU2QWsuApo=; b=A89CcOMF0FwC7/VAKxUFxJAJZtpxSe55oxGCsmClqjmcuqeZzEWSGfnV/JxCHhRMjX DY4nFoBmLontMsVcJw28chcAOTUkra43xeSHl29pv7WbE1xk2McGOyppOp/vZkDtREGn MDnicIci7gqvSZ6JPfFQxcxJKGi14EPBnTffVchf2rQde+rb6MrwgOJOTKyhE7Nc5Ioa pYD8I7FUFHnH1KZxXl6VpEeZEom1bfb4Wo4emAwL54P+hOW2z4wxW/9ngmzscnWfr/w0 JhqNpB2lCMoYj77e5LimNsHA0DaEZhtAVHGtm4rNj507itiCyuT4ihZNyCy23tCP6trf 3QGw== X-Gm-Message-State: ALyK8tJabnBwewG+81UlxbyZ21aDOOZASHyoVGDpgC2jDGG38hJPaQKjJvvW/efcT7BGiwMat4p25jNFzl/r4Xou X-Received: by 10.194.109.232 with SMTP id hv8mr7363541wjb.115.1467190677526; Wed, 29 Jun 2016 01:57:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.36.215 with HTTP; Wed, 29 Jun 2016 01:57:56 -0700 (PDT) In-Reply-To: <5013369.B1hQpEVniv@e108577-lin> References: <5013369.B1hQpEVniv@e108577-lin> From: Manish Goregaokar Date: Wed, 29 Jun 2016 08:58:00 -0000 Message-ID: Subject: Re: [PATCH 1/2][PR gdb/20239] Make evaluation and type-printing of all NonZero-optimized enums work To: Thomas Preudhomme , gdb-patches@sourceware.org, Tom Tromey Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00490.txt.bz2 No, strsep was just a better fit here. I wasn't aware that it doesn't work on windows. I'll fix it to use strtok. -Manish On Wed, Jun 29, 2016 at 2:25 PM, Thomas Preudhomme wrote: > Hi Manish, > > On Saturday 25 June 2016 11:30:39 Manish Goregaokar wrote: >> After further fixups, these patches have been pushed as >> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=b5a4b3c5 >> e711be9096423f9765623eda449d8f4d and >> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=fccb08f >> 8cd2035b50a2b0a5e09983180b7411685 > > GDB fails to build on Windows (mingw build) due to this patch as strsep is not > available. Was there something preventing the use of strtok? > > Best regards, > > Thomas