Re: [RFA/commit] arm-tdep.c: Do not single-step after hitting a watchpoint.

Joel Brobecker
2014-09-29T17:51:57Z

Hello all,

> Hmm. So when the data abort triggers at fault+8, the instruction
> that triggered the abort hasn't actually completed, right? No memory
> has changed yet.
>
> So if nothing does the adjustment, like Gareth found out happens with
> the Black Magic Probe, then we'll resume execution from the
> wrong address/instruction (with the effects of the skipped instructions
> missing, including the memory write...). Did I understand that
> right? (Gareth, is that what you see?)

I have been trying to understand the various contributions, and
I admit I am still not quite sure...

Does it look like the patch I proposed is correct? It seems to be
supported by Terry Guo's experiments as well...

Thanks!
--
Joel