From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107204 invoked by alias); 4 Mar 2016 20:41:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107123 invoked by uid 89); 4 Mar 2016 20:41:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_40,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=shot, kiss, messaging, Engineering X-HELO: mail-io0-f174.google.com Received: from mail-io0-f174.google.com (HELO mail-io0-f174.google.com) (209.85.223.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 04 Mar 2016 20:41:25 +0000 Received: by mail-io0-f174.google.com with SMTP id l127so74899198iof.3 for ; Fri, 04 Mar 2016 12:41:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=6iUh1lIkmYCYE2pFS0LSdcafrEmbA0+YIxQi8VAPqhM=; b=lr1Dgy0M9fLzmusg4sDERmGFvw3yJ3Qc3ANtLzWfanTNFNux4IW2mnQkXzSMf9u9He JOscNx4Te6IQq2sjEv+wI1K9ScoidDiDMQYkqiLOl3ZEX3X4dJ/GTyphxZFf+axSicwv rocQYCKyHaQUcbIH7cH7k6ATsiL30NxGnAfYAXKZs9jNXP4blqC3Iv3HeMmjZ5aKKRtF WvQaVzXOM09nr4AePHA4FP1N+/KT+vjLULD/vUFEhBtRgfbjULV2n8Yu7e7Icrbmyf85 GmJsJ6IHUxD5A8kizExfHmte9/tIBw0fPaeS8MvRTPSBntZj5Pri+mhzr0gVjo4YfcmS xkKg== X-Gm-Message-State: AD7BkJIzx2JbZauBpdTUr2Ivnrwl5xrdwnDgRaUXYed4rJusE87IQFh5LmV+VQLghNfCg/RjCeHMgedvWHgrDiqi MIME-Version: 1.0 X-Received: by 10.107.29.212 with SMTP id d203mr4137049iod.6.1457124083055; Fri, 04 Mar 2016 12:41:23 -0800 (PST) Received: by 10.36.5.148 with HTTP; Fri, 4 Mar 2016 12:41:22 -0800 (PST) In-Reply-To: References: <534F294D.4050907@codesourcery.com> <53546C38.2000901@codesourcery.com> Date: Fri, 04 Mar 2016 20:41:00 -0000 Message-ID: Subject: Re: [PATCH] Fix alignment of disassemble /r From: Daniel Gutson To: Yao Qi Cc: Doug Evans , gdb-patches Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00083.txt.bz2 FWIW: https://sourceware.org/bugzilla/show_bug.cgi?id=3D19768 On Tue, Apr 22, 2014 at 9:13 AM, Daniel Gutson wrote: > OK timeout, I wil just KISS and implement the 2-passes solution > without considering paging. > > I'll be back with the new version of the patch. > > Thanks for your comments! > > Daniel. > > On Mon, Apr 21, 2014 at 1:00 PM, Daniel Gutson > wrote: >> On Sun, Apr 20, 2014 at 9:54 PM, Yao Qi wrote: >>> On 04/18/2014 01:27 AM, Daniel Gutson wrote: >>>> I already considered this, but thought that it would be going to be >>>> rejected due to be too much non-performant. Wouldn't each pass >>>> translate in a lot of MI messaging in a case of a remote server? And, >>> >>> If you meant "rsp packets" rather than "MI messaging", >> >> Yes, my bad, sorry. >> >> we don't worry >>> about the performance much here. disassemble uses code cache >>> (target_read_code) to read instructions from remote server and the >>> following read to the same area will hit the cache. >>> >>>> what about screen paginig? I shouldn't iterate over all the range, but >>>> the screen height range only. >>> >>> What is the reason do you think we shouldn't iterator over all the >>> range? IMO=EF=BC=8C screen height and alignment are orthogonal. >> >> Suppose your function takes two screens of disassembly. >> Then suppose that the instructions that fit in the first screen take >> N bytes at most, >> and those of the second takes N+k. If I ignore screen paging, I would >> be aligning >> the first screen to N+k too, whereas those k are just useless space. >> It's a minor and cosmetic concern, but I'd like to get it right and >> pretty in one shot :) >> >> Daniel. >> >>> >>> -- >>> Yao (=E9=BD=90=E5=B0=A7) >> >> >> >> -- >> >> Daniel F. Gutson >> Chief Engineering Officer, SPD >> >> >> San Lorenzo 47, 3rd Floor, Office 5 >> >> C=C3=B3rdoba, Argentina >> >> >> Phone: +54 351 4217888 / +54 351 4218211 >> >> Skype: dgutson > > > > -- > > Daniel F. Gutson > Chief Engineering Officer, SPD > > > San Lorenzo 47, 3rd Floor, Office 5 > > C=C3=B3rdoba, Argentina > > > Phone: +54 351 4217888 / +54 351 4218211 > > Skype: dgutson --=20 Daniel F. Gutson Chief Engineering Officer, SPD San Lorenzo 47, 3rd Floor, Office 5 C=C3=B3rdoba, Argentina Phone: +54 351 4217888 / +54 351 4218211 Skype: dgutson LinkedIn: http://ar.linkedin.com/in/danielgutson