From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23386 invoked by alias); 22 Apr 2014 12:14:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23374 invoked by uid 89); 22 Apr 2014 12:14:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mail-la0-f42.google.com Received: from mail-la0-f42.google.com (HELO mail-la0-f42.google.com) (209.85.215.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 22 Apr 2014 12:13:44 +0000 Received: by mail-la0-f42.google.com with SMTP id el20so833650lab.1 for ; Tue, 22 Apr 2014 05:13:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=IoQM3RbQBlrfJYtjiyzP9UWc+w5U9lwVVWGaLnKop1w=; b=TM2/FSRhmXkA/9lfusOd+sW+9aXwSto/HwG7xVx9lrPfcGaDbvVRNzWoGRoLdmF085 qB6nAT6/u/zcnnyTwxhp4KQ6SlFKiMsHGHNEmK1Xp1iv0VP6Ysd0nim7Rdr2W0365v56 puPscTqugx1faGcE1Do8bzOfuw5DqynqpOrN4Be8LbRuRs8kxCPk+Vp/m4SjlIzdi+yy hzd4atXSmnxUDkosUQyWq+36jugntiSKsL2nCL0Ot8Cgy/0zlpeBfKy46YAmInnRZcQ8 wdnlkWJ+tsdPo+EtsZ/uIdS2D7tRXFp+C1Iw+xYoLWacxzKSbdone00Xfl9wq/7Hvx+i Y1OA== X-Gm-Message-State: ALoCoQkl+YJU9FwT6Ds0sjJ2jbUMoEnqiP7d5ujsZhY/CzYAk6HTGstuGECFCdI/RrElc9Di+PvL MIME-Version: 1.0 X-Received: by 10.152.37.137 with SMTP id y9mr30678865laj.8.1398168820979; Tue, 22 Apr 2014 05:13:40 -0700 (PDT) Received: by 10.112.9.40 with HTTP; Tue, 22 Apr 2014 05:13:40 -0700 (PDT) In-Reply-To: References: <534F294D.4050907@codesourcery.com> <53546C38.2000901@codesourcery.com> Date: Tue, 22 Apr 2014 12:14:00 -0000 Message-ID: Subject: Re: [PATCH] Fix alignment of disassemble /r From: Daniel Gutson To: Yao Qi Cc: Doug Evans , gdb-patches Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00427.txt.bz2 OK timeout, I wil just KISS and implement the 2-passes solution without considering paging. I'll be back with the new version of the patch. Thanks for your comments! Daniel. On Mon, Apr 21, 2014 at 1:00 PM, Daniel Gutson wrote: > On Sun, Apr 20, 2014 at 9:54 PM, Yao Qi wrote: >> On 04/18/2014 01:27 AM, Daniel Gutson wrote: >>> I already considered this, but thought that it would be going to be >>> rejected due to be too much non-performant. Wouldn't each pass >>> translate in a lot of MI messaging in a case of a remote server? And, >> >> If you meant "rsp packets" rather than "MI messaging", > > Yes, my bad, sorry. > > we don't worry >> about the performance much here. disassemble uses code cache >> (target_read_code) to read instructions from remote server and the >> following read to the same area will hit the cache. >> >>> what about screen paginig? I shouldn't iterate over all the range, but >>> the screen height range only. >> >> What is the reason do you think we shouldn't iterator over all the >> range? IMO=EF=BC=8C screen height and alignment are orthogonal. > > Suppose your function takes two screens of disassembly. > Then suppose that the instructions that fit in the first screen take > N bytes at most, > and those of the second takes N+k. If I ignore screen paging, I would > be aligning > the first screen to N+k too, whereas those k are just useless space. > It's a minor and cosmetic concern, but I'd like to get it right and > pretty in one shot :) > > Daniel. > >> >> -- >> Yao (=E9=BD=90=E5=B0=A7) > > > > -- > > Daniel F. Gutson > Chief Engineering Officer, SPD > > > San Lorenzo 47, 3rd Floor, Office 5 > > C=C3=B3rdoba, Argentina > > > Phone: +54 351 4217888 / +54 351 4218211 > > Skype: dgutson --=20 Daniel F. Gutson Chief Engineering Officer, SPD San Lorenzo 47, 3rd Floor, Office 5 C=C3=B3rdoba, Argentina Phone: +54 351 4217888 / +54 351 4218211 Skype: dgutson