From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14068 invoked by alias); 11 Apr 2014 22:24:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14058 invoked by uid 89); 11 Apr 2014 22:24:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mail-la0-f42.google.com Received: from mail-la0-f42.google.com (HELO mail-la0-f42.google.com) (209.85.215.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 11 Apr 2014 22:24:56 +0000 Received: by mail-la0-f42.google.com with SMTP id ec20so4060855lab.1 for ; Fri, 11 Apr 2014 15:24:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=6QE/Ll3Cd77cGdOJFDDKuZww3pp/3Wplt4xpp7E3wKc=; b=EiXvKL1Zkf/9yX6D+bRca0WhW9PXPuV5FL3YhKa/YX98v4PfluKD2l2XUj5X/2ZkCZ RDjsM8R4lFHvNrt5oQtKzxXrpYdN899vZlWnKsC1MoN0fg9Ydh5bdXBoX7qPyzlkBDpy zrkksLhb6UhUTzRvm4e19S/y+Qqu/uH9pLnVuUx5XUPo4SYOnmXpamwdIV1z+u5pfN6Y W4DDfnWZ+7CiYfx3KPGu0a37bACFPdxunf5DQfdO1QVC795G5p+fwVwg7MOCIITL61+s mFYaNVRhtog963600bbb0kXBGs8IdR/LX/lxubtazGEQKDHmMA5EfWJRbzCCGlVBy8Fc GXYQ== X-Gm-Message-State: ALoCoQmNyg1WxqJB/x+pOFYLK77bVasa3OShF9lOpBuvaoDNU65Qjz8f/U2Xs/d8/PH57R5AE5ph MIME-Version: 1.0 X-Received: by 10.112.142.68 with SMTP id ru4mr2918308lbb.49.1397255090974; Fri, 11 Apr 2014 15:24:50 -0700 (PDT) Received: by 10.112.9.40 with HTTP; Fri, 11 Apr 2014 15:24:50 -0700 (PDT) Date: Fri, 11 Apr 2014 22:24:00 -0000 Message-ID: Subject: [PATCH] Fix alignment of disassemble /r From: Daniel Gutson To: gdb-patches Content-Type: multipart/mixed; boundary=001a11c36dfc5bd7c404f6cbcd42 X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00226.txt.bz2 --001a11c36dfc5bd7c404f6cbcd42 Content-Type: text/plain; charset=UTF-8 Content-length: 993 Hi, when disassembling in raw mode (/r) in a variable-length insn architecture (i.e. x86), the output can be completely messed since no alignment takes place. I am aware of the uiout->table stuff, but it seems an overkill since I should change the current_uiout when disassembling in this mode (and I didn't find any actual use of this machinery at least for x86). Therefore, I added a hack in the dump_insns when the /r flag is specified. This clearly isn't the cutiest thing in the world, and I specified a hardcoded maximum number of opcode bytes to align (currently 8) though it is easily changeable. Please let me know if this approach is OK or I should do something else. Maybe consider whether current arch is insn-len variable? If this happens to be OK, please commit it for me since I don't have write access. Thanks, Daniel. 2014-04-11 Daniel Gutson * disasm.c (dump_insns): Added right alignment when showing opcodes. --001a11c36dfc5bd7c404f6cbcd42 Content-Type: text/x-patch; charset=US-ASCII; name="disasm.patch" Content-Disposition: attachment; filename="disasm.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_htw1lchz0 Content-length: 2005 ZGlmZiAtLWdpdCBhL2dkYi9kaXNhc20uYyBiL2dkYi9kaXNhc20uYwppbmRl eCBkOTQyMjViLi4wZmQ1YWExIDEwMDY0NAotLS0gYS9nZGIvZGlzYXNtLmMK KysrIGIvZ2RiL2Rpc2FzbS5jCkBAIC0xMDcsNiArMTA3LDEzIEBAIGR1bXBf aW5zbnMgKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNoLCBzdHJ1Y3QgdWlfb3V0 ICp1aW91dCwKICAgaW50IG9mZnNldDsKICAgaW50IGxpbmU7CiAgIHN0cnVj dCBjbGVhbnVwICp1aV9vdXRfY2hhaW47CisgIC8qIFRoaXMgYXJyYXkgaG9s ZHMgZW5vdWdoIHNwYWNlIGZvciA4IGJ5dGVzIG9mIG9wY29kZXM7CisgICAg IHNpbmNlIHRoZSBmb3JtYXQgaXMgMDJ4IHBsdXMgdGhlIHNwYWNlLCB0aGUg bGVuZ3RoCisgICAgIHRoZSBhcnJheSBpcyAoMmNoYXJzICsgMXNwYWNlKSAq IDggYnl0ZXMgKyAxemVybyA9IDI1IGNoYXJzLiAgKi8KKyAgY2hhciByaWdo dF9hbGlnbls4ICogMyArIDFdOworCisgIG1lbXNldChyaWdodF9hbGlnbiwg JyAnLCBzaXplb2YocmlnaHRfYWxpZ24pIC0gMik7CisgIHJpZ2h0X2FsaWdu W3NpemVvZihyaWdodF9hbGlnbikgLSAxXSA9IDA7CiAKICAgZm9yIChwYyA9 IGxvdzsgcGMgPCBoaWdoOykKICAgICB7CkBAIC0xNTQsNiArMTYxLDcgQEAg ZHVtcF9pbnNucyAoc3RydWN0IGdkYmFyY2ggKmdkYmFyY2gsIHN0cnVjdCB1 aV9vdXQgKnVpb3V0LAogICAgICAgICAgIGJmZF9ieXRlIGRhdGE7CiAgICAg ICAgICAgaW50IHN0YXR1czsKICAgICAgICAgICBjb25zdCBjaGFyICpzcGFj ZXIgPSAiIjsKKyAgICAgICAgICB1bnNpZ25lZCBpbnQgYWxpZ25tZW50X3Bv cyA9IDA7CiAKICAgICAgICAgICAvKiBCdWlsZCB0aGUgb3Bjb2RlcyB1c2lu ZyBhIHRlbXBvcmFyeSBzdHJlYW0gc28gd2UgY2FuCiAgICAgICAgICAgICAg d3JpdGUgdGhlbSBvdXQgaW4gYSBzaW5nbGUgZ28gZm9yIHRoZSBNSS4gICov CkBAIC0xNzAsOCArMTc4LDExIEBAIGR1bXBfaW5zbnMgKHN0cnVjdCBnZGJh cmNoICpnZGJhcmNoLCBzdHJ1Y3QgdWlfb3V0ICp1aW91dCwKICAgICAgICAg ICAgICAgZnByaW50Zl9maWx0ZXJlZCAob3Bjb2RlX3N0cmVhbSwgIiVzJTAy eCIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNwYWNlciwg KHVuc2lnbmVkKSBkYXRhKTsKICAgICAgICAgICAgICAgc3BhY2VyID0gIiAi OworICAgICAgICAgICAgICBhbGlnbm1lbnRfcG9zICs9IDM7CiAgICAgICAg ICAgICB9CiAgICAgICAgICAgdWlfb3V0X2ZpZWxkX3N0cmVhbSAodWlvdXQs ICJvcGNvZGVzIiwgb3Bjb2RlX3N0cmVhbSk7CisgICAgICAgICAgaWYgKGFs aWdubWVudF9wb3MgPCBzaXplb2YocmlnaHRfYWxpZ24pKQorICAgICAgICAg ICAgdWlfb3V0X3RleHQgKHVpb3V0LCAmcmlnaHRfYWxpZ25bYWxpZ25tZW50 X3Bvc10pOwogICAgICAgICAgIHVpX291dF90ZXh0ICh1aW91dCwgIlx0Iik7 CiAKICAgICAgICAgICBkb19jbGVhbnVwcyAoY2xlYW51cHMpOwo= --001a11c36dfc5bd7c404f6cbcd42--