From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6684 invoked by alias); 20 Mar 2014 16:33:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6406 invoked by uid 89); 20 Mar 2014 16:33:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mail-la0-f47.google.com Received: from mail-la0-f47.google.com (HELO mail-la0-f47.google.com) (209.85.215.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 20 Mar 2014 16:33:26 +0000 Received: by mail-la0-f47.google.com with SMTP id y1so796360lam.6 for ; Thu, 20 Mar 2014 09:33:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=MBMYNrZj3YTLJjyuOWRFmmB/8r2LNRkeBMoIDMuxILM=; b=m8Yj0ByYzC8uGSWdZzOADqyLgl1vJ5tUjo8c+6Yph9yDT6wyxXW186H6rQuQgQYXF1 WEd9JUuPgF1q7hXxajmaDKFYOufPR/ncHQXUJIMWjbjapySGu53ntlX0wa8KdXquykgN gFoAAti+HHES9ozv3XYDBk/UAiTY3AhmhLS7+WSd39mDQW9FIkPqXMMqPDEFlxh41RtP cpAkvapXqiUuR2KncQzLIrlBQp1X0vVUgk+/qsXY5expRPa/5dWFdUhkBrxSEEEhUbha koFhwE7iRs4hYLBNM3SmFFNdZ/lglrHA+11gofN550zKcYsAkuhYlbnQx0P02M6flBY3 3BXw== X-Gm-Message-State: ALoCoQkuh5uXa4G5s17xbeZMIkhKtphSsSRYqWaxmXZTiBpbKYHuX/1WMQGQH/1LE39aNlyAdGQd MIME-Version: 1.0 X-Received: by 10.153.5.33 with SMTP id cj1mr79275lad.65.1395333203052; Thu, 20 Mar 2014 09:33:23 -0700 (PDT) Received: by 10.112.9.40 with HTTP; Thu, 20 Mar 2014 09:33:22 -0700 (PDT) Date: Thu, 20 Mar 2014 16:33:00 -0000 Message-ID: Subject: [PATCH] Small segfault fix when there is no python From: Daniel Gutson To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=001a11349628e9706e04f50c5399 X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00498.txt.bz2 --001a11349628e9706e04f50c5399 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 639 Hi, the small attached patch prevents gdb to segfault when an extension language definition has no ops, which e.g. occurs when HAVE_PYTHON is not defined so extension_language_python remains with ops in NULL. This causes the line if (extlang->ops->eval_from_control_command != NULL) (in eval_ext_lang_from_control_command) to dereference a null pointer. Please commit it for me if approved since I don't have write access. Thanks, Daniel. 2014-03-20 Daniel Gutson (daniel.gutson@tallertechnologies.com) gdb/ * extension.c: (eval_ext_lang_from_control_command) Added check to prevent dereference of null pointer. --001a11349628e9706e04f50c5399 Content-Type: text/x-patch; charset=US-ASCII; name="python.patch" Content-Disposition: attachment; filename="python.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ht09bdk40 Content-length: 1042 ZGlmZiAtLWdpdCBhL2dkYi9leHRlbnNpb24uYyBiL2dkYi9leHRlbnNpb24u YwppbmRleCBjMmY1MDJiLi44MzU3ZWU4IDEwMDY0NAotLS0gYS9nZGIvZXh0 ZW5zaW9uLmMKKysrIGIvZ2RiL2V4dGVuc2lvbi5jCkBAIC0zNDIsMTEgKzM0 MiwxNCBAQCBldmFsX2V4dF9sYW5nX2Zyb21fY29udHJvbF9jb21tYW5kIChz dHJ1Y3QgY29tbWFuZF9saW5lICpjbWQpCiAgICAgewogICAgICAgaWYgKGV4 dGxhbmctPmNsaV9jb250cm9sX3R5cGUgPT0gY21kLT5jb250cm9sX3R5cGUp CiAJewotCSAgaWYgKGV4dGxhbmctPm9wcy0+ZXZhbF9mcm9tX2NvbnRyb2xf Y29tbWFuZCAhPSBOVUxMKQotCSAgICB7Ci0JICAgICAgZXh0bGFuZy0+b3Bz LT5ldmFsX2Zyb21fY29udHJvbF9jb21tYW5kIChleHRsYW5nLCBjbWQpOwot CSAgICAgIHJldHVybjsKLQkgICAgfQorICAgICAgaWYgKGV4dGxhbmctPm9w cyAhPSBOVUxMKQorICAgICAgICB7ICAKKwkgICAgaWYgKGV4dGxhbmctPm9w cy0+ZXZhbF9mcm9tX2NvbnRyb2xfY29tbWFuZCAhPSBOVUxMKQorCSAgICAg IHsKKwkgICAgICAgIGV4dGxhbmctPm9wcy0+ZXZhbF9mcm9tX2NvbnRyb2xf Y29tbWFuZCAoZXh0bGFuZywgY21kKTsKKwkgICAgICAgIHJldHVybjsKKwkg ICAgICB9CisgICAgICAgIH0KIAkgIC8qIFRoZSByZXF1ZXN0ZWQgZXh0ZW5z aW9uIGxhbmd1YWdlIGlzIG5vdCBzdXBwb3J0ZWQgaW4gdGhpcyBHREIuICAq LwogCSAgdGhyb3dfZXh0X2xhbmdfdW5zdXBwb3J0ZWQgKGV4dGxhbmcpOwog CX0K --001a11349628e9706e04f50c5399--