Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kai Tietz <ktietz70@googlemail.com>
To: gdb-patches@sourceware.org
Subject: [patch gdb]: Fix PR gdb/15161 part 1 of 3
Date: Tue, 19 Feb 2013 17:18:00 -0000	[thread overview]
Message-ID: <CAEwic4YmG-kxmOvAPLL5hZcjuNYGrs=PbU8Pr-QgAbQPj6c9VQ@mail.gmail.com> (raw)

Hi,

this patch fixes part one of the PR gdb/15161 issue in symfile.c.

ChangeLog

2013-02-19  Kai Tietz  <ktietz@redhat.com>

	PR gdb/15161
	* symfile.c (load_section_data): Change type of load_offset
	to CORE_ADDR.
	(generic_load): User strtoulst instead of strtoul for evalute of
	load_offset.

Ok for apply?

Regards,
Kai

Index: symfile.c
===================================================================
RCS file: /cvs/src/src/gdb/symfile.c,v
retrieving revision 1.363
diff -p -u -r1.363 symfile.c
--- symfile.c	1 Feb 2013 19:39:03 -0000	1.363
+++ symfile.c	19 Feb 2013 16:52:32 -0000
@@ -1948,7 +1948,7 @@ add_section_size_callback (bfd *abfd, as

 /* Opaque data for load_section_callback.  */
 struct load_section_data {
-  unsigned long load_offset;
+  CORE_ADDR load_offset;
   struct load_progress_data *progress_data;
   VEC(memory_write_request_s) *requests;
 };
@@ -2126,9 +2126,9 @@ generic_load (char *args, int from_tty)

   if (argv[1] != NULL)
     {
-      char *endptr;
+      const char *endptr;

-      cbdata.load_offset = strtoul (argv[1], &endptr, 0);
+      cbdata.load_offset = (CORE_ADDR) strtoulst (argv[1], &endptr, 0);

       /* If the last word was not a valid number then
          treat it as a file name with spaces in.  */


             reply	other threads:[~2013-02-19 17:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-19 17:18 Kai Tietz [this message]
2013-02-19 18:25 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEwic4YmG-kxmOvAPLL5hZcjuNYGrs=PbU8Pr-QgAbQPj6c9VQ@mail.gmail.com' \
    --to=ktietz70@googlemail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox