From: David Blaikie <dblaikie@gmail.com>
To: gdb-patches@sourceware.org
Subject: dg-extract-results.sh truncates logs containing "Running "
Date: Mon, 14 Jan 2013 19:56:00 -0000 [thread overview]
Message-ID: <CAENS6EvfzO7=VqUeMiNiUtJ7wCbK_6ZWoyDmmVZi-8Jk1=1zkw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
The regex to detect the beginning of a test file execution was too
broad, matching any line beginning with "Running ". This caused
dg-extract-results.sh to truncate some test logs, including
gdb.base/help.exp (which tests "help running", printing "Running the
program.")
The attached patch makes the match a little more precise to avoid
this. With this the exact count of PASS/FAIL/etc lines in the
dg-extract-results.sh output matches the counts in the computed
summary exactly for all cases I've seen.
[-- Attachment #2: extract-running.diff --]
[-- Type: application/octet-stream, Size: 423 bytes --]
diff --git gdb/testsuite/dg-extract-results.sh gdb/testsuite/dg-extract-results.sh
index 574833e..c67b5ca 100755
--- gdb/testsuite/dg-extract-results.sh
+++ gdb/testsuite/dg-extract-results.sh
@@ -286,7 +286,7 @@ BEGIN {
/^Using / {
if (variant == curvar && print_using) { print; next }
}
-/^Running / {
+/^Running .*\\.exp \\.\\.\\./ {
print_using=0
if (variant == curvar) {
if (need_close) close(curfile)
next reply other threads:[~2013-01-14 19:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 19:56 David Blaikie [this message]
2013-01-15 16:17 ` Pedro Alves
2013-01-17 2:24 ` David Blaikie
2013-01-17 13:47 ` Pedro Alves
2013-01-17 14:38 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAENS6EvfzO7=VqUeMiNiUtJ7wCbK_6ZWoyDmmVZi-8Jk1=1zkw@mail.gmail.com' \
--to=dblaikie@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox