Re: bogus main declaration in gdb.base/label.c

David Blaikie
2013-01-15T18:33:04Z

On Tue, Jan 15, 2013 at 10:18 AM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
> On Tuesday, January 15 2013, David Blaikie wrote:
>
>> Still a little fuzzy on ChangeLog entries, especially for patches
>> (following the contribution documentation it ends up pointing at
>> threads like this: http://gcc.gnu.org/ml/gcc/2000-09/msg00290.html (
>> from http://gcc.gnu.org/codingconventions.html#ChangeLogs ))
>>
>> * testsuite/gdb.base/label.c: Correct the type of the second
>> parameter to main.
>
> Hi David,
>
> Thanks for your contribution. The ChangeLog needs to be written
> according to the GNU Coding Standards (as you have noticed). The best
> way to learn how to write an entry for them is to take a look at the
> existing ChangeLogs: gdb/ChangeLog is a good source of information :-).
> In your specific case, there is a ChangeLog file in gdb/testsuite, so
> you don't need to include the prefix `testsuite/' in your entry.

Ah, hadn't realized there were narrower ChangeLogs (& I'd seen some
ChangeLog entries without author prefixes and some with). Thanks for
the tips/corrections.

> Anyway, you would write your entry as:
>
> 2013-01-15 David Blaikie <dblaikie@gmail.com>
>
> * gdb.base/label.c (main): Correct the type of the second
> parameter.
>
> Or something like that.
>
> Thanks,
>
> --
> Sergio