Re: bogus main declaration in gdb.base/label.c

David Blaikie
2013-01-15T18:07:39Z

On Mon, Jan 14, 2013 at 1:28 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "David" == David Blaikie <dblaikie@gmail.com> writes:
>
> David> The declaration of main in gdb.base/label.c is incorrect & fails to
> David> compile under Clang:
>
> David> ../../../src/gdb/7.5/gdb/testsuite/gdb.base/label.c:4:1: error: second
> David> parameter of 'main' (argument array) must be of type 'char **'
> David> main (int argc, char *argv)
> David> ^
>
> David> The attached patch fixes this by adding the missing '*' to the
> David> second parameter.
>
> It needs a ChangeLog entry, but otherwise is ok.

Still a little fuzzy on ChangeLog entries, especially for patches
(following the contribution documentation it ends up pointing at
threads like this: http://gcc.gnu.org/ml/gcc/2000-09/msg00290.html (
from http://gcc.gnu.org/codingconventions.html#ChangeLogs ))

* testsuite/gdb.base/label.c: Correct the type of the second
parameter to main.