From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97686-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32149 invoked by alias); 15 Jan 2013 18:07:39 -0000
Received: (qmail 32137 invoked by uid 22791); 15 Jan 2013 18:07:38 -0000
X-SWARE-Spam-Status: No, hits=-5.0 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-vb0-f53.google.com (HELO mail-vb0-f53.google.com) (209.85.212.53)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Jan 2013 18:07:33 +0000
Received: by mail-vb0-f53.google.com with SMTP id b23so426464vbz.12        for <gdb-patches@sourceware.org>; Tue, 15 Jan 2013 10:07:32 -0800 (PST)
MIME-Version: 1.0
Received: by 10.52.18.147 with SMTP id w19mr93292383vdd.94.1358273252241; Tue, 15 Jan 2013 10:07:32 -0800 (PST)
Received: by 10.220.150.82 with HTTP; Tue, 15 Jan 2013 10:07:32 -0800 (PST)
In-Reply-To: <87k3rfmp2l.fsf@fleche.redhat.com>
References: <CAENS6EvkirKbTgwEQeJG=Wh1728gkwyOPg2+yxkOXjk5z1n3ng@mail.gmail.com>	<87k3rfmp2l.fsf@fleche.redhat.com>
Date: Tue, 15 Jan 2013 18:07:00 -0000
Message-ID: <CAENS6EvD1aJSsLXuJKPT2322LYCk6C01DiuXPXvP0U88HAGH9w@mail.gmail.com>
Subject: Re: bogus main declaration in gdb.base/label.c
From: David Blaikie <dblaikie@gmail.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-01/txt/msg00316.txt.bz2

On Mon, Jan 14, 2013 at 1:28 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "David" == David Blaikie <dblaikie@gmail.com> writes:
>
> David> The declaration of main in gdb.base/label.c is incorrect & fails to
> David> compile under Clang:
>
> David> ../../../src/gdb/7.5/gdb/testsuite/gdb.base/label.c:4:1: error: second
> David> parameter of 'main' (argument array) must be of type 'char **'
> David> main (int argc, char *argv)
> David> ^
>
> David> The attached patch fixes this by adding the missing '*' to the
> David> second parameter.
>
> It needs a ChangeLog entry, but otherwise is ok.

Still a little fuzzy on ChangeLog entries, especially for patches
(following the contribution documentation it ends up pointing at
threads like this: http://gcc.gnu.org/ml/gcc/2000-09/msg00290.html (
from http://gcc.gnu.org/codingconventions.html#ChangeLogs ))

    * testsuite/gdb.base/label.c: Correct the type of the second
parameter to main.