From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7776 invoked by alias); 24 Apr 2014 20:26:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7764 invoked by uid 89); 24 Apr 2014 20:26:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qa0-f41.google.com Received: from mail-qa0-f41.google.com (HELO mail-qa0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 24 Apr 2014 20:26:04 +0000 Received: by mail-qa0-f41.google.com with SMTP id j5so2782377qaq.28 for ; Thu, 24 Apr 2014 13:26:02 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.224.114.209 with SMTP id f17mr6065105qaq.40.1398371162441; Thu, 24 Apr 2014 13:26:02 -0700 (PDT) Received: by 10.140.30.74 with HTTP; Thu, 24 Apr 2014 13:26:02 -0700 (PDT) In-Reply-To: References: <21336.22905.197076.913141@ruffy.mtv.corp.google.com> Date: Thu, 24 Apr 2014 20:26:00 -0000 Message-ID: Subject: Re: [patch] add return values to return statements in non-void functions From: David Blaikie To: Doug Evans Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00512.txt.bz2 On Wed, Apr 23, 2014 at 5:30 PM, Doug Evans wrote: > On Wed, Apr 23, 2014 at 5:23 PM, Doug Evans wrote: >> David Blaikie writes: >> > These missing return values cause build breaks with clang which >> > defaults the -Wreturn-type warning to an error in this case. >> > >> > Add the right return values so these tests can run when using clang. >> > commit ce1534e51863af5d935cdc63c44df0fa64a46653 >> > Author: David Blaikie >> > Date: Fri Apr 11 17:20:49 2014 -0700 >> > >> > Add return value for non-void function return statements to fix error in clang build. >> > >> > Clang defaults this warning to an error, breaking the build & causing >> > these tests not to run. >> > >> > gdb/testsuite/ >> > >> > * gdb.mi/non-stop.c: Add return value for non-void function return >> > statement. >> > * gdb.threads/staticthreads.c: Ditto. >> >> ChangeLog rules require being more specific about where the change happened. >> E.g., >> >> * gdb.mi/non-stop.c (worker): Add return value for non-void function >> return statement. >> * gdb.threads/staticthreads.c (thread_function): Ditto. >> >> Ok with those changes. >> Thanks! > > Bleah. Missed that this one was also already approved. > [that's what I get for switching back and forth between mail readers] No worries - I'll try to keep that in mind for future ChangeLogs. (I assume it's preferred not to go back and fix the ChangeLog that was already committed in this instance)