From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14803 invoked by alias); 15 Jan 2013 18:33:04 -0000 Received: (qmail 14783 invoked by uid 22791); 15 Jan 2013 18:33:03 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-vc0-f175.google.com (HELO mail-vc0-f175.google.com) (209.85.220.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Jan 2013 18:32:49 +0000 Received: by mail-vc0-f175.google.com with SMTP id fy7so449731vcb.20 for ; Tue, 15 Jan 2013 10:32:48 -0800 (PST) MIME-Version: 1.0 Received: by 10.52.21.146 with SMTP id v18mr92093952vde.79.1358274283117; Tue, 15 Jan 2013 10:24:43 -0800 (PST) Received: by 10.220.150.82 with HTTP; Tue, 15 Jan 2013 10:24:43 -0800 (PST) In-Reply-To: References: <87k3rfmp2l.fsf@fleche.redhat.com> Date: Tue, 15 Jan 2013 18:33:00 -0000 Message-ID: Subject: Re: bogus main declaration in gdb.base/label.c From: David Blaikie To: Sergio Durigan Junior Cc: Tom Tromey , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00318.txt.bz2 On Tue, Jan 15, 2013 at 10:18 AM, Sergio Durigan Junior wrote: > On Tuesday, January 15 2013, David Blaikie wrote: > >> Still a little fuzzy on ChangeLog entries, especially for patches >> (following the contribution documentation it ends up pointing at >> threads like this: http://gcc.gnu.org/ml/gcc/2000-09/msg00290.html ( >> from http://gcc.gnu.org/codingconventions.html#ChangeLogs )) >> >> * testsuite/gdb.base/label.c: Correct the type of the second >> parameter to main. > > Hi David, > > Thanks for your contribution. The ChangeLog needs to be written > according to the GNU Coding Standards (as you have noticed). The best > way to learn how to write an entry for them is to take a look at the > existing ChangeLogs: gdb/ChangeLog is a good source of information :-). > In your specific case, there is a ChangeLog file in gdb/testsuite, so > you don't need to include the prefix `testsuite/' in your entry. Ah, hadn't realized there were narrower ChangeLogs (& I'd seen some ChangeLog entries without author prefixes and some with). Thanks for the tips/corrections. > Anyway, you would write your entry as: > > 2013-01-15 David Blaikie > > * gdb.base/label.c (main): Correct the type of the second > parameter. > > Or something like that. > > Thanks, > > -- > Sergio