From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26934 invoked by alias); 5 Sep 2019 22:12:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26926 invoked by uid 89); 5 Sep 2019 22:12:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-yw1-f67.google.com Received: from mail-yw1-f67.google.com (HELO mail-yw1-f67.google.com) (209.85.161.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Sep 2019 22:12:26 +0000 Received: by mail-yw1-f67.google.com with SMTP id u141so1456359ywe.4 for ; Thu, 05 Sep 2019 15:12:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xjo83JLbiMpaWa03DSOoLFS2eMIXgn5sor1cIlr58Wg=; b=gJ3bNoW52b5UQhNUosm7lyveobDBqu3GXg5OMmDHY1GwLq8RJGY37yRNd8sIxlLOHC Ul+HHGgZjtNOo5303ZaYIGscnIG6jwGK+dZ5vWSPBS0rxx+Iq/CBdq2jY+aAnBr46+wY kx8ox09dviZayoBI6aNj0iRfPPcWwcu3MO3zAZS9ir9q1SdmogChivhaceloLrBBznCO El6lI7oX2bKnTqM0DkrUU7eJtPWMlz0x29TX3eOIhrOY3I5wcbAmJBopnDA4vtduuLiV vHrL23XuSelIAi9fUsDDCdm/9AtALYxsYZZf003DrLCfAHH8LxO8I+te+GKNksPEexHf e5YQ== MIME-Version: 1.0 References: <21336.14486.650610.274638@ruffy.mtv.corp.google.com> In-Reply-To: From: David Blaikie Date: Thu, 05 Sep 2019 22:12:00 -0000 Message-ID: Subject: Re: [patch] [gdb/testsuite] XFAIL under Clang tests using label debug info To: Doug Evans , Pedro Alves Cc: gdb-patches Content-Type: multipart/mixed; boundary="000000000000ca4c380591d59d62" X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00058.txt.bz2 --000000000000ca4c380591d59d62 Content-Type: text/plain; charset="UTF-8" Content-length: 2350 Clang now supports labels - so I'd like to essentially revert this patch. Is this OK? On Thu, Apr 24, 2014 at 8:23 PM David Blaikie wrote: > > On Wed, Apr 23, 2014 at 3:03 PM, Doug Evans wrote: > > David Blaikie writes: > > > Clang doesn't emit debug info for labels (Clang PR14500). XFAIL a > > > bunch of GDB tests that rely on debug info for labels. > > > > > > For some reason gdb.linespec/ls-expr.exp gathered all tests into a > > > dictionary and then ran them. This made it hard to XFAIL just the > > > right tests. I refactored this to execute the tests directly, removing > > > the dictionary so I could XFAIL the right tests. Is there a reason it > > > would've been written that way? Does my patch break it in some way? > > > commit c438cb16b63292e415330f289616c4e4ecece63c > > > Author: David Blaikie > > > Date: Sun Apr 13 11:42:02 2014 -0700 > > > > > > XFAIL under Clang tests using labels > > > > > > gdb/testsuite/ > > > * gdb.base/label.exp: XFAIL label related tests under Clang. > > > * gdb.cp/cplabel.exp: Ditto. > > > * gdb.linespec/ls-errs.exp: Refactor tests to execute directly > > > and XFAIL under Clang those using labels. > > > > LGTM > > > > > diff --git gdb/testsuite/ChangeLog gdb/testsuite/ChangeLog > > > index 730c116..b04b940 100644 > > > --- gdb/testsuite/ChangeLog > > > +++ gdb/testsuite/ChangeLog > > > @@ -1,3 +1,9 @@ > > > +2014-04-12 David Blaikie > > > + > > > + * gdb.base/label.exp: XFAIL label related tests under Clang. > > > + * gdb.cp/cplabel.exp: Ditto. > > > + * gdb.linespec/ls-errs.exp: Refactor tests to execute directly and XFAIL under Clang those using labels. > > > + > > > > Nit: space vs tabs. Just use tabs. > > Plus line is longer than 80 chars. > > Thanks for the catches - fixed those up and committed in > c2e827ad5340fcf1735df6c77cb0311e56b985ef. > > Also refactored some of the xfails along the lines of what Pedro > suggested in the one test case that had several similar failures > (gdb.base/label.exp). If/when we fix this in Clang it might be worth > refactoring into a common function (though I'm personally not very > vested in keeping the test suite usable with anything other than ToT > Clang - perhaps others are). --000000000000ca4c380591d59d62 Content-Type: text/x-patch; charset="US-ASCII"; name="labels.diff" Content-Disposition: attachment; filename="labels.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k078x86t0 Content-length: 3921 Y29tbWl0IDc4YzY3YWIxZjIzNGI5MWFhMzAxNmVlMjk5NjZiYTE0MWZkNWI1 YjEKQXV0aG9yOiBEYXZpZCBCbGFpa2llIDxkYmxhaWtpZUBnbWFpbC5jb20+ CkRhdGU6ICAgVGh1IFNlcCA1IDE1OjAxOjI1IDIwMTkgLTA3MDAKCiAgICB1 bi1YRkFJTCB1bmRlciBDbGFuZyB0ZXN0cyB1c2luZyBsYWJlbHMKICAgIAog ICAgZ2RiL3Rlc3RzdWl0ZS8KICAgICAgICAgICAgKiBnZGIuYmFzZS9sYWJl bC5leHA6IHVuLVhGQUlMIGxhYmVsIHJlbGF0ZWQgdGVzdHMgdW5kZXIgQ2xh bmcuCiAgICAgICAgICAgICogZ2RiLmNwL2NwbGFiZWwuZXhwOiBEaXR0by4K ICAgICAgICAgICAgKiBnZGIubGluZXNwZWMvbHMtZXJycy5leHA6IERpdHRv LgoKZGlmZiAtLWdpdCBnZGIvdGVzdHN1aXRlL0NoYW5nZUxvZyBnZGIvdGVz dHN1aXRlL0NoYW5nZUxvZwppbmRleCA0NmM3YjVmOTI3Li4xZDFiNzA2YmIy IDEwMDY0NAotLS0gZ2RiL3Rlc3RzdWl0ZS9DaGFuZ2VMb2cKKysrIGdkYi90 ZXN0c3VpdGUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsOSBAQAorMjAxNC0wNC0y NCAgRGF2aWQgQmxhaWtpZSAgPGRibGFpa2llQGdtYWlsLmNvbT4KKworCSog Z2RiLmJhc2UvbGFiZWwuZXhwOiB1bi1YRkFJTCBsYWJlbCByZWxhdGVkIHRl c3RzIHVuZGVyIENsYW5nLgorCSogZ2RiLmNwL2NwbGFiZWwuZXhwOiBEaXR0 by4KKwkqIGdkYi5saW5lc3BlYy9scy1lcnJzLmV4cDogRGl0dG8uCisKIDIw MTktMDktMDQgIFBoaWxpcHBlIFdhcm9xdWllcnMgIDxwaGlsaXBwZS53YXJv cXVpZXJzQHNreW5ldC5iZT4KIAogCSogZ2RiLmJhc2UvaW5mby12YXIuZXhw OiBUZXN0IGluZm8gdmFyaWFibGVzIHdpdGhvdXQgcnVubmluZwpkaWZmIC0t Z2l0IGdkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvbGFiZWwuZXhwIGdkYi90ZXN0 c3VpdGUvZ2RiLmJhc2UvbGFiZWwuZXhwCmluZGV4IGJjZTkwY2I2MGUuLmVj NDg1MTk3MGUgMTAwNjQ0Ci0tLSBnZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2xh YmVsLmV4cAorKysgZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9sYWJlbC5leHAK QEAgLTI5LDM0ICsyOSwyNCBAQCBpZiB7IVtydW50b19tYWluXX0gewogICBy ZXR1cm4gLTEKIH0KIAotc2V0IGhhc19wcl8xNDUwMF9maXhlZCAxCi1pZiB7 W3Rlc3RfY29tcGlsZXJfaW5mbyB7Y2xhbmctKi0qfV19IHsKLSAgc2V0IGhh c19wcl8xNDUwMF9maXhlZCAwCi19Ci0KLWlmIHshJGhhc19wcl8xNDUwMF9m aXhlZH0geyAgc2V0dXBfeGZhaWwgY2xhbmcvMTQ1MDAgKi0qLSogfQogZ2Ri X3Rlc3QgImJyZWFrIGhlcmUiIFwKICAgIkJyZWFrcG9pbnQuKmF0LioiIFwK ICAgImJyZWFrcG9pbnQgaGVyZSIKIAotaWYgeyEkaGFzX3ByXzE0NTAwX2Zp eGVkfSB7ICBzZXR1cF94ZmFpbCBjbGFuZy8xNDUwMCAqLSotKiB9CiBnZGJf dGVzdCAiYnJlYWsgbWFpbjp0aGVyZSIgXAogICAiQnJlYWtwb2ludC4qYXQu KiIgXAogICAiYnJlYWtwb2ludCB0aGVyZSIKIAotaWYgeyEkaGFzX3ByXzE0 NTAwX2ZpeGVkfSB7ICBzZXR1cF94ZmFpbCBjbGFuZy8xNDUwMCAqLSotKiB9 CiBnZGJfdGVzdCAiY29udCIgXAogICAiQnJlYWtwb2ludCAzLC4qIiBcCiAg ICJjb250aW51ZSB0byAndGhlcmUnIgogCi1pZiB7ISRoYXNfcHJfMTQ1MDBf Zml4ZWR9IHsgIHNldHVwX3hmYWlsIGNsYW5nLzE0NTAwICotKi0qIH0KIGdk Yl90ZXN0ICJjb250IiBcCiAgICJCcmVha3BvaW50IDIsLioiIFwKICAgImNv bnRpbnVlIHRvICdoZXJlJyIKIAogcmVydW5fdG9fbWFpbgogCi1pZiB7ISRo YXNfcHJfMTQ1MDBfZml4ZWR9IHsgIHNldHVwX3hmYWlsIGNsYW5nLzE0NTAw ICotKi0qIH0KIGdkYl90ZXN0ICJjb250IiBcCiAgICJCcmVha3BvaW50IDMs LioiIFwKICAgImNvbnRpbnVlIHRvICd0aGVyZScgYWZ0ZXIgcmUtcnVuIgpk aWZmIC0tZ2l0IGdkYi90ZXN0c3VpdGUvZ2RiLmNwL2NwbGFiZWwuZXhwIGdk Yi90ZXN0c3VpdGUvZ2RiLmNwL2NwbGFiZWwuZXhwCmluZGV4IDI2ODE4Y2Ix YTIuLjkzZmViZDY5MjUgMTAwNjQ0Ci0tLSBnZGIvdGVzdHN1aXRlL2dkYi5j cC9jcGxhYmVsLmV4cAorKysgZ2RiL3Rlc3RzdWl0ZS9nZGIuY3AvY3BsYWJl bC5leHAKQEAgLTM0LDcgKzM0LDYgQEAgc2V0IGxhYmVscyB7InRvX3RoZV90 b3AiICJnZXRfb3V0X29mX2hlcmUifQogZm9yZWFjaCBtICRtZXRob2RzIHsK ICAgICBmb3JlYWNoIGwgJGxhYmVscyB7CiAJc2V0IGxpbmUgW2dkYl9nZXRf bGluZV9udW1iZXIgIiRtOiRsIl0KLQlpZiB7W3Rlc3RfY29tcGlsZXJfaW5m byB7Y2xhbmctKi0qfV19IHsgc2V0dXBfeGZhaWwgY2xhbmcvMTQ1MDAgKi0q LSogfQogCWdkYl90ZXN0ICJicmVhayBmb286OiRtOiRsIiBcCiAJICAgICJC cmVha3BvaW50ICRkZWNpbWFsIGF0ICRoZXg6IGZpbGUgLiokc3JjZmlsZSwg bGluZSAkbGluZVwuIgogICAgIH0KZGlmZiAtLWdpdCBnZGIvdGVzdHN1aXRl L2dkYi5saW5lc3BlYy9scy1lcnJzLmV4cCBnZGIvdGVzdHN1aXRlL2dkYi5s aW5lc3BlYy9scy1lcnJzLmV4cAppbmRleCA5MmE4NThjZTI2Li5mMDMxYzQ2 MWNiIDEwMDY0NAotLS0gZ2RiL3Rlc3RzdWl0ZS9nZGIubGluZXNwZWMvbHMt ZXJycy5leHAKKysrIGdkYi90ZXN0c3VpdGUvZ2RiLmxpbmVzcGVjL2xzLWVy cnMuZXhwCkBAIC0yMzEsOSArMjMxLDYgQEAgcHJvYyBkb190ZXN0IHtsYW5n fSB7CiAKICAgICBmb3JlYWNoIHggJHNwYWNlcyB7CiAJdGVzdF9icmVhayAi bWFpbiR7eH10aGVyZSIgaW52YWxpZF9sYWJlbCAidGhlcmUiICJtYWluIgot CWlmIHtbdGVzdF9jb21waWxlcl9pbmZvIHtjbGFuZy0qLSp9XX0gewotCSAg ICBzZXR1cF94ZmFpbCBjbGFuZy8xNDUwMCAqLSotKgotCX0KIAl0ZXN0X2Jy ZWFrICJtYWluOmhlcmUke3h9IiB1bmV4cGVjdGVkICJlbmQgb2YgaW5wdXQi CiAgICAgfQogCg== --000000000000ca4c380591d59d62--