From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10937 invoked by alias); 13 Apr 2014 07:08:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10916 invoked by uid 89); 13 Apr 2014 07:08:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qa0-f41.google.com Received: from mail-qa0-f41.google.com (HELO mail-qa0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 13 Apr 2014 07:08:12 +0000 Received: by mail-qa0-f41.google.com with SMTP id j5so6956208qaq.0 for ; Sun, 13 Apr 2014 00:08:10 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.224.50.211 with SMTP id a19mr11046775qag.49.1397372890622; Sun, 13 Apr 2014 00:08:10 -0700 (PDT) Received: by 10.140.30.74 with HTTP; Sun, 13 Apr 2014 00:08:10 -0700 (PDT) In-Reply-To: References: Date: Sun, 13 Apr 2014 07:08:00 -0000 Message-ID: Subject: Re: [patch] explicitly specify -std=gnu89 for gdb.cp/inline-break.exp From: David Blaikie To: Andrew Pinski Cc: gdb-patches , Eric Christopher , Doug Evans Content-Type: multipart/mixed; boundary=047d7bdc8de2c3d64804f6e73a2b X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00245.txt.bz2 --047d7bdc8de2c3d64804f6e73a2b Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1032 On Fri, Apr 11, 2014 at 7:59 PM, Andrew Pinski wrote: > On Fri, Apr 11, 2014 at 4:58 PM, David Blaikie wrote: >> This test is intending to use gnu style inline rather than the >> standard c99 inline semantics. Clang defaults to c99 and the test >> breaks for this (and other - there's an inlining debug info quality >> bug here too - I'll file a bug and kfail the remaining failures in a >> separate patch) reason. > > Or better yet, use the gnu_inline attribute on those functions. Ah, good plan - patch attached for that fix instead. Though at this point, I'd consider removing the GNUC conditional - for this test to be meaningful the compiler must support gnu inlining semantics. Are there compilers that support those semantics but don't support GCC attribute syntax and the gnu_inline attribute in particular? Removing the conditional would cause any compiler that doesn't support the attributes to just fail to compile, marking the test as untested rather than producing failures. --047d7bdc8de2c3d64804f6e73a2b Content-Type: text/plain; charset=US-ASCII; name="gnu_inline.diff" Content-Disposition: attachment; filename="gnu_inline.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_htxzn5c70 Content-length: 2855 Y29tbWl0IGEwZjdkOTE2YmYyNzQzMjViMTUzNWQ3ZjRlYWRlNDM5NTNjYjJi ZjIKQXV0aG9yOiBEYXZpZCBCbGFpa2llIDxkYmxhaWtpZUBnbWFpbC5jb20+ CkRhdGU6ICAgU3VuIEFwciAxMyAwMDowMToyMSAyMDE0IC0wNzAwCgogICAg VXNlIGF0dHJpYnV0ZSB0byBzcGVjaWZ5IHRoZSByZXF1aXJlZCBpbmxpbmlu ZyBzZW1hbnRpY3MKICAgIAogICAgQXMgc3VnZ2VzdGVkIGJ5IEFuZHJldyBQ aW5za2kuCiAgICAKICAgIGdkYi90ZXN0c3VpdGUvCiAgICAJKiBnZGIub3B0 L2lubGluZS1icmVhay5jOiBGaXggY2xhbmcgY29tcGF0aWJpbGl0eSBieSBz cGVjaWZ5aW5nCiAgICAJZ251X2lubGluZSBzZW1hbnRpY3MgdmlhIGF0dHJp YnV0ZS4KICAgIAkqIGdkYi5vcHQvaW5saW5lLWJyZWFrLmV4cDogUmVtb3Zl IC1zdGQ9Yzg5IG5vdyB0aGF0IHRoZSB0ZXN0IHNvdXJjZQogICAgCWV4cGxp Y2l0bHkgc3BlY2lmaWVzIHRoZSByZXF1aXJlZCBzZW1hbnRpY3MuCgpkaWZm IC0tZ2l0IGdkYi90ZXN0c3VpdGUvQ2hhbmdlTG9nIGdkYi90ZXN0c3VpdGUv Q2hhbmdlTG9nCmluZGV4IDczMGMxMTYuLjQ0YjJlZWIgMTAwNjQ0Ci0tLSBn ZGIvdGVzdHN1aXRlL0NoYW5nZUxvZworKysgZ2RiL3Rlc3RzdWl0ZS9DaGFu Z2VMb2cKQEAgLTYsNiArNiwxMyBAQAogCiAyMDE0LTA0LTExICBEYXZpZCBC bGFpa2llICA8ZGJsYWlraWVAZ21haWwuY29tPgogCisJKiBnZGIub3B0L2lu bGluZS1icmVhay5jOiBGaXggY2xhbmcgY29tcGF0aWJpbGl0eSBieSBzcGVj aWZ5aW5nCisJZ251X2lubGluZSBzZW1hbnRpY3MgdmlhIGF0dHJpYnV0ZS4K KwkqIGdkYi5vcHQvaW5saW5lLWJyZWFrLmV4cDogUmVtb3ZlIC1zdGQ9Yzg5 IG5vdyB0aGF0IHRoZSB0ZXN0IHNvdXJjZQorCWV4cGxpY2l0bHkgc3BlY2lm aWVzIHRoZSByZXF1aXJlZCBzZW1hbnRpY3MuCisKKzIwMTQtMDQtMTEgIERh dmlkIEJsYWlraWUgIDxkYmxhaWtpZUBnbWFpbC5jb20+CisKIAkqIGdkYi5v cHQvaW5saW5lLWJyZWFrLmV4cDogRXhwbGljaXRseSBzcGVjaWZ5IC1zdGQ9 Z251ODkgdG8KIAlvdmVycmlkZSBDbGFuZydzIGRlZmF1bHQuCiAKZGlmZiAt LWdpdCBnZGIvdGVzdHN1aXRlL2dkYi5vcHQvaW5saW5lLWJyZWFrLmMgZ2Ri L3Rlc3RzdWl0ZS9nZGIub3B0L2lubGluZS1icmVhay5jCmluZGV4IDk1MTNl ZWMuLmY4YTllYzkgMTAwNjQ0Ci0tLSBnZGIvdGVzdHN1aXRlL2dkYi5vcHQv aW5saW5lLWJyZWFrLmMKKysrIGdkYi90ZXN0c3VpdGUvZ2RiLm9wdC9pbmxp bmUtYnJlYWsuYwpAQCAtMTksNyArMTksNyBAQAogICAgdGhpcyBmaWxlLCBh bmQgc2hvdWxkIGJlIHJlZ2VuZXJhdGVkIGlmIHRoaXMgZmlsZSBpcyBtb2Rp ZmllZC4gICovCiAKICNpZmRlZiBfX0dOVUNfXwotIyBkZWZpbmUgQVRUUiBf X2F0dHJpYnV0ZV9fKChhbHdheXNfaW5saW5lKSkKKyMgZGVmaW5lIEFUVFIg X19hdHRyaWJ1dGVfXygoZ251X2lubGluZSkpIF9fYXR0cmlidXRlX18oKGFs d2F5c19pbmxpbmUpKQogI2Vsc2UKICMgZGVmaW5lIEFUVFIKICNlbmRpZgpk aWZmIC0tZ2l0IGdkYi90ZXN0c3VpdGUvZ2RiLm9wdC9pbmxpbmUtYnJlYWsu ZXhwIGdkYi90ZXN0c3VpdGUvZ2RiLm9wdC9pbmxpbmUtYnJlYWsuZXhwCmlu ZGV4IDRmZjM3OWEuLjIxYzk1OGEgMTAwNjQ0Ci0tLSBnZGIvdGVzdHN1aXRl L2dkYi5vcHQvaW5saW5lLWJyZWFrLmV4cAorKysgZ2RiL3Rlc3RzdWl0ZS9n ZGIub3B0L2lubGluZS1icmVhay5leHAKQEAgLTE5LDEwICsxOSw4IEBACiAK IHN0YW5kYXJkX3Rlc3RmaWxlCiAKLSMgRXhwbGljaXRseSBzcGVjaWZ5IGdu dTg5IGZvciBnbnUgaW5saW5lIHNlbWFudGljcyB0byBvdmVycmlkZSBDbGFu ZydzIGRlZmF1bHQKLSMgb2YgYzk5LgogaWYgeyBbcHJlcGFyZV9mb3JfdGVz dGluZyAkdGVzdGZpbGUuZXhwICR0ZXN0ZmlsZSAkc3JjZmlsZSBcCi0gICAg ICAgICAge2RlYnVnIG9wdGltaXplPS1PMiBhZGRpdGlvbmFsX2ZsYWdzPS1X aW5saW5lIGFkZGl0aW9uYWxfZmxhZ3M9LXN0ZD1nbnU4OX1dIH0geworICAg ICAgICAgIHtkZWJ1ZyBvcHRpbWl6ZT0tTzIgYWRkaXRpb25hbF9mbGFncz0t V2lubGluZX1dIH0gewogICAgIHJldHVybiAtMQogfQogCg== --047d7bdc8de2c3d64804f6e73a2b--