From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7490 invoked by alias); 11 Apr 2014 06:51:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7477 invoked by uid 89); 11 Apr 2014 06:51:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qa0-f52.google.com Received: from mail-qa0-f52.google.com (HELO mail-qa0-f52.google.com) (209.85.216.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 11 Apr 2014 06:51:52 +0000 Received: by mail-qa0-f52.google.com with SMTP id s7so2956090qap.11 for ; Thu, 10 Apr 2014 23:51:50 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.224.5.136 with SMTP id 8mr26707255qav.42.1397199110003; Thu, 10 Apr 2014 23:51:50 -0700 (PDT) Received: by 10.140.30.74 with HTTP; Thu, 10 Apr 2014 23:51:49 -0700 (PDT) Date: Fri, 11 Apr 2014 06:51:00 -0000 Message-ID: Subject: [patch] Fix unused static symbols so they're not dropped by clang From: David Blaikie To: gdb-patches@sourceware.org, Eric Christopher , Doug Evans Content-Type: multipart/mixed; boundary=001a11c2c59aa1f0eb04f6bec463 X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00196.txt.bz2 --001a11c2c59aa1f0eb04f6bec463 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 789 Several tests used file-static functions and variables that were not referenced by the code. Even at -O0, clang omits these entities at the frontend so the tests fail. Since it doesn't look like these tests needed this functionality for what they were testing, I've modified the variables/functions to either be non-static, or marked them with __attribute__((used)). If it's preferred that I use the attribute more pervasively, rather than just making the entities non-static, I can provide a patch for that (or some other preferred solution). There's certainly precedent for both (non-static entities and __attribute__((used)) in the testsuite already and much more of the former than the latter). I have commit-after-review access, so just looking for sign-off here. Thanks, - David --001a11c2c59aa1f0eb04f6bec463 Content-Type: text/plain; charset=US-ASCII; name="unused.diff" Content-Disposition: attachment; filename="unused.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_htv474j50 Content-length: 7524 Y29tbWl0IGQ3MmIwNDJjYmQ0ZjBhZjZkMmU0YWM2OTAxNDQ1Njc3YjkzZjc3 ZWUKQXV0aG9yOiBEYXZpZCBCbGFpa2llIDxkYmxhaWtpZUBnbWFpbC5jb20+ CkRhdGU6ICAgVGh1IEFwciAxMCAyMzo0NToyOCAyMDE0IC0wNzAwCgogICAg RW5zdXJlIHVucmVmZXJlbmNlZCBzdGF0aWMgc3ltYm9scyBhcmVuJ3Qgb21p dHRlZCBieSBjbGFuZyAoZWl0aGVyIG1hcmtpbmcgdGhlbSBfX2F0dHJpYnV0 ZV9fKCh1c2VkKSkgb3IgbWFraW5nIHRoZW0gbm9uLXN0YXRpYykKICAgIAog ICAgZ2RiL3Rlc3RzdWl0ZS8KICAgICAgICAgICAqIGdkYi5iYXNlL2NhdGNo LXN5c2NhbGwuYzogTWFrZSB1bnJlZmVyZW5jZWQgc3RhdGljcyBub24tc3Rh dGljIHRvCiAgICAgICAgICAgZW5zdXJlIGNsYW5nIHdvdWxkIG5vdCBkaXNj YXJkIHRoZW0uCiAgICAgICAgICAgKiBnZGIuYmFzZS9nZGJ2YXJzLmM6IERp dHRvLgogICAgICAgICAgICogZ2RiLmJhc2UvbWVtYXR0ci5jOiBEaXR0by4K ICAgICAgICAgICAqIGdkYi5iYXNlL3doYXRpcy5jOiBEaXR0by4KICAgICAg ICAgICAqIGdkYi5weXRob24vcHktcHJldHR5cHJpbnQuYzogRGl0dG8uCiAg ICAgICAgICAgKiBnZGIudHJhY2UvYWN0aW9ucy5jOiBEaXR0by4KICAgICAg ICAgICAqIGdkYi5jcC9wdHlwZS1jdi1jcC5jYzogTWFyayB1bnVzZWQgZ2xv YmFsIGNvbnN0IGludCBhcyB1c2VkIHRvCiAgICAgICAgICAgZW5zdXJlIGNs YW5nIHdvdWxkIG5vdCBkaXNjYXJkIGl0LgoKZGlmZiAtLWdpdCBnZGIvdGVz dHN1aXRlL0NoYW5nZUxvZyBnZGIvdGVzdHN1aXRlL0NoYW5nZUxvZwppbmRl eCAxMmVkNGY5Li42MjM4MzFhIDEwMDY0NAotLS0gZ2RiL3Rlc3RzdWl0ZS9D aGFuZ2VMb2cKKysrIGdkYi90ZXN0c3VpdGUvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTQtMDQtMTAgIERhdmlkIEJsYWlraWUgIDxkYmxhaWtp ZUBnbWFpbC5jb20+CisKKwkqIGdkYi5iYXNlL2NhdGNoLXN5c2NhbGwuYzog TWFrZSB1bnJlZmVyZW5jZWQgc3RhdGljcyBub24tc3RhdGljIHRvCisJZW5z dXJlIGNsYW5nIHdvdWxkIG5vdCBkaXNjYXJkIHRoZW0uIAorCSogZ2RiLmJh c2UvZ2RidmFycy5jOiBEaXR0by4KKwkqIGdkYi5iYXNlL21lbWF0dHIuYzog RGl0dG8uCisJKiBnZGIuYmFzZS93aGF0aXMuYzogRGl0dG8uCisJKiBnZGIu cHl0aG9uL3B5LXByZXR0eXByaW50LmM6IERpdHRvLgorCSogZ2RiLnRyYWNl L2FjdGlvbnMuYzogRGl0dG8uCisJKiBnZGIuY3AvcHR5cGUtY3YtY3AuY2M6 IE1hcmsgdW51c2VkIGdsb2JhbCBjb25zdCBpbnQgYXMgdXNlZCB0bworCWVu c3VyZSBjbGFuZyB3b3VsZCBub3QgZGlzY2FyZCBpdC4KKwogMjAxNC0wNC0x MCAgUGVkcm8gQWx2ZXMgIDxwYWx2ZXNAcmVkaGF0LmNvbT4KIAogCSogZ2Ri LmJhc2UvY29uZC1ldmFsLW1vZGUuYzogTmV3IGZpbGUuCmRpZmYgLS1naXQg Z2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9jYXRjaC1zeXNjYWxsLmMgZ2RiL3Rl c3RzdWl0ZS9nZGIuYmFzZS9jYXRjaC1zeXNjYWxsLmMKaW5kZXggYWE1NzI3 YS4uZWEzM2I5MyAxMDA2NDQKLS0tIGdkYi90ZXN0c3VpdGUvZ2RiLmJhc2Uv Y2F0Y2gtc3lzY2FsbC5jCisrKyBnZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2Nh dGNoLXN5c2NhbGwuYwpAQCAtMTQsMTYgKzE0LDE2IEBACiAKIC8qIFRoZXNl IGFyZSB0aGUgc3lzY2FsbHMgbnVtYmVycyB1c2VkIGJ5IHRoZSB0ZXN0LiAg Ki8KIAotc3RhdGljIGludCBjbG9zZV9zeXNjYWxsID0gU1lTX2Nsb3NlOwot c3RhdGljIGludCBjaHJvb3Rfc3lzY2FsbCA9IFNZU19jaHJvb3Q7CitpbnQg Y2xvc2Vfc3lzY2FsbCA9IFNZU19jbG9zZTsKK2ludCBjaHJvb3Rfc3lzY2Fs bCA9IFNZU19jaHJvb3Q7CiAvKiBHREIgaGFkIGEgYnVnIHdoZXJlIGl0IGNv dWxkbid0IGNhdGNoIHN5c2NhbGwgbnVtYmVyIDAgKFBSIDE2Mjk3KS4KICAg IEluIG1vc3QgR05VL0xpbnV4IGFyY2hpdGVjdHVyZXMsIHN5c2NhbGwgbnVt YmVyIDAgaXMKICAgIHJlc3RhcnRfc3lzY2FsbCwgd2hpY2ggY2FuJ3QgYmUg Y2FsbGVkIGZyb20gdXNlcnNwYWNlLiAgSG93ZXZlciwKICAgIHRoZSAicmVh ZCIgc3lzY2FsbCBpcyB6ZXJvIG9uIHg4Nl82NC4gICovCi1zdGF0aWMgaW50 IHJlYWRfc3lzY2FsbCA9IFNZU19yZWFkOwotc3RhdGljIGludCBwaXBlX3N5 c2NhbGwgPSBTWVNfcGlwZTsKLXN0YXRpYyBpbnQgd3JpdGVfc3lzY2FsbCA9 IFNZU193cml0ZTsKLXN0YXRpYyBpbnQgZXhpdF9ncm91cF9zeXNjYWxsID0g U1lTX2V4aXRfZ3JvdXA7CitpbnQgcmVhZF9zeXNjYWxsID0gU1lTX3JlYWQ7 CitpbnQgcGlwZV9zeXNjYWxsID0gU1lTX3BpcGU7CitpbnQgd3JpdGVfc3lz Y2FsbCA9IFNZU193cml0ZTsKK2ludCBleGl0X2dyb3VwX3N5c2NhbGwgPSBT WVNfZXhpdF9ncm91cDsKIAogaW50CiBtYWluICh2b2lkKQpkaWZmIC0tZ2l0 IGdkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvZ2RidmFycy5jIGdkYi90ZXN0c3Vp dGUvZ2RiLmJhc2UvZ2RidmFycy5jCmluZGV4IDM1MmE3NmIuLjQ2ZmE4NGIg MTAwNjQ0Ci0tLSBnZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2dkYnZhcnMuYwor KysgZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9nZGJ2YXJzLmMKQEAgLTQsMTIg KzQsMTIgQEAgdHlwZWRlZiB2b2lkICpwdHI7CiAKIHB0ciBwID0gJnA7CiAK LXN0YXRpYyB2b2lkCit2b2lkCiBmb29fdm9pZCAodm9pZCkKIHsKIH0KIAot c3RhdGljIGludAoraW50CiBmb29faW50ICh2b2lkKQogewogICByZXR1cm4g MDsKZGlmZiAtLWdpdCBnZGIvdGVzdHN1aXRlL2dkYi5iYXNlL21lbWF0dHIu YyBnZGIvdGVzdHN1aXRlL2dkYi5iYXNlL21lbWF0dHIuYwppbmRleCA3NGIy ZDYxLi42Mjg2OGI2IDEwMDY0NAotLS0gZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFz ZS9tZW1hdHRyLmMKKysrIGdkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvbWVtYXR0 ci5jCkBAIC0xNiwxMSArMTYsMTEgQEAKICAgIGFsb25nIHdpdGggdGhpcyBw cm9ncmFtLiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNl bnNlcy8+LiAgKi8KIAogI2RlZmluZSBNRU1TSVpFIDY0Ci1zdGF0aWMgaW50 IG1lbTFbTUVNU0laRV0gPSB7MTExLCAyMjIsIDMzMywgNDQ0LCA1NTV9Owot c3RhdGljIGludCBtZW0yW01FTVNJWkVdOwotc3RhdGljIGludCBtZW0zW01F TVNJWkVdOwotc3RhdGljIGludCBtZW00W01FTVNJWkVdOwotc3RhdGljIGlu dCBtZW01W01FTVNJWkVdOworaW50IG1lbTFbTUVNU0laRV0gPSB7MTExLCAy MjIsIDMzMywgNDQ0LCA1NTV9OworaW50IG1lbTJbTUVNU0laRV07CitpbnQg bWVtM1tNRU1TSVpFXTsKK2ludCBtZW00W01FTVNJWkVdOworaW50IG1lbTVb TUVNU0laRV07CiAKIGludCBtYWluKCkKIHsKZGlmZiAtLWdpdCBnZGIvdGVz dHN1aXRlL2dkYi5iYXNlL3doYXRpcy5jIGdkYi90ZXN0c3VpdGUvZ2RiLmJh c2Uvd2hhdGlzLmMKaW5kZXggYTFhMzE4OC4uYmNkYTVmZCAxMDA2NDQKLS0t IGdkYi90ZXN0c3VpdGUvZ2RiLmJhc2Uvd2hhdGlzLmMKKysrIGdkYi90ZXN0 c3VpdGUvZ2RiLmJhc2Uvd2hhdGlzLmMKQEAgLTg4LDE0ICs4OCwxNCBAQCBk b3VibGUJCXZfZG91YmxlX2FycmF5WzJdOwogICAgYSBzcGVjaWFsIGNhc2Ug a2x1ZGdlIGluIEdEQiAoVW5peCBzeXN0ZW0gaW5jbHVkZSBmaWxlcyBsaWtl IHRvIGRlZmluZQogICAgY2FkZHJfdCksIGJ1dCBmb3IgYSB2YXJpZXR5IG9m IHR5cGVzLiAgKi8KIHR5cGVkZWYgY2hhciAqY2hhcl9hZGRyOwotc3RhdGlj IGNoYXJfYWRkciBhX2NoYXJfYWRkcjsKK2NoYXJfYWRkciBhX2NoYXJfYWRk cjsKIHR5cGVkZWYgdW5zaWduZWQgc2hvcnQgKnVzaG9ydF9hZGRyOwotc3Rh dGljIHVzaG9ydF9hZGRyIGFfdXNob3J0X2FkZHI7Cit1c2hvcnRfYWRkciBh X3VzaG9ydF9hZGRyOwogdHlwZWRlZiBzaWduZWQgbG9uZyAqc2xvbmdfYWRk cjsKLXN0YXRpYyBzbG9uZ19hZGRyIGFfc2xvbmdfYWRkcjsKK3Nsb25nX2Fk ZHIgYV9zbG9uZ19hZGRyOwogI2lmbmRlZiBOT19MT05HX0xPTkcKIHR5cGVk ZWYgc2lnbmVkIGxvbmcgbG9uZyAqc2xvbmdfbG9uZ19hZGRyOwotc3RhdGlj IHNsb25nX2xvbmdfYWRkciBhX3Nsb25nX2xvbmdfYWRkcjsKK3Nsb25nX2xv bmdfYWRkciBhX3Nsb25nX2xvbmdfYWRkcjsKICNlbmRpZgogCiBjaGFyCQkq dl9jaGFyX3BvaW50ZXI7CmRpZmYgLS1naXQgZ2RiL3Rlc3RzdWl0ZS9nZGIu Y3AvcHR5cGUtY3YtY3AuY2MgZ2RiL3Rlc3RzdWl0ZS9nZGIuY3AvcHR5cGUt Y3YtY3AuY2MKaW5kZXggNjU0NmY2OC4uYWRkNDAyMSAxMDA2NDQKLS0tIGdk Yi90ZXN0c3VpdGUvZ2RiLmNwL3B0eXBlLWN2LWNwLmNjCisrKyBnZGIvdGVz dHN1aXRlL2dkYi5jcC9wdHlwZS1jdi1jcC5jYwpAQCAtMjIsNyArMjIsNyBA QCB0eXBlZGVmIHZvbGF0aWxlIGNvbnN0X215X2ludCB2b2xhdGlsZV9jb25z dF9teV9pbnQ7CiB0eXBlZGVmIGNvbnN0IHZvbGF0aWxlX215X2ludCBjb25z dF92b2xhdGlsZV9teV9pbnQ7CiAKIG15X2ludCB2X215X2ludCAoMCk7Ci1j b25zdF9teV9pbnQgdl9jb25zdF9teV9pbnQgKDEpOworX19hdHRyaWJ1dGVf XygodXNlZCkpIGNvbnN0X215X2ludCB2X2NvbnN0X215X2ludCAoMSk7CiB2 b2xhdGlsZV9teV9pbnQgdl92b2xhdGlsZV9teV9pbnQgKDIpOwogY29uc3Rf dm9sYXRpbGVfbXlfaW50IHZfY29uc3Rfdm9sYXRpbGVfbXlfaW50ICgzKTsK IHZvbGF0aWxlX2NvbnN0X215X2ludCB2X3ZvbGF0aWxlX2NvbnN0X215X2lu dCAoNCk7CmRpZmYgLS1naXQgZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5 LXByZXR0eXByaW50LmMgZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5LXBy ZXR0eXByaW50LmMKaW5kZXggMGZkMDVmNS4uODE3YmYzMyAxMDA2NDQKLS0t IGdkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1wcmV0dHlwcmludC5jCisr KyBnZGIvdGVzdHN1aXRlL2dkYi5weXRob24vcHktcHJldHR5cHJpbnQuYwpA QCAtMjMwLDcgKzIzMCw3IEBAIHN0cnVjdCBudWxsc3RyCiBzdHJ1Y3Qgc3Ry aW5nX3JlcHIgc3RyaW5nXzEgPSB7IHsgIm9uZSIgfSB9Owogc3RydWN0IHN0 cmluZ19yZXByIHN0cmluZ18yID0geyB7ICJ0d28iIH0gfTsKIAotc3RhdGlj IGludAoraW50CiBldmFsX2Z1bmMgKGludCBwMSwgaW50IHAyLCBpbnQgcDMs IGludCBwNCwgaW50IHA1LCBpbnQgcDYsIGludCBwNywgaW50IHA4KQogewog ICByZXR1cm4gcDE7CmRpZmYgLS1naXQgZ2RiL3Rlc3RzdWl0ZS9nZGIudHJh Y2UvYWN0aW9ucy5jIGdkYi90ZXN0c3VpdGUvZ2RiLnRyYWNlL2FjdGlvbnMu YwppbmRleCAwNGM2OWYyLi40OTdkMDRkIDEwMDY0NAotLS0gZ2RiL3Rlc3Rz dWl0ZS9nZGIudHJhY2UvYWN0aW9ucy5jCisrKyBnZGIvdGVzdHN1aXRlL2dk Yi50cmFjZS9hY3Rpb25zLmMKQEAgLTExNiw3ICsxMTYsNyBAQCB1bnNpZ25l ZCBsb25nICAgZ2RiX2NfdGVzdCggdW5zaWduZWQgbG9uZyAqcGFybSApCiAg ICByZXR1cm4gKCAodW5zaWduZWQgbG9uZykgMCApOwogfQogCi1zdGF0aWMg dm9pZCBnZGJfYXNtX3Rlc3QgKHZvaWQpCit2b2lkIGdkYl9hc21fdGVzdCAo dm9pZCkKIHsKIH0KIAo= --001a11c2c59aa1f0eb04f6bec463--