Re: [Patch] Mechanism for board files to set default remotetimeout

[Sterling Augustine <saugustine@google.com>]

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

On Fri, May 31, 2013 at 1:57 PM, Sterling Augustine
<saugustine@google.com> wrote:
> On Fri, May 31, 2013 at 3:13 AM, Pedro Alves <palves@redhat.com> wrote:
>> On 05/31/2013 12:42 AM, Sterling Augustine wrote:
>>> The enclosed simple patch adds and demonstrates a new mechanism for a
>>> board file to declare a default remotetimeout.
>>
>> Took me a bit to realize this is about "set remotetimeout" in gdb,
>> not the expect timeout.  It wasn't that obvious from the
>> description.  :-)
>>
>> Is this really necessary?  The board could just append "-l TIMEOUT"
>> to the GDB command line invocation.  Looks simpler, and doesn't
>> depend on issuing an interactive GDB command.
>
> I'll switch to this.

How does this look? I considered using GDBFLAGS instead of
INTERNAL_GDBFLAGS, but lots of tests replace GDBFLAGS with their own
copy, preventing its use in many cases.

Sterling

2013-05-30  Sterling Augustine  <saugustine@google.com>

	* boards/remote-stdio-gdbserver.exp: Add code to customize remotetimeout
	value via INTERNAL_GDBFLAGS.

[-- Attachment #2: remotetimeout.patch --]
[-- Type: application/octet-stream, Size: 1135 bytes --]

Index: lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.231
diff -u -r1.231 gdb.exp
--- lib/gdb.exp	6 May 2013 22:11:15 -0000	1.231
+++ lib/gdb.exp	31 May 2013 22:47:03 -0000
@@ -1403,6 +1403,7 @@
     global gdb_prompt
     global timeout
     global gdb_spawn_id;
+    global gdb_remotetimeout
 
     gdb_stop_suppressing_tests;
 
Index: boards/remote-stdio-gdbserver.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/boards/remote-stdio-gdbserver.exp,v
retrieving revision 1.1
diff -u -r1.1 remote-stdio-gdbserver.exp
--- boards/remote-stdio-gdbserver.exp	21 May 2013 17:58:46 -0000	1.1
+++ boards/remote-stdio-gdbserver.exp	31 May 2013 22:47:03 -0000
@@ -26,6 +26,13 @@
 
 load_board_description "native-stdio-gdbserver"
 
+global INTERNAL_GDBFLAGS
+if [info exists REMOTE_TIMEOUT] {
+    append INTERNAL_GDBFLAGS " -l $REMOTE_TIMEOUT"
+} else {
+    append INTERNAL_GDBFLAGS " -l 10"
+}
+
 set_board_info rsh_prog /usr/bin/ssh
 set_board_info rcp_prog /usr/bin/scp