From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82209-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23764 invoked by alias); 12 Jul 2011 16:21:04 -0000
Received: (qmail 23749 invoked by uid 22791); 12 Jul 2011 16:21:02 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Jul 2011 16:20:42 +0000
Received: from hpaq7.eem.corp.google.com (hpaq7.eem.corp.google.com [172.25.149.7])	by smtp-out.google.com with ESMTP id p6CGKfmB024730	for <gdb-patches@sourceware.org>; Tue, 12 Jul 2011 09:20:41 -0700
Received: from gwb20 (gwb20.prod.google.com [10.200.2.20])	by hpaq7.eem.corp.google.com with ESMTP id p6CGKdhL025946	(version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT)	for <gdb-patches@sourceware.org>; Tue, 12 Jul 2011 09:20:40 -0700
Received: by gwb20 with SMTP id 20so2403200gwb.31        for <gdb-patches@sourceware.org>; Tue, 12 Jul 2011 09:20:38 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.101.147.27 with SMTP id z27mr127943ann.68.1310487638674; Tue, 12 Jul 2011 09:20:38 -0700 (PDT)
Received: by 10.101.1.6 with HTTP; Tue, 12 Jul 2011 09:20:38 -0700 (PDT)
In-Reply-To: <20110712111440.GA21949@host1.jankratochvil.net>
References: <BANLkTikW2qaihdZ2zGxx6K+4q8eGzFZOr3mcbPdZsJ+2Ra=YXQ@mail.gmail.com>	<20110612121158.GA10611@host1.jankratochvil.net>	<BANLkTik1Z5GoCjNP9enPJeLThVk=g9Aj5ZF6zeDULburd2w=bw@mail.gmail.com>	<CAEG7qUxvW4whZv2ER_x+VTpmnJ=RUQRfSb6MX3nnWE4e=UA09w@mail.gmail.com>	<20110711185334.GA10138@host1.jankratochvil.net>	<CAEG7qUxFvEoJ-E2YsoFPL-tKoK4kD3-pKn-h31uUeXQoDD2Gaw@mail.gmail.com>	<20110712111440.GA21949@host1.jankratochvil.net>
Date: Tue, 12 Jul 2011 17:48:00 -0000
Message-ID: <CAEG7qUySeRVeODKGjkTh5KXhZZX8SazVKK-9F8e8CXOiXp9w5w@mail.gmail.com>
Subject: Re: [dwarf2_mark_helper patch] Re: [PATCH] Make interrupting tab-completion safe.
From: Sterling Augustine <saugustine@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-System-Of-Record: true
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00304.txt.bz2

FWIW, this patch works great for me. Thanks.

Sterling

On Tue, Jul 12, 2011 at 4:14 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
...

> gdb/
> 2011-07-12 =A0Jan Kratochvil =A0<jan.kratochvil@redhat.com>
>
> =A0 =A0 =A0 =A0Fix occasional crash of CTRL-C during DWARF read in.
> =A0 =A0 =A0 =A0* dwarf2read.c (dwarf2_mark_helper): Return on NULL CU.
>
> --- a/gdb/dwarf2read.c
> +++ b/gdb/dwarf2read.c
> @@ -15455,6 +15455,13 @@ dwarf2_mark_helper (void **slot, void *data)
> =A0 struct dwarf2_per_cu_data *per_cu;
>
> =A0 per_cu =3D (struct dwarf2_per_cu_data *) *slot;
> +
> + =A0/* cu->dependencies references may not yet have been ever read if QU=
IT aborts
> + =A0 =A0 reading of the chain. =A0As such dependencies remain valid ther=
e is not much
> + =A0 =A0 useful to track and undo them during QUIT cleanups. =A0*/
> + =A0if (per_cu->cu =3D=3D NULL)
> + =A0 =A0return 1;
> +
> =A0 if (per_cu->cu->mark)
> =A0 =A0 return 1;
> =A0 per_cu->cu->mark =3D 1;
>