From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17589 invoked by alias); 16 Jul 2012 17:09:44 -0000 Received: (qmail 17571 invoked by uid 22791); 16 Jul 2012 17:09:43 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-yw0-f41.google.com (HELO mail-yw0-f41.google.com) (209.85.213.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Jul 2012 17:09:30 +0000 Received: by yhr47 with SMTP id 47so5632302yhr.0 for ; Mon, 16 Jul 2012 10:09:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=SmfTZw5XoZP3ltAQemYrZk+komJPBYpHccuY1PF0HCA=; b=WRaJYMBrzi6xkR913zgnHSKuUi+yCwbr+fRz0RoevbRt2IuYe5oCx/WlrulRTTIN8w 4nNwXOiYyMVKQso0OQNfaxpQabE8MUx1Z1Mz1ybwLzHk8UyI7CcYGIz0skp02bhbH60b i74IcMtANYv68ppDuAbBmqJVdnOZb+w1iTbSMBOHQ1FinP+uS9+DBE/J47qEfmYGEXQm rDH/E1vhv4A4C5LilTzc0EBQ/qt3IS3qpCRpKHFSMTHgaDIGsjVDLPCC+eWV+hMftXJR eMPaU/qjhr4eb62LQDa9rQC47ijzW8PpqR/lx104Tzye1ZsAnt6NbnVvr4v0bOc6ZRZ7 lXIQ== Received: by 10.43.48.8 with SMTP id uu8mr6364858icb.31.1342458569659; Mon, 16 Jul 2012 10:09:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.43.48.8 with SMTP id uu8mr6364853icb.31.1342458569573; Mon, 16 Jul 2012 10:09:29 -0700 (PDT) Received: by 10.231.8.28 with HTTP; Mon, 16 Jul 2012 10:09:29 -0700 (PDT) In-Reply-To: <50043BFF.6000205@redhat.com> References: <50043BFF.6000205@redhat.com> Date: Mon, 16 Jul 2012 17:09:00 -0000 Message-ID: Subject: Re: Initialize status in gdbserver/linux-low.c From: Sterling Augustine To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQkZfaK9aESTFO7dPV8Fn8iv6jC3/3cmENlfhsQTE3bwDK13vN/TqJylLmYcVPZNSB45DMPFxS5P+OoUg4OkXs+Q9GtmRUuUiNbNp5wxsuO5xr3iZWDdYfr7jstfxNcXAh/Nd4A8c9XLNtM9nv2+ODjFA0rkALbTaV3Sp3ZCqRXUjX4rOvX3bDoQZhWmttB8O0gcUd8X Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00215.txt.bz2 On Mon, Jul 16, 2012 at 9:06 AM, Pedro Alves wrote: > On 07/16/2012 04:54 PM, Sterling Augustine wrote: >> Hi, >> >> As the code for handle_extended_wait exists today, status can be used >> uninitialized on line 486 if pull_pid_from_list on line 451 returns >> true. > > If pull_pid_from_list returns true, then it has written to status. > Sounds like you're getting a false positive warning? > >> >> This near-trivial patch initializes it to zero at the declaration. >> >> OK for mainline? > > If this is indeed a false warning, then this is okay with > a "Avoid GCC false warning" comment or some such. My mistake. I was compiling an older version of gdb where pull_pid_from_list didn't include the third parameter. Then forward ported the fix. Sterling