From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10333 invoked by alias); 11 Nov 2011 20:54:15 -0000 Received: (qmail 10323 invoked by uid 22791); 11 Nov 2011 20:54:14 -0000 X-SWARE-Spam-Status: No, hits=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-gx0-f169.google.com (HELO mail-gx0-f169.google.com) (209.85.161.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Nov 2011 20:54:01 +0000 Received: by ggnq1 with SMTP id q1so1096088ggn.0 for ; Fri, 11 Nov 2011 12:54:00 -0800 (PST) Received: by 10.101.152.29 with SMTP id e29mr6470455ano.46.1321044839280; Fri, 11 Nov 2011 12:53:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.101.152.29 with SMTP id e29mr6470448ano.46.1321044839161; Fri, 11 Nov 2011 12:53:59 -0800 (PST) Received: by 10.100.151.14 with HTTP; Fri, 11 Nov 2011 12:53:59 -0800 (PST) Date: Fri, 11 Nov 2011 20:54:00 -0000 Message-ID: Subject: [PATCH - TUI and Insight Related] Fix for PR13378 From: Sterling Augustine To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=001636c5c0d35ede8304b17bb824 X-System-Of-Record: true Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00330.txt.bz2 --001636c5c0d35ede8304b17bb824 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1051 Hi, Enclosed is a very simple patch which fixes the annoying TUI-updating issue described in http://sourceware.org/bugzilla/show_bug.cgi?id=13378. It simply eliminates a call to deprecated_selected_frame_level_changed_hook. This hook has been deprecated for many years, so one would think it's clients have had time to remove the dependency. After using it locally for a week now, I see no ill effects in TUI. stopping at breakpoints, up, down, and the other stuff all work fine for me. However, the testsuite is, err, incomplete on this feature. I do wonder if Insight--or some other front end--might have a problem with it though. If you deal with TUI or another front end, can you take it for a spin? If this patch is accepted, then the next logical one would be to eliminate the hook altogether, but that will require changes to Insight. Thanks, Sterling 2011-11-11 Sterling Augustine PR gdb/13378 * frame.c (select_frame): Don't call deprecated_selected_frame_level_changed_hook. Eliminate obsolete FIXME. --001636c5c0d35ede8304b17bb824 Content-Type: text/x-patch; charset=US-ASCII; name="tui-bounce.patch" Content-Disposition: attachment; filename="tui-bounce.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_guvny9mp0 Content-length: 1607 SW5kZXg6IGZyYW1lLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL2N2cy9zcmMvc3JjL2dkYi9mcmFtZS5jLHYKcmV0cmlldmluZyByZXZp c2lvbiAxLjMwMwpkaWZmIC11IC1yMS4zMDMgZnJhbWUuYwotLS0gZnJhbWUu YwkyNyBPY3QgMjAxMSAxMTowNDoyNSAtMDAwMAkxLjMwMworKysgZnJhbWUu YwkxMSBOb3YgMjAxMSAyMDo1MDo1NiAtMDAwMApAQCAtMTM5NiwxNyArMTM5 Niw2IEBACiAgIHNlbGVjdGVkX2ZyYW1lID0gZmk7CiAgIC8qIE5PVEU6IGNh Z25leS8yMDAyLTA1LTA0OiBGSSBjYW4gYmUgTlVMTC4gIFRoaXMgb2NjdXJz IHdoZW4gdGhlCiAgICAgIGZyYW1lIGlzIGJlaW5nIGludmFsaWRhdGVkLiAg Ki8KLSAgaWYgKGRlcHJlY2F0ZWRfc2VsZWN0ZWRfZnJhbWVfbGV2ZWxfY2hh bmdlZF9ob29rKQotICAgIGRlcHJlY2F0ZWRfc2VsZWN0ZWRfZnJhbWVfbGV2 ZWxfY2hhbmdlZF9ob29rIChmcmFtZV9yZWxhdGl2ZV9sZXZlbCAoZmkpKTsK LQotICAvKiBGSVhNRToga3NlaXR6LzIwMDItMDgtMjg6IEl0IHdvdWxkIGJl IG5pY2UgdG8gY2FsbAotICAgICBzZWxlY3RlZF9mcmFtZV9sZXZlbF9jaGFu Z2VkX2V2ZW50KCkgcmlnaHQgaGVyZSwgYnV0IGR1ZSB0byBsaW1pdGF0aW9u cwotICAgICBpbiB0aGUgY3VycmVudCBpbnRlcmZhY2VzLCB3ZSB3b3VsZCBl bmQgdXAgZmxvb2RpbmcgVUlzIHdpdGggZXZlbnRzCi0gICAgIGJlY2F1c2Ug c2VsZWN0X2ZyYW1lKCkgaXMgdXNlZCBleHRlbnNpdmVseSBpbnRlcm5hbGx5 LgotCi0gICAgIE9uY2Ugd2UgaGF2ZSBmcmFtZS1wYXJhbWV0ZXJpemVkIGZy YW1lIChhbmQgZnJhbWUtcmVsYXRlZCkgY29tbWFuZHMsCi0gICAgIHRoZSBl dmVudCBub3RpZmljYXRpb24gY2FuIGJlIG1vdmVkIGhlcmUsIHNpbmNlIHRo aXMgZnVuY3Rpb24gd2lsbCBvbmx5Ci0gICAgIGJlIGNhbGxlZCB3aGVuIHRo ZSB1c2VyJ3Mgc2VsZWN0ZWQgZnJhbWUgaXMgYmVpbmcgY2hhbmdlZC4gICov CiAKICAgLyogRW5zdXJlIHRoYXQgc3ltYm9scyBmb3IgdGhpcyBmcmFtZSBh cmUgcmVhZCBpbi4gIEFsc28sIGRldGVybWluZSB0aGUKICAgICAgc291cmNl IGxhbmd1YWdlIG9mIHRoaXMgZnJhbWUsIGFuZCBzd2l0Y2ggdG8gaXQgaWYg ZGVzaXJlZC4gICovCg== --001636c5c0d35ede8304b17bb824--