From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34129 invoked by alias); 24 Mar 2017 12:24:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34110 invoked by uid 89); 24 Mar 2017 12:24:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=mac X-HELO: mail-qt0-f194.google.com Received: from mail-qt0-f194.google.com (HELO mail-qt0-f194.google.com) (209.85.216.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Mar 2017 12:24:18 +0000 Received: by mail-qt0-f194.google.com with SMTP id x35so111786qtc.1 for ; Fri, 24 Mar 2017 05:24:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=XRuiy47cb2WAOpQipMFA54Q4CbP5bFBDaF/be8s6sXU=; b=MyVJYoJzpoS6f0+9orTeHUyhWuKTRNeLGjfQHY+mJBqDvWcREQqnPkqRD0tX007VTg SKrmivZjjtRsnLsAXgta8Vtd4bft+5b7CpZAFih1q9pKwvoABSu5W0jI5pNPIqUG3HoT RDe53d1fW4RSwWOZVbbxwKrODfAkwwzuEgrxyusjz96gbL7aa3VSc98W2309fSQVwVOy +OK2e0k9WqJCafnQuGSrEAcGgRm8HGFPgNr4chPaU1c0PptdwM1Ahdqu0nuF1OYqCHSx +CITbeiF6fQeC3kVx37nKbfKgs8srRiAj5AQZ+MZO6Ep3yIvpywqUDwIoXEeZ5BEy+vy CBXw== X-Gm-Message-State: AFeK/H32N/Ym2pEdA/1kpqfA+21VlcUqFXJ9oUEtt+vRdf4HBR04hXIUGB+aGifd1raX5PoAKWKiDBrQV/eMMw== X-Received: by 10.200.46.91 with SMTP id s27mr8104021qta.278.1490358257866; Fri, 24 Mar 2017 05:24:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.39.162 with HTTP; Fri, 24 Mar 2017 05:23:57 -0700 (PDT) In-Reply-To: <2b0bab84-e36e-e109-5444-dc84369dddce@redhat.com> References: <1490324519-11228-1-git-send-email-yszhou4tech@gmail.com> <2b0bab84-e36e-e109-5444-dc84369dddce@redhat.com> From: Yousong Zhou Date: Fri, 24 Mar 2017 12:24:00 -0000 Message-ID: Subject: Re: [PATCH] Fix invalid sigprocmask call To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2017-03/txt/msg00434.txt.bz2 On 24 March 2017 at 18:47, Pedro Alves wrote: > On 03/24/2017 03:01 AM, Yousong Zhou wrote: >> The POSIX document says >> >> The pthread_sigmask() and sigprocmask() functions shall fail if: >> >> [EINVAL] >> The value of the how argument is not equal to one of the defined values. >> >> and this is how musl-libc is currently doing. Fix the call to be safe >> and correct >> >> [1] http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_sigmask.html >> > > I don't agree. It's a musl bug. Please fix it / file a musl bug. I already did that before sending to gdb-patches http://www.openwall.com/lists/musl/2017/03/24/1 I am aware of the fact that the current code works with glibc and mac osx 10.11.6. The Linux kernel code at the moment also accepts the call with how==0 But this is more about interpretation of POSIX document itself. And it says, clearly without pre-condition words or ambiguity in the ERRORS section of that page, to return EINVAL if how is not equal to one of the defined values. I also tried to find some posix-compliant testsuite and to search the github code for samples of pthread_sigmask call. The first I came across was the following code snippet at link https://github.com/juj/posixtestsuite/blob/master/conformance/interfaces/pthread_sigmask/8-1.c#L57 pthread_sigmask(SIG_BLOCK, NULL, &oactl); Regards, yousong