From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IA5FGT/x+mFxYgAAWB0awg (envelope-from ) for ; Wed, 02 Feb 2022 16:01:51 -0500 Received: by simark.ca (Postfix, from userid 112) id 646DE1F3BA; Wed, 2 Feb 2022 16:01:51 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B2F571ECEB for ; Wed, 2 Feb 2022 16:01:50 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 50938385BF86 for ; Wed, 2 Feb 2022 21:01:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 50938385BF86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1643835710; bh=okaX1ph5fYOX7OhGyUTR366O4bkfCy4TCWmm0AQzXbE=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=IK/nAmNqZXK8q+CgtnGKLa3TsE4jUXPVtuakJQvLD8kpuUTgyEMRzxAMNlt58Insm qiKG6vhDH/Bp1R/Zy3ghZMZbv28mZugeEgEam0MIdOtJtT3PMvNQwyijJsMFsyY2pu x/iMpL+yqOLAaXwcwrLp0SC4gwm+jd1uhEHAh3TU= Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id E0D52385C408 for ; Wed, 2 Feb 2022 21:01:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E0D52385C408 Received: by mail-ej1-x62d.google.com with SMTP id o12so1098753eju.13 for ; Wed, 02 Feb 2022 13:01:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F6q5pJS7FJ0NnR1g3aLig699NCfFFzrvRUQZzyghlm4=; b=Woacy+N4Pq3zkzd9y1ygZmCuxLV7HOxT2huVJH4FmqHRmmMpl5Zw4VMjskXiMAbHtW KjWmUiTgTDgZc072kMG1eFnGZFQ03dHFc2qKPCEXn39TaN0L6ajYBdYe0galP4YMzoP+ 9hBFfAGiPUp+0BPFLW2Ni5lKdl9RduzNxJlt68cggjZxDEgKiAsvUBlkls9cIDiXDsFI wdJewTc2TWOlWiy0v16AqJelVi+7KhwNz3BL2pgV5Sp1AIkCpeDSTTaeDhEoK4WZKZgI zifIOVj01duKF8rhGG9R+dXDzXioIaWOCl2DocDH1Mu59Qnjdn9J+wb2k41MSIrfQTmD DeyA== X-Gm-Message-State: AOAM531bvvH20L9+c+oLoKcmgkkf2QGy6MaboAuf2jdCa2grhkwQExEg AteazU290zSJcoS467Foa2WHV6YgPcFpLz9rJQB2dtAYrA7sUviU X-Google-Smtp-Source: ABdhPJywHqlBFNLcwPnHqjN+RGhtJL0rHL+c6Sk8KKDGJ8fmRcG7rKXPAK+HXDxRmAvYCLEFVQAoydYgDam/0BGJRzo= X-Received: by 2002:a17:907:9816:: with SMTP id ji22mr18196804ejc.749.1643835690662; Wed, 02 Feb 2022 13:01:30 -0800 (PST) MIME-Version: 1.0 References: <20220202193116.79655-1-siweihe.eng@gmail.com> In-Reply-To: Date: Wed, 2 Feb 2022 16:01:19 -0500 Message-ID: Subject: Re: [PATCH] gdb: A potential fix for PR-24069 To: Simon Marchi Content-Type: multipart/mixed; boundary="0000000000006963cd05d70f5298" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Siwei He via Gdb-patches Reply-To: Siwei He Cc: Louis-He <1726110778@qq.com>, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" --0000000000006963cd05d70f5298 Content-Type: text/plain; charset="UTF-8" Hi Simon, You are absolutely right. I am new to the community and I noticed that I didn't merge two of my commits together in the patch file. I have already merged them and included in the attachment in this email. I also uploaded it to the bug report: https://sourceware.org/bugzilla/attachment.cgi?id=13953 Best, Louis On Wed, 2 Feb 2022 at 15:57, Simon Marchi wrote: > On 2022-02-02 2:31 p.m., siweihe.eng--- via Gdb-patches wrote: > > From: Louis-He <1726110778@qq.com> > > > > After this fix, the possibility of successful run on mac os increases. > However, it is still possible that the gdb hangs. A workaround is issue > "control+c" and the gdb will continue running as expected. The root cause > of the bug hasn't been identified, and this fix is a temporary patch to > PR-24069. > > --- > > gdb/darwin-nat.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c > > index bba6acc7ea1..844dbf499fe 100644 > > --- a/gdb/darwin-nat.c > > +++ b/gdb/darwin-nat.c > > @@ -1104,16 +1104,16 @@ darwin_nat_target::decode_message > (mach_msg_header_t *hdr, > > } > > > > if (WIFEXITED (wstatus)) > > - { > > - status->set_exited (WEXITSTATUS (wstatus)); > > - } > > + { > > + status->set_exited (WEXITSTATUS (wstatus)); > > + } > > else if (WIFSTOPPED (wstatus)) > > { > > - status->set_ignore (); > > + status->set_ignore (); > > inferior_debug (4, _("darwin_wait: pid %d received > WIFSTOPPED\n"), res_pid); > > return minus_one_ptid; > > } > > - else > > + else > > { > > status->set_signalled > > (gdb_signal_from_host (WTERMSIG (wstatus))); > > -- > > 2.32.0 (Apple Git-132) > > > > > Hi, > > You patch doesn't seem to change anything, except whitespaces, I guess > that's not > what you meant to send. > > Simon > --0000000000006963cd05d70f5298 Content-Type: application/octet-stream; name="0001-gdb-A-potential-fix-for-PR-24069.patch" Content-Disposition: attachment; filename="0001-gdb-A-potential-fix-for-PR-24069.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kz61arke0 RnJvbSA5NTExMzY1NDAwNDI3ODhiNzhlZjRhZWM4ODk1YTg4OWEzYjA4M2YxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMb3Vpcy1IZSA8MTcyNjExMDc3OEBxcS5jb20+CkRhdGU6IFdl ZCwgMiBGZWIgMjAyMiAxNDo1MTo0MyAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIGdkYjogQSBwb3Rl bnRpYWwgZml4IGZvciBQUi0yNDA2OQoKQWZ0ZXIgdGhpcyBmaXgsIHRoZSBwb3NzaWJpbGl0eSBv ZiBzdWNjZXNzZnVsIHJ1biBvbiBtYWMgb3MgaW5jcmVhc2VzLiBIb3dldmVyLCBpdCBpcyBzdGls bCBwb3NzaWJsZSB0aGF0IHRoZSBnZGIgaGFuZ3MuIEEgd29ya2Fyb3VuZCBpcyBpc3N1ZSAiY29u dHJvbCtjIiBhbmQgdGhlIGdkYiB3aWxsIGNvbnRpbnVlIHJ1bm5pbmcgYXMgZXhwZWN0ZWQuIFRo ZSByb290IGNhdXNlIG9mIHRoZSBidWcgaGFzbid0IGJlZW4gaWRlbnRpZmllZCwgYW5kIHRoaXMg Zml4IGlzIGEgdGVtcG9yYXJ5IHBhdGNoIHRvIFBSLTI0MDY5LgotLS0KIGdkYi9kYXJ3aW4tbmF0 LmMgfCAxMSArKysrKysrKysrLQogMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDEg ZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9nZGIvZGFyd2luLW5hdC5jIGIvZ2RiL2Rhcndpbi1u YXQuYwppbmRleCBkOTZjZTFhNmM2NS4uODQ0ZGJmNDk5ZmUgMTAwNjQ0Ci0tLSBhL2dkYi9kYXJ3 aW4tbmF0LmMKKysrIGIvZ2RiL2Rhcndpbi1uYXQuYwpAQCAtMTEwMiw4ICsxMTAyLDE3IEBAIGRh cndpbl9uYXRfdGFyZ2V0OjpkZWNvZGVfbWVzc2FnZSAobWFjaF9tc2dfaGVhZGVyX3QgKmhkciwK IAkJICBzdGF0dXMtPnNldF9pZ25vcmUgKCk7CiAJCSAgcmV0dXJuIG1pbnVzX29uZV9wdGlkOwog CQl9CisKIAkgICAgICBpZiAoV0lGRVhJVEVEICh3c3RhdHVzKSkKLQkJc3RhdHVzLT5zZXRfZXhp dGVkIChXRVhJVFNUQVRVUyAod3N0YXR1cykpOworCQl7CisJCSAgc3RhdHVzLT5zZXRfZXhpdGVk IChXRVhJVFNUQVRVUyAod3N0YXR1cykpOworCQl9CisJICAgICAgZWxzZSBpZiAoV0lGU1RPUFBF RCAod3N0YXR1cykpCisJCXsKKwkJICBzdGF0dXMtPnNldF9pZ25vcmUgKCk7CisJCSAgaW5mZXJp b3JfZGVidWcgKDQsIF8oImRhcndpbl93YWl0OiBwaWQgJWQgcmVjZWl2ZWQgV0lGU1RPUFBFRFxu IiksIHJlc19waWQpOworCQkgIHJldHVybiBtaW51c19vbmVfcHRpZDsKKwkJfQogCSAgICAgIGVs c2UKIAkJewogCQkgIHN0YXR1cy0+c2V0X3NpZ25hbGxlZAotLSAKMi4zMi4wIChBcHBsZSBHaXQt MTMyKQoK --0000000000006963cd05d70f5298--