From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25970 invoked by alias); 2 Jul 2017 16:23:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25947 invoked by uid 89); 2 Jul 2017 16:23:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.2 spammy=UD:php X-HELO: mail-io0-f169.google.com Received: from mail-io0-f169.google.com (HELO mail-io0-f169.google.com) (209.85.223.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 02 Jul 2017 16:23:07 +0000 Received: by mail-io0-f169.google.com with SMTP id z62so44378350ioi.3 for ; Sun, 02 Jul 2017 09:23:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uXw+EeUzdxs3h9EXkGomarTVsoknCZkUJhnjVxXvgKM=; b=WLdVPZIPXBiL9gdkdlOfjG1Rtos51cdI4gMY0dDBQpK9npDhNkyFLjQclc8e8FVMKA N5Yx8hBfmWjcV5Qw6ASMimsAqEA3LgWArWBrSviiACk7tH+0LYNX9ZdMo/nxcvwSj9oN HX2xzbYPiu7Sav5MhbOpKLdlMojsxpd8oDLO24oAuYf5o1Bw7V8pKepSjQKlvC3Fg+Ts 39zo5t925Z86Fn2AAL3qPRnWGj6BMBw+FXtZggUxJgTvOzz0EcBpirrZwnc2zun54ByS RFXdi9GpS6zuFufZBbnP5kNnNHsL37Ss29uacCtvG2lQekk/nbzjoJ1NAmxw0+G7KN1Z ZV2g== X-Gm-Message-State: AKS2vOw2jykB1CNuhPBvFnDWFW+GP5HIKFSqblHFIxTRK5i5I7uoyBVU QYVbh+qvLq4W1FEqbVmyZ2mRIZ0qXzml X-Received: by 10.107.195.15 with SMTP id t15mr29907955iof.182.1499012586068; Sun, 02 Jul 2017 09:23:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.11.105 with HTTP; Sun, 2 Jul 2017 09:22:45 -0700 (PDT) In-Reply-To: <20170702072543.GA5822@host1.jankratochvil.net> References: <20170526181408.GA15337@host1.jankratochvil.net> <20170623085813.GA19725@host1.jankratochvil.net> <20170702072543.GA5822@host1.jankratochvil.net> From: Jason Merrill Date: Sun, 02 Jul 2017 16:23:00 -0000 Message-ID: Subject: Re: ping^2: [gcc patch] DWARF-5: Define DW_IDX_GNU_static and DW_IDX_GNU_external To: Jan Kratochvil Cc: gcc-patches List , gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-07/txt/msg00005.txt.bz2 On Sun, Jul 2, 2017 at 3:25 AM, Jan Kratochvil wrote: > http://dwarfstd.org/ShowIssue.php?issue=170527.1 > > 170527.1 Jan Kratochvil DW_IDX_* for static/extern symbols Enhancement Open > > Section 6.1.1.4.7, pg 147 > When a debugger wants to print 'somename' it logically tries to find first 'somename' as an > external symbol in all available libraries. Only if none such external symbol is found the > debugger starts searching for a static 'somename' symbol in those libraries. > > This requires to know whether a symbol in .debug_names index has DW_AT_external or not. > Otherwise a lot of needless CU expansions happen. This extension improves performance > gain of the .debug_names index. > > (Discovered in an original fix by Doug Evans - GDB Bug 14125.) > > Proposing and asking for pre-allocation: > DW_IDX_static = 6 = DW_FORM_flag_present = DIE's DW_AT_external is not present > DW_IDX_external = 7 = DW_FORM_flag_present = DIE's DW_AT_external is present I'd suggest "internal" rather than "static". Otherwise the patch looks good. Jason