Re: [PATCH v2] Make source.c:search_command_helper use source cache

[Will Hawkins <hawkinsw@obs.cr>]

On Fri, Apr 19, 2024 at 3:40 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Will" == Will Hawkins <hawkinsw@obs.cr> writes:
>
> Will> The current implementation of search_command_helper accesses the line
> Will> offsets of the current program spaces's source code through
> Will> the source cache but then accesses its contents through the disk. This
> Will> PR updates the implementation so that the access of the contents is also
> Will> through the source cache.
>
> It seems to me that this will result in some changes, because the source
> cache may hold text that has had styling applied, and so may have
> embedded ANSI escape sequences -- which the search command isn't
> expecting.

Interesting, I didn't notice that.

>
> If this is needed for your source-embedding work then perhaps the source
> cache should store an unmodified copy of the source as well, at least in
> the case that styles have been applied.

It is part of that work, yes. I hoped that by consolidating access to
the source code through the cache it would also streamline other parts
of the code. I will take your advise on storing a second copy and spin
another revision of the code.

Thank you for the feedback!
Will



>
> Tom