From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qCN/MoRmwV9kVAAAWB0awg (envelope-from ) for ; Fri, 27 Nov 2020 15:50:12 -0500 Received: by simark.ca (Postfix, from userid 112) id CC9461F0AB; Fri, 27 Nov 2020 15:50:12 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4D12B1E58D for ; Fri, 27 Nov 2020 15:50:12 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C5252385802B; Fri, 27 Nov 2020 20:50:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C5252385802B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1606510211; bh=O7WOSH1+7WJXV/ad+07MtdD8qbk/vSBDKRtzVzSDkbY=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=GrmA9vr5fLc2tXSLGXUwJOl1YMX4+pXUnPFYdO/ZR15FD1s0vfzYft78Hwb2sIMCG hxhZwzHWTbqYFKdcn9Aq1RwQtmck/tWm1vn7CQDtPW54zsyA+WsbZwEpgDz/tVdYXK YkR2nxFsP9qaDEAUnEqZR+NCj2bsR3JJdjTAZxWs= Received: from mail-ua1-x941.google.com (mail-ua1-x941.google.com [IPv6:2607:f8b0:4864:20::941]) by sourceware.org (Postfix) with ESMTPS id 62E103858010 for ; Fri, 27 Nov 2020 20:50:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 62E103858010 Received: by mail-ua1-x941.google.com with SMTP id g3so1860425uae.7 for ; Fri, 27 Nov 2020 12:50:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m7S3L+TP/VXqZtmHkAPievlz9KJaZ/pzwPWLDaWP3U0=; b=ZZBSs7zNsoBNtHPwWPKY8BUHdWD806jHwJIECzQ9l0eDAt12dkEtbFeI2KHgfcsQjq 06Q5t5uL4atyG2dQbh2G26+K6bCSOy3VNNVZby38Lp6gBTged5mXKsFanWdE73orkJx5 qquR5BLAU+I+CWNbH8d0pHllbqtSpsvioMduKLB0erqONmD/Xke1g+HP5U+REE6mHjmp k4ZWkVqOBMUqAAM4vLA21jMMkFA/Yrm0WR85u52kBdJWUV5cMLJDdbTukAdZBd3b7gvb 4uIJ2XjROnxdgTuP/ykoXO3JRsN7Dj3+RZT1edjbcgPvMWW1/aq52doSdJfGCVNFdddr G7OQ== X-Gm-Message-State: AOAM532HDelULLHHLeLXdI7oYlGODrxbV4Ps+t8h7gza+2xvZ0I1wWl0 bfwzkgLkvj1C/evRAJ+eNkzFe9x1ooUz060EVxUdRQ4nGfE= X-Google-Smtp-Source: ABdhPJwIbSJFJ4a5m/t2yDfvLckbC6srF4DoLqGgioYCv7cb2trWHddzss85ddZkU2nzsei3AMw4n2D0MUFdfH8nRDA= X-Received: by 2002:ab0:60d3:: with SMTP id g19mr6588985uam.133.1606510209935; Fri, 27 Nov 2020 12:50:09 -0800 (PST) MIME-Version: 1.0 References: <20201126181121.31219-1-vtjnash@gmail.com> <2bb948a7-e909-8949-7486-2aec0c4a9ecf@simark.ca> In-Reply-To: <2bb948a7-e909-8949-7486-2aec0c4a9ecf@simark.ca> Date: Fri, 27 Nov 2020 15:49:54 -0500 Message-ID: Subject: Re: [PATCH] gdb: define COFF file offsets with file_ptr To: Simon Marchi Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jameson Nash via Gdb-patches Reply-To: Jameson Nash Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > linetab_size was unsigned, so maybe use ufile_ptr to keep it that way? It's (currently) computed as the difference of two file_ptr values. The result should be positive, certainly, as it's later used as either a file offset (with a printed warning) and as a size_t. But I'm more inclined to keep it common with the other values here, and use `file_ptr`, which is a signed integer type like `off_t` and `ssize_t`.