Re: [PATCH, nds32] Exclude building gdb for nds32*-*-* target.

[Chung-Ju Wu <jasonwucj@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1512 bytes --]

2014-09-06 3:10 GMT+08:00 Joel Sherrill <joel.sherrill@oarcorp.com>:
>
> On 9/5/2014 12:00 PM, Joel Brobecker wrote:
>>>> 2014-09-05  Chung-Ju Wu  <jasonwucj@gmail.com>
>>>>
>>>>     * configure.ac (nds32*-*-*): Disable gdb.
>>>>     * configure: Regenerated.
>>> It looks like the part for not building gdb for or1k*-*-rtems* gets moved
>>> by this patch.  I know there was an issue with the initial submission of
>>> that change.
>>>
>>> Your patch appears to correct that also. I thought the properly regenerated
>>> configure had been committed. But I guess not.
>>>
>>> I am OK with the patch since or1k-rtems is in the same place but wanted
>>> to note that the generated file had extra stuff in it for a good reason.
>> We really should regenerate configure first, and then apply Chung-Ju's
>> patch next. There will come a day when we will be reverting that
>> patch, since hopefully GDB will be building for that target, one day.
>> We don't want the revert to accidently also revert the bits that
>> that resync configure with present-day configure.ac.
>>

Thank you for clarifying it.  That also makes sense to me. :)

Since you have done the configure regeneration in
https://sourceware.org/ml/gdb-patches/2014-09/msg00155.html ,
I have my patch updated as attached and ChangeLog is the same as follow:


2014-09-05  Chung-Ju Wu  <jasonwucj@gmail.com>

        * configure.ac (nds32*-*-*): Disable gdb.
        * configure: Regenerated.


Is the updated patch OK to commit?


Best regards,
jasonwucj

[-- Attachment #2: 0001-Disable-gdb-for-nds32-until-it-is-supported_v2.patch --]
[-- Type: application/octet-stream, Size: 968 bytes --]

From f42298a43b671f27b1c2f8891bb458b03fb5bc37 Mon Sep 17 00:00:00 2001
From: Chung-Ju Wu <jasonwucj@gmail.com>
Date: Sat, 6 Sep 2014 03:54:47 +0800
Subject: [PATCH] Disable gdb for nds32*-*-* until it is supported.

---
 configure    | 3 +++
 configure.ac | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/configure b/configure
index 9fc1c88..dfea3bd 100755
--- a/configure
+++ b/configure
@@ -3805,6 +3805,9 @@ case "${target}" in
   mips*-*-*)
     noconfigdirs="$noconfigdirs gprof"
     ;;
+  nds32*-*-*)
+    noconfigdirs="$noconfigdirs gdb"
+    ;;
   or1k*-*-*)
     noconfigdirs="$noconfigdirs gdb"
     ;;
diff --git a/configure.ac b/configure.ac
index 028cbda..dada090 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1133,6 +1133,9 @@ case "${target}" in
   mips*-*-*)
     noconfigdirs="$noconfigdirs gprof"
     ;;
+  nds32*-*-*)
+    noconfigdirs="$noconfigdirs gdb"
+    ;;
   or1k*-*-*)
     noconfigdirs="$noconfigdirs gdb"
     ;;
-- 
1.8.1.1