From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127677 invoked by alias); 2 Dec 2019 12:00:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127573 invoked by uid 89); 2 Dec 2019 12:00:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-HELO:sk:mail-vk, H*RU:sk:mail-vk, HX-Spam-Relays-External:sk:mail-vk, H*r:sk:mail-vk X-HELO: mail-vk1-f193.google.com Received: from mail-vk1-f193.google.com (HELO mail-vk1-f193.google.com) (209.85.221.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Dec 2019 12:00:24 +0000 Received: by mail-vk1-f193.google.com with SMTP id u189so7813625vkf.11 for ; Mon, 02 Dec 2019 04:00:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=frtk-ru.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hQ+VdygRyHrOVyOKH+b3iEmawukthY6uUxWo/R6lWwA=; b=xzbaa4SumFJ1u1XtHI8FP0I1+UjHVOeL7jrhWxzWTQkBvpc5GKK6RB2rFRloN8UltO OAnw935j+ao63w9mAOekauekF3fXPaf1r7badVwe7JbASKnJvQ7Hp/vJUaFUUzpI1A6s TcWwX1x90Z3qXE9H/64VXYqCdOhsru7n5RejGahjUBG2puuFtX6MqoTUaKp/PqmBh0Mg 6RjuYuIkgTnJhnowEGv/13CqXoEDf6b7lYDz+jM+JejPD+P355RA99W5YfB/UVxRsd0A DEg7s8FhAzJ2c/6CYxc9nuBu3pVBogFmrVtkpgPDt5/mbNEGUGEnAMWaXXw2MqT1c3Ip oWcA== MIME-Version: 1.0 References: <20191202100948.GJ3410@embecosm.com> In-Reply-To: <20191202100948.GJ3410@embecosm.com> From: "Pavel I. Kryukov" Date: Mon, 02 Dec 2019 12:00:00 -0000 Message-ID: Subject: Re: [PATCH] sim-utils.c: prevent buffer overflow. To: Andrew Burgess Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2019-12/txt/msg00043.txt.bz2 > > diff --git a/sim/common/sim-utils.c b/sim/common/sim-utils.c > > index e83a2e4..a60dd92 100644 > > --- a/sim/common/sim-utils.c > > +++ b/sim/common/sim-utils.c > > @@ -355,7 +355,7 @@ map_to_str (unsigned map) > > case io_map: return "io"; > > default: > > { > > - static char str[10]; > > + static char str[16]; > > sprintf (str, "(%ld)", (long) map); > > I think you could/should change this call to sprintf to use > xsnprintf instead. If I understand correctly, xsnprintf is defined in GDB header (gdb/gdbsupport/common-utils.h) which is C++. Can we use "pure" snprintf instead? Thanks, -- Pavel