From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id A2T8DvRA1l/ONAAAWB0awg (envelope-from ) for ; Sun, 13 Dec 2020 11:27:32 -0500 Received: by simark.ca (Postfix, from userid 112) id 30CE61F0AA; Sun, 13 Dec 2020 11:27:32 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 318C01E965 for ; Sun, 13 Dec 2020 11:27:30 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E7A8F3857004; Sun, 13 Dec 2020 16:27:29 +0000 (GMT) Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by sourceware.org (Postfix) with ESMTPS id 7E62A3857004 for ; Sun, 13 Dec 2020 16:27:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7E62A3857004 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=frtk.ru Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kryukov@frtk.ru Received: by mail-pg1-x541.google.com with SMTP id w5so10040584pgj.3 for ; Sun, 13 Dec 2020 08:27:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=frtk-ru.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xieQ9hnb3hgmLpXGCWT+YDYGpFy+ENjqw2y57DcJ2Zc=; b=w7vVy5vpu2etPPaYZPGxbvW8aezzIKQcd7IpdcPVVmxK+4OFJdZrl5NvIObAlyiLLH 1ryTX81RdsucoOuwiDAly00oDA6lgutrRAnI3H1oTKKd64LqaF1HZPHdhbiMLoPBQWHm /QVu/F6jvYUKbVCAhmObsdHOdnMiqbZ1QpAwzHZFG7Z9sU2C7QtmoyaTWohS6TqTy7zf 2fgDdrsXGrm7Xmgn0gANJnODCJkQ/R1/IG/6D2keAdZXOwJvCeoq711LsXWf6qQZRw67 3iR1NM4041spJGHdzHWrQBIuTSVNSbEgCSXSrd7rF21HVsW8pKwbIFHapxbmAt6hKaVa yylA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xieQ9hnb3hgmLpXGCWT+YDYGpFy+ENjqw2y57DcJ2Zc=; b=ugLx5OZaSPAJIcoS/XCJcBl8scIrOoWJ0MZ6B/v0HLuvcJqx/w3C8LpTWeqx0izuLx CjQZ5RRMBJTr+dBTUfUSYLxt5e5DWMn1UhlvMuOBGFFDenKig8ONfblhBrkCyFzr1QJr 8U3hJK5GBfbpqKuhrY8h8pmHx2MwCNbhX3eWpM+hny/FcGEYJ1Cjm9+UEIibCP+wb6L5 czlOSy7BsmSZoYrYmeC1BDdPWP9FJjDjpCj9d41sY5xPdUiLyOpXvHWUE7mkA+fofzst bnRk60SZHjZml69wv42kOAmZ7VMpaB9mG6lIj8frauXUmMdvxh/bziBHrC9Wa0GQVqTw KlKQ== X-Gm-Message-State: AOAM530hbNXd9x/2cs20hzqPMsOk7ID3OsVhX4yGqn7McFNrhQYrKIyO j1vzEB/nLk2LanV5v36RrNoJgWqrFS785ke/+eXAM43+VZuCFw== X-Google-Smtp-Source: ABdhPJw9lUuPnIS9kdqH4hVNoKL1shWs0Eonz8i9br79QFfCyz5aT7OU80nYlcvhJ3dQPKPpv/iG6Mf90Lno/j2RA08= X-Received: by 2002:a05:6a00:16c5:b029:19b:696:28a0 with SMTP id l5-20020a056a0016c5b029019b069628a0mr20610004pfc.9.1607876845619; Sun, 13 Dec 2020 08:27:25 -0800 (PST) MIME-Version: 1.0 References: <20201212124528.1095-1-kryukov@frtk.ru> <20201213141025.GI366101@adacore.com> In-Reply-To: <20201213141025.GI366101@adacore.com> From: "Pavel I. Kryukov" Date: Sun, 13 Dec 2020 19:27:14 +0300 Message-ID: Subject: Re: [PATCH] Include to cp1.c for abort() declaration To: Joel Brobecker Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" I don't have push permissions. Thanks, -- Pavel =D0=B2=D1=81, 13 =D0=B4=D0=B5=D0=BA. 2020 =D0=B3. =D0=B2 17:10, Joel Brobec= ker : > > > sim/mips/ChangeLog: > > > > * cp1.c: Include > > :-/. Using "abort" in the sim is not a good idea, because the sim > can be built into GDB. So imagine the scenario where a user uses > an invalid switch as the sim calls "abort", instead of just reporting > the error to the user and letting him try again, the debugging session > just abort... > > However, in this particular case, the use of aborts is not your fault, > and it's probably not new either, so it makes sense to include > the corresponding system header. > > The patch is OK for me. Please feel free to push (do you have push > permissions?). > > > --- > > sim/mips/ChangeLog | 4 ++++ > > sim/mips/cp1.c | 2 ++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/sim/mips/ChangeLog b/sim/mips/ChangeLog > > index 7ced3edd1b..f9a1eb96c6 100644 > > --- a/sim/mips/ChangeLog > > +++ b/sim/mips/ChangeLog > > @@ -1,3 +1,7 @@ > > +2020-12-12 Pavel I. Kryukov > > + > > + * cp1.c: Include . > > + > > 2020-07-29 Simon Marchi > > > > * configure: Re-generate. > > diff --git a/sim/mips/cp1.c b/sim/mips/cp1.c > > index 82fdea2bcb..d81b07a20c 100644 > > --- a/sim/mips/cp1.c > > +++ b/sim/mips/cp1.c > > @@ -42,6 +42,8 @@ along with this program. If not, see . */ > > > > #include "sim-main.h" > > > > +#include > > + > > /* Within cp1.c we refer to sim_cpu directly. */ > > #define CPU cpu > > #define SD CPU_STATE(cpu) > > -- > > 2.17.1 > > -- > Joel