From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19409 invoked by alias); 28 Sep 2012 11:27:40 -0000 Received: (qmail 19401 invoked by uid 22791); 28 Sep 2012 11:27:39 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_BJ,TW_CX,TW_EG X-Spam-Check-By: sourceware.org Received: from mail-ie0-f169.google.com (HELO mail-ie0-f169.google.com) (209.85.223.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Sep 2012 11:27:35 +0000 Received: by ied10 with SMTP id 10so7852948ied.0 for ; Fri, 28 Sep 2012 04:27:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.50.88.194 with SMTP id bi2mr1272087igb.47.1348831654793; Fri, 28 Sep 2012 04:27:34 -0700 (PDT) Received: by 10.50.85.37 with HTTP; Fri, 28 Sep 2012 04:27:34 -0700 (PDT) Date: Fri, 28 Sep 2012 11:27:00 -0000 Message-ID: Subject: Redeclaration of regcache_register_status differs from previous declaration From: selven To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=e89a8f3ba957a550e204cac157c6 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00680.txt.bz2 --e89a8f3ba957a550e204cac157c6 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 2233 Hi, I've never submitted a patch to gdb before, I don't know how to do this, and I searched the wiki couldn't find more info. I was trying to compile gdb on aix 0|myuser@abox Downloads $ uname -a AIX abox 1 6 00C2EE1A4C00 Was configuring with: ./configure --prefix=/home/myuser/chrooted --disable-option-checking --disable-libada --disable-libssp --disable-build-with-cxx --disable-ppl-version-check --disable-cloog-version-check --disable-objc-gc --enable-serial-configure --disable-maintainer-mode --disable-stage1-checking --disable-werror --disable-sim Which went fine , I did a make, which ended in: "regcache.c", line 229.9: 1506-068 (W) Operation between types "signed char*" and "unsigned char*" is not allowed. "regcache.c", line 236.9: 1506-068 (W) Operation between types "signed char*" and "unsigned char*" is not allowed. "regcache.c", line 415.1: 1506-343 (S) Redeclaration of regcache_register_status differs from previous declaration on line 66 of "regcache.h". "regcache.c", line 415.1: 1506-050 (I) Return type "int" in redeclaration is not compatible with the previous return type "enum register_status". "regcache.c", line 417.3: 1506-045 (S) Undeclared identifier __func__. make: 1254-004 The error code from the last command is 1. Currently: gdb/regcache.c 414 int 415 regcache_register_status (const struct regcache *regcache, int regnum) Definition in regcache.h: gdb/regcache.h 66 enum register_status regcache_register_status (const struct regcache *regcache, 67 int regnum); Should be: 414 enum register_status 415 regcache_register_status (const struct regcache *regcache, int regnum) (So i kinda decided to post a patch, which sounded awesome :p ) Patch: --- regcache.c 2012-09-28 07:12:18.019876000 -0400 +++ regcache_fixed.c 2012-09-28 07:12:19.049855400 -0400 @@ -411,7 +411,7 @@ return newbuf; } -int +enum register_status regcache_register_status (const struct regcache *regcache, int regnum) { gdb_assert (regcache != NULL); My sincere apologies if this shouldn't have been posted here. -- Pirabarlen Cheenaramen | $3|v3n L'escalier /*memory is like prison*/ (user==selven)?free(user):user=malloc(sizeof(brain)); --e89a8f3ba957a550e204cac157c6 Content-Type: application/octet-stream; name="regcache_patch.diff" Content-Disposition: attachment; filename="regcache_patch.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h7n7foie0 Content-length: 391 LS0tIHJlZ2NhY2hlLmMJMjAxMi0wOS0yOCAwNzoxMjoxOC4wMTk4NzYwMDAg LTA0MDAKKysrIHJlZ2NhY2hlX2ZpeGVkLmMJMjAxMi0wOS0yOCAwNzoxMjox OS4wNDk4NTU0MDAgLTA0MDAKQEAgLTQxMSw3ICs0MTEsNyBAQAogICByZXR1 cm4gbmV3YnVmOwogfQogCi1pbnQKK2VudW0gcmVnaXN0ZXJfc3RhdHVzCiBy ZWdjYWNoZV9yZWdpc3Rlcl9zdGF0dXMgKGNvbnN0IHN0cnVjdCByZWdjYWNo ZSAqcmVnY2FjaGUsIGludCByZWdudW0pCiB7CiAgIGdkYl9hc3NlcnQgKHJl Z2NhY2hlICE9IE5VTEwpOwo= --e89a8f3ba957a550e204cac157c6--