From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 75KcHeT7CGgLiwEAWB0awg (envelope-from ) for ; Wed, 23 Apr 2025 10:40:36 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=DamamxZi; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4893E1E0C3; Wed, 23 Apr 2025 10:40:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3B6CE1E0C0 for ; Wed, 23 Apr 2025 10:40:35 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C8515385780D for ; Wed, 23 Apr 2025 14:40:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C8515385780D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=DamamxZi Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id E47B93858D26 for ; Wed, 23 Apr 2025 14:40:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E47B93858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E47B93858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::534 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745419204; cv=none; b=aLz+p/EHIlXzHXdBM0G8E8p2o0dz6cksetIfvQbmmI1WyIt1DLJHAExSnHPMdm5SQSuQ3NB2rIbjvdvdOmhLCrV1R9QlLTi8SXSP3D1LDGmdpj9O86Bc5QK64WAWwRRfNoMZ7PRIITMtj4Dyv8y6BeWmYCg6O2gN0u1DED8oaZs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745419204; c=relaxed/simple; bh=e3Fswn5o4pItQYuM1eh93ZgKzRiOnXSmYTYiWwXg+Zo=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=fmWI8bspu9AaYkraMCxI7clnDQ60oTbBvJuQ/L8R6zUpnNhyeKD+hCRAuP05UJkdvetco+DJOXJiSI2GGW3yYILN6/UuAzF37DHWU2iu/UKjgE2sAie/N9DynmMrXXZKgPTelG+y4Z7/zJKluGg5wZyWK0/VSyfVQJtmD1redqM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E47B93858D26 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5f62d3ed994so8876678a12.2 for ; Wed, 23 Apr 2025 07:40:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745419202; x=1746024002; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=e3Fswn5o4pItQYuM1eh93ZgKzRiOnXSmYTYiWwXg+Zo=; b=DamamxZibdRkCzooKUgHbmegw8hAC16q+pOOMWvlFd1Y5S9QZ5yEU1f6eHhEe8qihe hGCLXPC6CqX6kQFyx6uzn+kLtd9KcwJGApsH1s6RiqAtJCQ1Hhe1z9+lxWv+J+LNAY45 hJlWtqJW/vz0mYePnJSkoTP7tkdR8SXhG6GqGFtHs9a7h+smyKnLFlFbgGu3uFOcv2/H iAO+vmD5CrdyB3dSL0+T9ZULW+AvK5Ho3yehKcn7QgyhF3K3VhvJLniFZR9aJn/xW5Ja uihCUc1k+ynxgE2fnanr7pJUaiM2pdZ9aPfx6pNuoDDb16l/+7I26EmQM+ZaFYsWVIZr 0Uwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745419202; x=1746024002; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e3Fswn5o4pItQYuM1eh93ZgKzRiOnXSmYTYiWwXg+Zo=; b=Esp5cKYJm7BkN8EJrimxtTGnxuVEtJRyszzgWbrBD495bFIFcS7+oP3ft/iX/9LMLA opAGob7Ccj6tZAVZ5r15v5D5NDn1vjY+937KbM0OUsaLq2iFYYxt3YUNDUEaMQ5TZYND dbPkQJjEf9psCjRb9h9ypI4OnwkTzig2dy7NTA3xLCbuAVkAh+V/WD2OVtXoim7a2y7y kANrHbq5cCC1VpD6ncLl77VHHxOHTzagD8FPS3kqp/QFdeWDdl3iRhNI0IrrrJ+j030G ypaS0qwR2t8nTLhptXES8Q2cG87gqIBI2UeWx3zljYkK1PdZi7YsRJNcxvsyO5r8yZLM AVLg== X-Forwarded-Encrypted: i=1; AJvYcCV5/Qu5kWxQrRF3HkXbMe98tIAsZw263OmhN52UPgrzKqYfr6ef9fx4l148W0bvvx6nF/Xf6VacSbUaGA==@sourceware.org X-Gm-Message-State: AOJu0YzRl7Ums1m06jZWMiu/MtteU2yl9i/vfoROpErPebmb5CnEotDF ijX77WZPTE0SHeHb++DzVWb6Bb1q25Jm9tt39dFxAkkg1WjDKiGIp8SmNQQEG+aTioXFKbh1/Qp PFHgZ54ymDQxOOF4J69lJF6MDQU0= X-Gm-Gg: ASbGnctjXOwpzXPDIm45NyAz7HoR650NMAmmMMI/XJjrEmN18qdg/NUxnkqc//HMLbt fWLfbZ1k8feL75wybSwsBwNpK6I1ygdyTgm4bvn8rvYfZG2qdEq/WG5XruA4//zzMseF4prlwyf BwtaGMc2a5tPW2+tpo1b6T6Q== X-Google-Smtp-Source: AGHT+IEUHBNj50uGh7Q1C8rmZIzKuh3dJUvuRvREWt6q2elE34L4IwdaMEXVVzfL+1BEcKUZxrHoObu9kBL3qNCyNZE= X-Received: by 2002:a05:6402:1ed2:b0:5ec:92c3:58c5 with SMTP id 4fb4d7f45d1cf-5f6285d4660mr14084280a12.29.1745419201858; Wed, 23 Apr 2025 07:40:01 -0700 (PDT) MIME-Version: 1.0 References: <875xjce5r8.fsf@redhat.com> <20250410115519.617361-1-timurgol007@gmail.com> <87fribdwc9.fsf@redhat.com> <31eef46b-6e2a-434b-b409-be2e50fa3cee@redhat.com> <27ac9bfa-7738-4601-8cf8-a2d0582db90f@redhat.com> In-Reply-To: <27ac9bfa-7738-4601-8cf8-a2d0582db90f@redhat.com> From: Timur Golubovich Date: Wed, 23 Apr 2025 17:39:50 +0300 X-Gm-Features: ATxdqUEO2oMYVLZVk425KYJetcr7CTwBr4ZriCoW7b_cLnRFsB3Bx5nLn0h81c4 Message-ID: Subject: Re: [PATCH v8] This commit adds record full support for rv64gc instruction set To: Guinevere Larsen Cc: "Aktemur, Tankut Baris" , "gdb-patches@sourceware.org" , Andrew Burgess Content-Type: text/plain; charset="UTF-8" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi! Thanks for the quick fix. That was a great review, good job. I'd be happy to continue working on gdb. > > On 4/23/25 11:01 AM, Aktemur, Tankut Baris wrote: > > On Wednesday, April 23, 2025 2:14 PM, Guinevere Larsen wrote: > >> Hi! Sorry for the delay, I'm applying and fixing merge conflicts, and > >> will be pushing this patch soon! > >> > >> If you plan on continue to develop GDB, you may want to get in contact > >> with Tom Tromey to setup write-after-approval access, so you are able to > >> push your own patches :) > >> > >> -- > >> Cheers, > >> Guinevere Larsen > >> She/Her/Hers > >> > >> On 4/22/25 2:36 PM, Timur Golubovich wrote: > >>> Hi! > >>> Sorry to bother, but It seems like no one else has any questions about > >>> this patch. > >>> Maybe then it's possible to merge it? > > Hello Guinevere, Timur, > > > > With this patch, I started getting > > > > /usr/bin/ld: riscv-linux-tdep.o: in function `riscv_linux_syscall_record(regcache*, unsigned long)': > > /user/taktemur/gdb/gdb/riscv-linux-tdep.c:230: undefined reference to `riscv64_canonicalize_syscall(int)' > > > > I had configured GDB with --enable-targets=all. > Oh, oops. the riscv-canonicalize-syscall.c file hasn't been added to the > makefile, so all targets fails. I'm fixing this and the other build > issue (a commit from Tromey slightly changing one gdb syscall name) and > pushing the fix asap > > -- > Cheers, > Guinevere Larsen > She/Her/Hers >