From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11642 invoked by alias); 10 Jul 2014 18:55:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11564 invoked by uid 89); 10 Jul 2014 18:55:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f174.google.com Received: from mail-vc0-f174.google.com (HELO mail-vc0-f174.google.com) (209.85.220.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 10 Jul 2014 18:55:11 +0000 Received: by mail-vc0-f174.google.com with SMTP id hy4so525vcb.33 for ; Thu, 10 Jul 2014 11:55:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=y9FZSExPzd5fak4rKTHnBKgwpsc9ePAADGLn5j0Em78=; b=CWpZ/a0hE4L8lTvlIECnNzlXqyWyPFntNsbEbrmVxLxHxhqod0IGWtcG8REdGSlpbT jb9wNVE3mXQJd/y50+Ic4QMoGZmAdtYpCTDw/hhIbCkR+1dGmEBOMn2D+9g2e5Y/nPpb RAdMqmiBUPFZfNub2coNbNg7HHfPobvQjSPdps/ZLjcChLfP+xvRYTQlmEF6veI+FWJT 8KGvqids7ByxoALIqYdYsNujgrx0qmDdKEbjN0DHJMfe7zD/RIoVC4/tEg05Hk1IpLLR l3yofxSB5B3uTQ+dtrjv0wC5R9eGLVahYJtNAT91G741ra2vWKFZMp/FRkKjc+P/5XHk b2RQ== X-Gm-Message-State: ALoCoQlIGNB1iAfQjtOLZ9nyNrN5E1IMyISH46NEn68fS/uzeVM2I368PldxaTu78ydCN8dR1ECS MIME-Version: 1.0 X-Received: by 10.52.157.41 with SMTP id wj9mr38767446vdb.1.1405018509428; Thu, 10 Jul 2014 11:55:09 -0700 (PDT) Received: by 10.52.28.233 with HTTP; Thu, 10 Jul 2014 11:55:09 -0700 (PDT) In-Reply-To: <87bnsxdrtj.fsf@fleche.redhat.com> References: <1404902255-11101-1-git-send-email-gbenson@redhat.com> <1404902255-11101-13-git-send-email-gbenson@redhat.com> <87bnsxdrtj.fsf@fleche.redhat.com> Date: Thu, 10 Jul 2014 18:55:00 -0000 Message-ID: Subject: Re: [PATCH 12/15] Add target/symbol.h, update users From: Doug Evans To: Tom Tromey Cc: Gary Benson , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00214.txt.bz2 On Thu, Jul 10, 2014 at 10:52 AM, Tom Tromey wrote: >>>>>> "Gary" == Gary Benson writes: > > Gary> +/* See target/symbol.h. */ > Gary> + > Gary> +int > Gary> +target_look_up_symbol (const char *name, CORE_ADDR *addr, void *data) > > I never wrote these docs either... Nit, Anything with target_ as a prefix I think of as a target.h method. [There are a few exceptions but as long as it's kept to a minimum it's manageable.] IWBN if the different, umm, subsystems of gdb were easily recognizable in the code. As target/* scales up, is there a risk of the code becoming harder to read if target_ is used as a general prefix for things in target/*? Dunno. Just wondering.