From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62246 invoked by alias); 11 Aug 2015 20:43:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62237 invoked by uid 89); 11 Aug 2015 20:43:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ig0-f180.google.com Received: from mail-ig0-f180.google.com (HELO mail-ig0-f180.google.com) (209.85.213.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 11 Aug 2015 20:43:53 +0000 Received: by igbpg9 with SMTP id pg9so99377255igb.0 for ; Tue, 11 Aug 2015 13:43:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=uQ8U1p/tbjkltiHZJThluvITjWsCe1b6KvAZ9HD6i38=; b=S7UumpFbdSZqBRoaYl5pNJwlotdZP5n+E9ngWKwSTTrunVqg+UITcHav6z+XQlLp61 37REgco2w0jtPB/VnLkuRFKhrEyTDhgPeTUhn/mSSmFKtx1cJm8RcAX9iOoREVPTj+Q6 fzyOza9LPv5aMaeNFchDMzFOf+hA1oxCa1PVpSCN8sm1S8tIt+ew7qndmBdNf8kX3UkB oBpr7v/6vBCYFy1Kmk6v2hinJYIPJXvtV3Lzup3ZCDxwUtBOU2VEmSFAmV+mGt8/pN8z Uo/5RP1LoHA4jOR+RfQsFD4vL62d6hR2kdo0JUYlyt0wAmx31xgiu07SUgU6pDB0jqF8 qz9g== X-Gm-Message-State: ALoCoQmq09TXYN51GBuNBdNDDyebGZnK+LGOEUJXAN1D4HF7nliMYWEmC82F+pdZm8jRXD2RtN4F X-Received: by 10.50.33.37 with SMTP id o5mr13456405igi.3.1439325831431; Tue, 11 Aug 2015 13:43:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.93.102 with HTTP; Tue, 11 Aug 2015 13:43:11 -0700 (PDT) In-Reply-To: <20150811195814.GB22245@adacore.com> References: <1438287227-11303-1-git-send-email-simon.marchi@ericsson.com> <55BF7962.3060106@redhat.com> <55BF85BC.8040102@ericsson.com> <55BF9811.50202@redhat.com> <20150804172110.GI4777@adacore.com> <20150811195814.GB22245@adacore.com> From: Doug Evans Date: Tue, 11 Aug 2015 20:43:00 -0000 Message-ID: Subject: Re: [PATCH] Remove symlinks created in argv0-symlink.exp and general cleanup To: Joel Brobecker Cc: Pedro Alves , Simon Marchi , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00252.txt.bz2 On Tue, Aug 11, 2015 at 12:58 PM, Joel Brobecker wrote: >> I don't have a strong opinion on making in-tree testing unsupported, >> but I do have a strong opinion on another thing that can make the >> in-tree testing issue moot. >> >> Let's remove all of testsuite/*/Makefile.in, they're always >> out of date anyway (i.e., no one updates gdb.foo/Makefile.in to >> remove binaries added by new tests), >> and except for "make clean" aren't really used for anything. >> The "make clean" in testsuite/Makefile.in can just "rm -rf foo bar ..." >> [where "foo bar ..." are *not* the gdb.* testsuite dirs, but rather >> the outputs,etc. directories of check-parallel] >> IOW, testing would create the needed directories on the fly, >> even in serial mode, >> and to simplify "make clean" they'd always be put in a fixed >> subdir of testsuite (just like check-parallel does now). > > I think some of these issues are worth improving independently > of whether the build was in-tree or not. > >> As for whether to always have one directory per test >> (in serial and parallel modes), that *could* be treated as a separate >> issue, but if it reduces complexity by doing the same thing >> for serial and parallel then great. >> [And while in-tree testing could still be unsupported, >> I think(!) the current issue with it would be fixed.] > > If in-tree build happens to work without effort from us, then > OK to continue having it. But I don't think treating as bugs > issues that are specific to in-tree building & testing would > be the best investment of our resources. > > I tried to remember why people thought in-tree building is more > convenient for them, and couldn't remember of any reason other > than convenience. But is it really more convenient? Are there > other reasons I forgot about? FAOD, I'm *not* advocating for keeping in-tree builds working. I never do them myself so I really have no direct interest in whether it works or not. But, if something I want to do anyway happens to improve life for someone else, then I'm ok with that.