From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14863 invoked by alias); 6 May 2013 19:40:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14851 invoked by uid 89); 6 May 2013 19:40:05 -0000 X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,SPF_PASS,TW_BJ,TW_YM autolearn=ham version=3.3.1 Received: from mail-ve0-f169.google.com (HELO mail-ve0-f169.google.com) (209.85.128.169) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 06 May 2013 19:40:04 +0000 Received: by mail-ve0-f169.google.com with SMTP id jz10so3671577veb.0 for ; Mon, 06 May 2013 12:40:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=hLQGbu78gf6XmD6TSTzUcClGO4biZyfjqhedRPAO7wM=; b=m7bkEp90qPS7VTk8PXURdeL51ibm27H1DHpbfg9usFaMlKHF8dJC7NJWwcgxx6/0K7 Fe9Q5fIROA0H8yWvxjfLLnB7HhGwAorhntdnZUSSJOdsRh/4CU6XnDhjgFzgHjeFt9tn ahWCLQ5YoS010CElRl5DvWIvjgmrfyl6LpveeGDfRL1lK+eimryP5NLE7J3fGcjxfnIG IXpgp0wX35ENpXs4WlFFquki/Oj0U2jLcYXDknbi/ic60dIHFhIRPbz0Zh/iTRQnUEuk rcrqBvOcDXIwFBq0xznGpT9HH0UDi3DeNgS2FUmzauOf4JDzjqMqVu0GfFANWL9Nd23O rqdw== MIME-Version: 1.0 X-Received: by 10.220.177.8 with SMTP id bg8mr185357vcb.35.1367869202818; Mon, 06 May 2013 12:40:02 -0700 (PDT) Received: by 10.220.173.7 with HTTP; Mon, 6 May 2013 12:40:02 -0700 (PDT) In-Reply-To: <87ehdjyk4x.fsf@fleche.redhat.com> References: <87d2t4ymxl.fsf@fleche.redhat.com> <87ehdjyk4x.fsf@fleche.redhat.com> Date: Mon, 06 May 2013 19:40:00 -0000 Message-ID: Subject: Re: [patch] constify symfile.h section_offsets, section_addr_info From: Doug Evans To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQlm+W2OZWibgAMagj/x2dXHEHGKl0piW2I1LESdMfgUuU8aNvUbWRfbQZyftWatKniVhRZzqbXdi4GHqpb+RgBIizJbesBRBqS8kPVFCwLpHzuSN2rstIpdHEOMLjJ7kH9sw9WnuCTBo6+YExk+7KzrVAtXSVKAodhbb7x3NPoDuFjwDnEEaBsGj6s97iCn3CI9kdbnAHtnKNAlMMqpJteyngbzaQ== X-SW-Source: 2013-05/txt/msg00144.txt.bz2 enable-targets=all to the rescue I actually had that on my todo list. Blech. Thanks. On Mon, May 6, 2013 at 12:37 PM, Tom Tromey wrote: >>>>>> "Doug" == Doug Evans writes: > > Doug> With that, committed. > Doug> Thanks! > > I needed this as well. > I'm checking it in. > > Tom > > 2013-05-06 Tom Tromey > > * somread.c (som_symfile_offsets): Add 'const' to addrs. > * machoread.c (macho_symfile_offsets): Add 'const' to addrs. > * xcoffread.c (xcoff_symfile_offsets): Add 'const' to addrs. > Remove declaration. > > Index: machoread.c > =================================================================== > RCS file: /cvs/src/src/gdb/machoread.c,v > retrieving revision 1.50 > diff -u -r1.50 machoread.c > --- machoread.c 8 Apr 2013 20:13:21 -0000 1.50 > +++ machoread.c 6 May 2013 19:36:41 -0000 > @@ -968,7 +968,7 @@ > > static void > macho_symfile_offsets (struct objfile *objfile, > - struct section_addr_info *addrs) > + const struct section_addr_info *addrs) > { > unsigned int i; > unsigned int num_sections; > Index: somread.c > =================================================================== > RCS file: /cvs/src/src/gdb/somread.c,v > retrieving revision 1.61 > diff -u -r1.61 somread.c > --- somread.c 8 Apr 2013 20:13:22 -0000 1.61 > +++ somread.c 6 May 2013 19:36:41 -0000 > @@ -487,7 +487,8 @@ > Plain and simple for now. */ > > static void > -som_symfile_offsets (struct objfile *objfile, struct section_addr_info *addrs) > +som_symfile_offsets (struct objfile *objfile, > + const struct section_addr_info *addrs) > { > int i; > CORE_ADDR text_addr; > Index: xcoffread.c > =================================================================== > RCS file: /cvs/src/src/gdb/xcoffread.c,v > retrieving revision 1.113 > diff -u -r1.113 xcoffread.c > --- xcoffread.c 6 May 2013 14:15:50 -0000 1.113 > +++ xcoffread.c 6 May 2013 19:36:41 -0000 > @@ -220,9 +220,6 @@ > > static void xcoff_symfile_finish (struct objfile *); > > -static void xcoff_symfile_offsets (struct objfile *, > - struct section_addr_info *addrs); > - > static char *coff_getfilename (union internal_auxent *, struct objfile *); > > static void read_symbol (struct internal_syment *, int); > @@ -3038,7 +3035,7 @@ > > static void > xcoff_symfile_offsets (struct objfile *objfile, > - struct section_addr_info *addrs) > + const struct section_addr_info *addrs) > { > const char *first_section_name; >