Re: RFA: fix PR breakpoints/13776

Tom Tromey
2012-03-02T17:39:22Z

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> If you do this before exit_inferior, then the
Pedro> breakpoint_init_inferior change is wrong, because the
Pedro> clear_thread_inferior_resources will touch already released memory.

Ugh, thanks for noticing.
I should have tried this.

Pedro> WDTY?

I think the patch is fine.

Pedro> 2012-02-29 Tom Tromey <tromey@redhat.com>
Pedro> Pedro Alves <palves@redhat.com>

... but it is silly to put my name on it since I think I wrote one line
in the result :)

Here is a test case for the bug.
I can commit it first if you'd prefer.

Tom

2012-03-02 Tom Tromey <tromey@redhat.com>

* gdb.base/nextoverexit.c: New file.
* gdb.base/nextoverexit.exp: New file.

diff --git a/gdb/testsuite/gdb.base/nextoverexit.c b/gdb/testsuite/gdb.base/nextoverexit.c
new file mode 100644
index 0000000..125d68f
--- /dev/null
+++ b/gdb/testsuite/gdb.base/nextoverexit.c
@@ -0,0 +1,23 @@
+/* Copyright 2012 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>.
+*/
+
+#include <stdlib.h>
+
+int
+main (void)
+{
+ exit (0);
+}
diff --git a/gdb/testsuite/gdb.base/nextoverexit.exp b/gdb/testsuite/gdb.base/nextoverexit.exp
new file mode 100644
index 0000000..fecbd58
--- /dev/null
+++ b/gdb/testsuite/gdb.base/nextoverexit.exp
@@ -0,0 +1,33 @@
+# Copyright 2012 Free Software Foundation, Inc.
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+set testfile "nextoverexit"
+set executable $testfile
+set srcfile $testfile.c
+set binfile $objdir/$subdir/$testfile
+
+if {[prepare_for_testing $testfile.exp $testfile $testfile.c]} {
+ return -1
+}
+
+if {![runto_main]} {
+ return -1
+}
+
+# Make sure we do not see any warnings.
+gdb_test_multiple "next" "next over exit" {
+ -re "$inferior_exited_re normally.\[\r\n\]+$gdb_prompt $" {
+ pass "next over exit"
+ }
+}