From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29647 invoked by alias); 13 Mar 2015 17:44:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29637 invoked by uid 89); 13 Mar 2015 17:44:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ob0-f182.google.com Received: from mail-ob0-f182.google.com (HELO mail-ob0-f182.google.com) (209.85.214.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 13 Mar 2015 17:44:42 +0000 Received: by obcwp18 with SMTP id wp18so21279220obc.6 for ; Fri, 13 Mar 2015 10:44:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=XYvA4PZWTRn6KdkL9LsTCAuL5xqRipS33zjniWFE8y8=; b=BcusloGqShQ59fJTs+1YD6LYm9ns6somqavT2wRoyG+KvrM3wN/qSD8Q7+vdWRVzNa gkq4JfLolUDZDJIs9LYsqtmRR0xyBv3mbQjx3RR8bX68mA2DK2ucrwk/70/fDbsbCvvi NrBI/3oCxjlDYwwMi0521TNmSg6HGEiUaa/D6pxPWeHqrhtO+CSWX+bzqeBl0/zXxZXj CpgjK42CLVpwRNKRUx5nf2w91qBPr+HmnpUtJK9OLMWX6QuCOsxyhGjh/lrMePu/Dw1Y ui3qghkv4/nDcReP1o7UmTNMMwICOksoHI8RYYcpKtue2/cGUNfJjga9kcvOh3R9OGRV msLw== X-Gm-Message-State: ALoCoQk+DdTfXKnhtR2v6aU6+M9Hc0I33C9W8n4lu3FkXHaVWiIuL6aUsIX8zPjo1aUSzoLwBeb7 MIME-Version: 1.0 X-Received: by 10.202.91.138 with SMTP id p132mr37234558oib.47.1426268680842; Fri, 13 Mar 2015 10:44:40 -0700 (PDT) Received: by 10.182.142.226 with HTTP; Fri, 13 Mar 2015 10:44:40 -0700 (PDT) In-Reply-To: <86egoshkg9.fsf@gmail.com> References: <86egoshkg9.fsf@gmail.com> Date: Fri, 13 Mar 2015 17:44:00 -0000 Message-ID: Subject: Re: [PATCH 0/6] DWARF Two Level Line Tables From: Doug Evans To: Yao Qi Cc: gdb-patches , Cary Coutant Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00395.txt.bz2 On Fri, Mar 13, 2015 at 10:32 AM, Yao Qi wrote: > Doug Evans writes: > >> This patch set adds Two Level Line Tables support to gdb, >> as well as support for the DWARF 5 line table extensions. > > Hi Doug, > I notice that a lot of code is added into dwarf2read.c in this patch > set. Is it possible to put them in a separated file or split > dwarf2read.c? Every time, when I read dwarf2read.c, I find it is too > long to understand. IWBN to split dwarf2read.c, at least, add new stuff > into a new file. dwarf2read.c is long overdue for a split. [though this patch set can't just be put in a new file as it just augments the line number support that is already there] But I'm still trying to catch gcc's dwarf2out.c. With this patch we're within 15KB, we've almost caught up! :-)