From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22834 invoked by alias); 10 Apr 2012 18:59:09 -0000 Received: (qmail 22826 invoked by uid 22791); 10 Apr 2012 18:59:07 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Apr 2012 18:58:55 +0000 Received: by vcbfk14 with SMTP id fk14so120494vcb.0 for ; Tue, 10 Apr 2012 11:58:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=UynY6l6ccxNH2JWoFBRwir2g2uOqizKpISftcXpUtMI=; b=C2nWsKkL+pfjs+gYsVYQB7KxU9pT5e1q/jwbgB1J8XtOYlQEAjuNGKHRNBFUu+CnXU fgWWeBwkWBLRzeBRcHlIcbbCp3UqsRUpvj35oL7k/6dwkukqXnICOvBesBmmRuZJxl/3 AffJj12OMLL7uUfo0buvhUtJ5hK5W2mKQLLv0Y8uSimYGdy3Cqm7lzw0B1z5HGB3QXqC 1v6Aux1IXePRoxGhED80YI/ShYMV2S+jwaR+a9QzEKCGUjD6IJg3JzUfU6dokhOEXked vQ2ajIYDb2lX+iIjaiAM71OUsQspUjOlvkHvuxT4xujXRWy37PykVtXI1qPkYNGVIaoW nd3Q== Received: by 10.52.94.146 with SMTP id dc18mr5178813vdb.19.1334084334692; Tue, 10 Apr 2012 11:58:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.94.146 with SMTP id dc18mr5178803vdb.19.1334084334547; Tue, 10 Apr 2012 11:58:54 -0700 (PDT) Received: by 10.220.73.14 with HTTP; Tue, 10 Apr 2012 11:58:54 -0700 (PDT) In-Reply-To: <87398c91x5.fsf@fleche.redhat.com> References: <20120409174612.1F60824618E@ruffy.mtv.corp.google.com> <87mx6k93f4.fsf@fleche.redhat.com> <87398c91x5.fsf@fleche.redhat.com> Date: Tue, 10 Apr 2012 19:19:00 -0000 Message-ID: Subject: Re: [patch] find_partial_die cleanups From: Doug Evans To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQnOO7+lRkLIdDJeLQgBlGvxdeZLe5c9TlzJXInZG0c7TKMKaRV1PY4mO9rBqWmxMqutbz+iOZ04qWyDRoOOhsBInynv4I8sfowmLQQQieAA96g7IboFPtIkS1vnw1yKuaOdNnMd6G3f9hpJKq94r94cU7aiXg== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00189.txt.bz2 On Mon, Apr 9, 2012 at 11:48 AM, Tom Tromey wrote: > Doug> And I would have used a complaint but the callers aren't > Doug> expecting a NULL return and since there is ample precedent, I went > Doug> with error. > > Existing precedent is good enough for me. Thanks, committed.