From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7443 invoked by alias); 18 Aug 2014 16:25:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7411 invoked by uid 89); 18 Aug 2014 16:25:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f170.google.com Received: from mail-vc0-f170.google.com (HELO mail-vc0-f170.google.com) (209.85.220.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 18 Aug 2014 16:25:49 +0000 Received: by mail-vc0-f170.google.com with SMTP id lf12so6016628vcb.15 for ; Mon, 18 Aug 2014 09:25:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=qAdKi6od0Ur5AySsLq+J4F+iIsXhcVMIe6VQ89Yu9JE=; b=Dg64qoVIzLmEldmHJEfW3C/+2np5vL3xEPZgZv55gxkmQol/2a+p2+98mCpfMV1D+O WwFq7uk9kUFoBbJWkSwO1xnQ68UVXJd3YQSWXycBG/Ar9XQVtLDzd4irzX7i9DB19Ghi VBfGNpeaIa/zxSRuh8wO3e9//vYX2NYQ3LWb+Xrr7TYgIvazAAPpSTKVChq0C5CXyhNM UTlK+Ej8wvszs1d3JmuQMzoSBRKwsw+5jwTLUTRHCx6vh7lw/kNzZSS+S1FzayQ5j1fW 1Qa1cwkb76Vl164ttpFu4hzm9K+T9ZykT8dF59uwqCCCcRXivtMtg0bV4Hgw2nxa+fVK 7kCw== X-Gm-Message-State: ALoCoQn7qb0l/SdBDKviUja8WFURphJMLX5rFZamRsMf2sdpuJ2fQB0xxAWVH2eeFi/uh4qsF/vy MIME-Version: 1.0 X-Received: by 10.220.105.201 with SMTP id u9mr25912763vco.11.1408379146849; Mon, 18 Aug 2014 09:25:46 -0700 (PDT) Received: by 10.52.136.203 with HTTP; Mon, 18 Aug 2014 09:25:46 -0700 (PDT) In-Reply-To: <1407923779-22149-3-git-send-email-gbenson@redhat.com> References: <1407923779-22149-1-git-send-email-gbenson@redhat.com> <1407923779-22149-3-git-send-email-gbenson@redhat.com> Date: Mon, 18 Aug 2014 16:25:00 -0000 Message-ID: Subject: Re: [PATCH 2/5 v7] Introduce common-types.h From: Doug Evans To: Gary Benson Cc: gdb-patches , Pedro Alves Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00305.txt.bz2 On Wed, Aug 13, 2014 at 2:56 AM, Gary Benson wrote: > This introduces common-types.h. This file defines various standard > types used by gdb and gdbserver. > > Currently these types are conditionally defined based on GDBSERVER. > The long term goal is to remove all such tests; however, this is > difficult as currently gdb uses definitions from BFD. In the meantime > this is still a step in the right direction. > > gdb/ > 2014-08-13 Tom Tromey > Gary Benson > > * common/common-types.h: New file. > * Makefile.in (HFILES_NO_SRCDIR): Add common/common-types.h. > * common/common-defs.h: Include common-types.h. > * defs.h (gdb_byte, CORE_ADDR, CORE_ADDR_MAX, LONGEST) > (ULONGEST): Remove. > > gdb/gdbserver/ > 2014-08-13 Tom Tromey > Gary Benson > > * server.h: Add static assertion. > (gdb_byte, CORE_ADDR, LONGEST, ULONGEST): Remove. LGTM