From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8589 invoked by alias); 15 Jan 2015 19:49:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8578 invoked by uid 89); 15 Jan 2015 19:49:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ob0-f175.google.com Received: from mail-ob0-f175.google.com (HELO mail-ob0-f175.google.com) (209.85.214.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 15 Jan 2015 19:49:08 +0000 Received: by mail-ob0-f175.google.com with SMTP id va8so11058445obc.6 for ; Thu, 15 Jan 2015 11:49:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=anvSzFV29oVWrSUHIZfDow/toYQWLB4yAkJFJW+s7P4=; b=EmX6m8ry28F4pkDvOgKqUvqHaTXoP0gxAq1c4gusNME5NzTvP5dzddh2LSf5CduX8Q 1RPyviNO7Dk5G6BIM6e508IYFQ4k/3Ye97dICVo/R+8OaF1jBCfy98fpM8YONejR+BQD GXTcVdEkw8yYffuIZLBc8XZNo+itAHo6bU1MEf36uqSxLnSIis/XUWzXLBM8ApZTJH85 t+xA0PowGTl4I9YyN1STfvB1DQELHCav3yjb/c6Rf3lhPwjRgI4wlkfDBn32pklbVRQS eXFqJJ33t6lR8u8vvLmGcJ0jT+PKRU6Ub+ONqs29CNYLgrn3HOHPuoyITMi+xg1teB+N RaCA== X-Gm-Message-State: ALoCoQniQNEZ2C77gIhSH9mnEyUN/SNj/tD+5sH1CJr2juHmFbBCEeyx+QcNG8bMiXWR2JAV574O MIME-Version: 1.0 X-Received: by 10.202.59.136 with SMTP id i130mr6534467oia.114.1421351346090; Thu, 15 Jan 2015 11:49:06 -0800 (PST) Received: by 10.182.222.98 with HTTP; Thu, 15 Jan 2015 11:49:06 -0800 (PST) In-Reply-To: <83vbk82fkg.fsf@gnu.org> References: <83vbk82fkg.fsf@gnu.org> Date: Thu, 15 Jan 2015 19:49:00 -0000 Message-ID: Subject: Re: Building the 7.8.90 pretest on MinGW From: Doug Evans To: Eli Zaretskii Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00436.txt.bz2 On Thu, Jan 15, 2015 at 8:07 AM, Eli Zaretskii wrote: > I've built the pretest using MinGW32. I found 2 issues: one with > gnulib's time.h (reported to the gnulib list), the other with the > recent changes in tui/. Specifically, starting "gdb -tui" fails with > this error message: > > Cannot enable the TUI: error opening terminal [TERM=] > > This happens because the recent additions to tui.c make assumptions > about the curses library that don't hold for the MinGW port of > ncurses, e.g. that $TERM must be set. > > The patch below fixes this for me. OK to install it (master and > branch)? > > 2015-01-15 Eli Zaretskii > > * gdb/tui/tui.c (tui_enable) [__MINGW32__]: If the call to 'newterm' > fails with the 1st arg NULL, try again with "unknown". Don't test > the "cup" capability: it isn't supported by the Windows port of > ncurses, but the Windows console driver is still capable of > supporting TUI. Ok by me.