From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14866 invoked by alias); 14 May 2014 22:24:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14857 invoked by uid 89); 14 May 2014 22:24:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ve0-f170.google.com Received: from mail-ve0-f170.google.com (HELO mail-ve0-f170.google.com) (209.85.128.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 14 May 2014 22:24:18 +0000 Received: by mail-ve0-f170.google.com with SMTP id db11so283385veb.15 for ; Wed, 14 May 2014 15:24:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=DyzqEK2ifWJsIsRpnaFWK/gXbwghM07zKnzvi4jSGmI=; b=d4BJ8kY4jtdPP3w0v3ajGuftfoSa0KRbsZQzPb09aO0KqmIRt5ptA1jemADs2D2xvk CzOBVXhTF2YL2Z6TL/mdgSpqGVmJ34kg7pLREk27tQEZqIVe7UqXEHc4i9ME0ddb9YVv RpBV/Sr1xsog0VMAfaK/ZXZwe3goaw6MohoXQJ+GDKiGOreAr5sQ5HF7oQtcglYS8dil MLHo0CBfM81KzYk0i+XSyP428o3SgCCDKeJvy0BMKeKSJeizpQfay4+dW2dkgDY0ud/L LhECAOrDUmCkTSFaaMk3fFVysWkPu2LA0JigzSaqZZLRHjSAaFOx6ufNMuO30TSriGFB dqBg== X-Gm-Message-State: ALoCoQkn7ueJm3J9EE8jjMrm0Cf+gG99mOUmWubHPqTn4iT9/p4RmAZBIz5mWkDUpHCbVyxUMdP6 MIME-Version: 1.0 X-Received: by 10.58.84.65 with SMTP id w1mr5099349vey.8.1400106256080; Wed, 14 May 2014 15:24:16 -0700 (PDT) Received: by 10.52.68.67 with HTTP; Wed, 14 May 2014 15:24:16 -0700 (PDT) In-Reply-To: <1B70C5D6-D845-4F9A-A874-63DF77FB9030@dell.com> References: <20140514110742.GA25550@blade.nx> <1B70C5D6-D845-4F9A-A874-63DF77FB9030@dell.com> Date: Wed, 14 May 2014 22:24:00 -0000 Message-ID: Subject: Re: [PATCH] Prompt user to report bugs From: Doug Evans To: Paul Koning Cc: Gary Benson , gdb-patches , Tom Tromey Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00218.txt.bz2 On Wed, May 14, 2014 at 2:11 PM, wrote: > > On May 14, 2014, at 5:05 PM, Doug Evans wrote: > >> On Wed, May 14, 2014 at 4:07 AM, Gary Benson wrote: >>> Hi all, >>> >>> This patch prints a couple of extra lines in internal_vproblem >>> to prompt the user to report the bug that's just happened. >>> >>> Ok to commit? >>> >>> Thanks, >>> Gary >>> >>> -- >>> 2014-05-14 Gary Benson >>> >>> * utils.c (internal_vproblem): Prompt the user to file a report. >>> >>> diff --git a/gdb/utils.c b/gdb/utils.c >>> index a8a7cb3..905ce6d 100644 >>> --- a/gdb/utils.c >>> +++ b/gdb/utils.c >>> @@ -746,6 +746,14 @@ internal_vproblem (struct internal_problem *proble= m, >>> else >>> internal_error (__FILE__, __LINE__, _("bad switch")); >>> >>> + fputs_unfiltered (_("\nThis is a bug, please report it."), gdb_stder= r); >>> + if (REPORT_BUGS_TO[0]) >>> + { >>> + fputs_unfiltered (_(" For instructions, see:\n"), gdb_stderr); >>> + fprintf_unfiltered (gdb_stderr, _("%s."), REPORT_BUGS_TO); >>> + } >>> + fputs_unfiltered ("\n\n", gdb_stderr); >>> + >>> if (problem->should_dump_core =3D=3D internal_problem_ask) >>> { >>> if (!can_dump_core (reason)) >>> >> >> top.c doesn't wrap "%s." in _(). >> I don't know if it matters, it's just odd to see "%s." wrapped. > > > It also seems odd to see =E2=80=9C%s.=E2=80=9D inside _( ) since there=E2= =80=99s nothing to translate there. That's why it seemed odd to me too. :-) [Though what do I know ... maybe someone might want to use something other than "." at the end.]