From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6801 invoked by alias); 24 Apr 2014 00:30:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6790 invoked by uid 89); 24 Apr 2014 00:30:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f178.google.com Received: from mail-vc0-f178.google.com (HELO mail-vc0-f178.google.com) (209.85.220.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 24 Apr 2014 00:30:44 +0000 Received: by mail-vc0-f178.google.com with SMTP id hu19so2177564vcb.9 for ; Wed, 23 Apr 2014 17:30:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=nfYyQXA92caVBlqBUoxsQ33c5TZKH+Yh9KvH6fgOINM=; b=N7lBcZRBY00svbQYmzLDwAJF85XjmGWHC+/NCVKHv7JlK9ubLu8ZTok4utyNCV+TAT epOJ7CwywXrsKspW1WN/ivLcNpAOUYtWGBAaIID5D/r1S9+331BSgI8phwiBA1gz5v0O LdWL3h3GTCZv4lE1K3G6AV4F1Y5cbHc5V8ryCjypuwpiOi/K7FPlnzEN02ZBeG56zwe8 3dxQwd/loglsTMf9A8C92QoCxTW6INJQ0bPidTyA81+Xo1Sj1V7pCIAmah72qRfwQwT0 UTd02fQkygqF3puOJN0xVsQ+pjRLhwJJopewwFggGL310fMqr+CrZyU+83vOpo+4q7t2 zlfA== X-Gm-Message-State: ALoCoQlJXdOsAJfDJThInmj9KGQkivPN4Xmtmc4fQxPhX+lhCkmMrZ7fh78YApcPEADUC0+yZ0s1im7DGel1pAaif+jbtYc1+hIoo9+wtGmSESm7VJPNm9kJik6pNctiym25rDbj4oC5V6Ld6atFYPkJMD5NHG6wTrerwlW+POTvQ6Ye+1Kqphh9UwLtqjRGnon3rxv/Z8KJet1wCoM77vtZg4pb5CjEig== MIME-Version: 1.0 X-Received: by 10.220.159.4 with SMTP id h4mr44865338vcx.1.1398299442235; Wed, 23 Apr 2014 17:30:42 -0700 (PDT) Received: by 10.52.13.101 with HTTP; Wed, 23 Apr 2014 17:30:42 -0700 (PDT) In-Reply-To: <21336.22905.197076.913141@ruffy.mtv.corp.google.com> References: <21336.22905.197076.913141@ruffy.mtv.corp.google.com> Date: Thu, 24 Apr 2014 00:30:00 -0000 Message-ID: Subject: Re: [patch] add return values to return statements in non-void functions From: Doug Evans To: David Blaikie Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00486.txt.bz2 On Wed, Apr 23, 2014 at 5:23 PM, Doug Evans wrote: > David Blaikie writes: > > These missing return values cause build breaks with clang which > > defaults the -Wreturn-type warning to an error in this case. > > > > Add the right return values so these tests can run when using clang. > > commit ce1534e51863af5d935cdc63c44df0fa64a46653 > > Author: David Blaikie > > Date: Fri Apr 11 17:20:49 2014 -0700 > > > > Add return value for non-void function return statements to fix error in clang build. > > > > Clang defaults this warning to an error, breaking the build & causing > > these tests not to run. > > > > gdb/testsuite/ > > > > * gdb.mi/non-stop.c: Add return value for non-void function return > > statement. > > * gdb.threads/staticthreads.c: Ditto. > > ChangeLog rules require being more specific about where the change happened. > E.g., > > * gdb.mi/non-stop.c (worker): Add return value for non-void function > return statement. > * gdb.threads/staticthreads.c (thread_function): Ditto. > > Ok with those changes. > Thanks! Bleah. Missed that this one was also already approved. [that's what I get for switching back and forth between mail readers]