From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28751 invoked by alias); 23 Jun 2012 22:58:28 -0000 Received: (qmail 28743 invoked by uid 22791); 23 Jun 2012 22:58:27 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 23 Jun 2012 22:58:14 +0000 Received: by vcbfl10 with SMTP id fl10so1786321vcb.0 for ; Sat, 23 Jun 2012 15:58:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=PHWMoTh3guF+PMx5uZMZW9Xt2BNRKFbElUvacpTYJ3c=; b=nHACQRgvawMduPYeE9vCsJz43TZkBKPm0DFRHBE+Vu/gjj0TpcXvHxk/Opa9xVXou2 7/BYTBwSAYmNR6LthdgCwaIlyyq1s7hvVbLEHHBgJF7JNutzS92Ftq/uwVmNGzks6jiX GTcmclZIA66GwqBllKCIQW4Cg/FScnjgboaquqC8pvDLty2A9DufIO39A6DWuXodolHD KJYEZiRaS7pQtARFQX1UUoRUljcEjO2jxdql3wKLI5OO49a+G9EjXoR2KgTqkqNiGdmQ LT09T14qE/QV0jU4yzMKbERosnLBeZveKQS3cpoagveAu3b3APiXGjubc9nagi/uH0VI iGhQ== Received: by 10.52.95.225 with SMTP id dn1mr3440369vdb.99.1340492293951; Sat, 23 Jun 2012 15:58:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.95.225 with SMTP id dn1mr3440363vdb.99.1340492293859; Sat, 23 Jun 2012 15:58:13 -0700 (PDT) Received: by 10.52.168.99 with HTTP; Sat, 23 Jun 2012 15:58:13 -0700 (PDT) In-Reply-To: <87sjdnjv9y.fsf@fleche.redhat.com> References: <20120619222645.36C911E26C4@ruffy2.mtv.corp.google.com> <87sjdnjv9y.fsf@fleche.redhat.com> Date: Sat, 23 Jun 2012 22:58:00 -0000 Message-ID: Subject: Re: [doc RFA] "set debug dwarf2-read" and "set debug symtab-create" From: Doug Evans To: Tom Tromey Cc: gdb-patches@sourceware.org, eliz@gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQkQnmLTjAb+PQdw5FOpgCDzSzPoXmC2ArUbVAioGFzAAvPmGVtsqQLON0Rqgaw7LQ1Ro9oNOd5m2lEYFYFDRjrCJBDfSsZrCxvMujVELHQE+1lhkq4gQCTRSdQ2HNrx0sL3AijmKOYEzbcYd6J/MtMNPNRvEnP3gsOTTjdUths0PFLAIbjIqladJsJm69ZTBYD5CbhW X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00745.txt.bz2 On Fri, Jun 22, 2012 at 7:06 AM, Tom Tromey wrote: >>>>>> "Doug" =3D=3D Doug Evans writes: > > Doug> I'm committing this after a doc RFA. > Doug> [But feel free to suggest changes or enhancements.] > > Seems nice; I've wanted something like this before. =A0I have one > suggestion: > > Doug> @@ -5286,6 +5300,13 @@ process_queue (void) > > Doug> + =A0 =A0 =A0fprintf_unfiltered (gdb_stdlog, > Doug> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 "Expanding one or more symtab= s of objfile %s ...\n", > Doug> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 dwarf2_per_objfile->objfile->= name); > > This seems a little vague; it would be nice to, say, print the CU offset > here. > > Tom This message is part A of a two part set. The other part is: @@ -5690,6 +5717,14 @@ process_full_comp_unit (struct dwarf2_per_cu_data *per_cu, struct cleanup *back_to, *delayed_list_cleanup; CORE_ADDR baseaddr; + if (dwarf2_read_debug) + { + fprintf_unfiltered (gdb_stdlog, + "Expanding symtab of %s at offset 0x%x\n", + per_cu->is_debug_types ? "TU" : "CU", + per_cu->offset.sect_off); + } + baseaddr =3D ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile)= ); buildsym_init (); I want to keep the S/N ratio high and thus I don't want to print the objfile name for each expanded symtab (expanding one symtab can involve expanding others as well). So part A (so to speak) prints the objfile name and part B (possibly replicated multiple times) prints all the CUs that get expanded. I can add a comment noting this fact if you like.