From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31821 invoked by alias); 8 Feb 2014 05:19:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31805 invoked by uid 89); 8 Feb 2014 05:19:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vb0-f43.google.com Received: from mail-vb0-f43.google.com (HELO mail-vb0-f43.google.com) (209.85.212.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 08 Feb 2014 05:19:34 +0000 Received: by mail-vb0-f43.google.com with SMTP id p5so3292434vbn.16 for ; Fri, 07 Feb 2014 21:19:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=jZWyIM9k3+yiiz7OqfkdhMwk56t+lsuPN6ZAfiIyfBE=; b=K0L+X+PvoBfAqmiXdGMe6frZ9hNTTly6wkrMEzyVpzUQGZh/clRs9QLLIEWjZIzi0b eTcAsKYK6xOsKotPbxRZ5y2KXG6RGAM9+iOPkIAUnTZBv3VpZdFPgnO/I86dNsk0bhHt /8d8MEI9IP1vi/wJfOj7hm2gpQy9jI5Zm4dyjqLSESfl8EkS2uv45hOJ5hQoH64YfHo+ Gm2+TsqiEtiymyydgrBK7NO6qZQMrPXzPh7s7lxWwME6bRm1jzNRwHmbkAgYmk/rwjqZ og8Zq9UuQuosBciY8BgcYDFvs4llGDGRkLJJFJPNL9EEK+9A6/MFkEFBIbEaQAR7K/F4 dgFA== X-Gm-Message-State: ALoCoQlxbWRvGtF4ZNrhMMO4270/f6Xj01F+aGfwL5EwhIDeJV3JiT1cuT/vDTpsPY6UdyKN2IE0UA21RpPwgouyb1pAqZWj+g5Wdc+p8E+d0YMYOkjgI2BelthV0UjlK/A5MD/WeAe0Z06sQPIvF+BDwWQUztlcsQ2ze8EjlxUjmrqhBu2Bfob0xRXEet1zAlNfYTq19ZrzJo0LV2Lsy8H/gkANtBe26w== MIME-Version: 1.0 X-Received: by 10.58.132.203 with SMTP id ow11mr13750564veb.1.1391836772503; Fri, 07 Feb 2014 21:19:32 -0800 (PST) Received: by 10.52.51.234 with HTTP; Fri, 7 Feb 2014 21:19:32 -0800 (PST) In-Reply-To: <1391720136-2121-2-git-send-email-tromey@redhat.com> References: <1391720136-2121-1-git-send-email-tromey@redhat.com> <1391720136-2121-2-git-send-email-tromey@redhat.com> Date: Sat, 08 Feb 2014 05:19:00 -0000 Message-ID: Subject: Re: [RFC v2 01/38] add "this" pointers to more target APIs From: Doug Evans To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00239.txt.bz2 On Thu, Feb 6, 2014 at 12:54 PM, Tom Tromey wrote: > A subsequent pass introduces delegation helper functions to the target > API. This delegation is much cleaner if the target_ops pointer is > directly available at delegation time. > > This patch adds the "this" pointer to various to_* methods for this > purpose. > > This updates a number of ports which I am unable to test. Please give > them a look-over. Any possible problem here is trivial, though, as > all that is required is adding an argument to a function. Hi. I'm *not* suggesting wholesale changes (babysteps is totally fine with me), but there's something I'm not sure about. I think it was on IRC where there was a discussion of passing the (pseudo-)vtable pointer as the self/this parameter being less preferable to passing a more canonical self/this which in turn has the (pseudo-)vtable pointer. In this case we might not need such a change until such time as we've already converted to C++ (and thus taking the next step now could be time best spent elsewhere). My question is to ask for clarity on where you see the target API headed. Will we need a more canonical self/this pointer soon(-ish)?