From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14036 invoked by alias); 19 Aug 2014 17:25:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14027 invoked by uid 89); 19 Aug 2014 17:25:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f181.google.com Received: from mail-vc0-f181.google.com (HELO mail-vc0-f181.google.com) (209.85.220.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 19 Aug 2014 17:24:59 +0000 Received: by mail-vc0-f181.google.com with SMTP id lf12so7728550vcb.40 for ; Tue, 19 Aug 2014 10:24:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=WvBePld6wHPajyPT7CmP5F9lLmYBLuRHRSr1kIXuYzg=; b=RBWcZry8Rph3EHjYBPuYhV9ZN9+gZvs+WIM7Vxs7l7fDmMKZl806CmQ8JXxq+CWBZ1 dnGrwUL6NMH74qRKActBDomnD+8YIbm9XfYybNPixweysfzuaUw2R97o18KV5J7DtTa0 6A1BV1cDi99fZrMA5ZQ2eUWVMXBSNEPn3NNRO2eKn2qf2eZasHPlC0XwMhMbDcb9YNoh xpBrQOZ+WtAr0mbAmHHNwF6BRkPekVOnyOnopq7u1GyGeOwJrEvhwlzhdaGqLnSNL/jI mg/23npocVxQQBjaoEcDDSjYqWWLXvrEm5mz62uwJoUgNGVVwlflVmLFpC2efo2TwBj4 njhQ== X-Gm-Message-State: ALoCoQlDqV/0SUsaS2oXNqMOu3X9/M44iRSjZtpzGJLuY/r3mUrzgeX+B13JgvFYMx9O01lNBhoe MIME-Version: 1.0 X-Received: by 10.220.80.82 with SMTP id s18mr1710289vck.57.1408469096737; Tue, 19 Aug 2014 10:24:56 -0700 (PDT) Received: by 10.52.136.203 with HTTP; Tue, 19 Aug 2014 10:24:56 -0700 (PDT) In-Reply-To: <53F38030.1020406@redhat.com> References: <53F38030.1020406@redhat.com> Date: Tue, 19 Aug 2014 17:25:00 -0000 Message-ID: Subject: Re: [RFC] delete gdb.cp/ambiguous.exp ? From: Doug Evans To: Pedro Alves Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00356.txt.bz2 On Tue, Aug 19, 2014 at 9:49 AM, Pedro Alves wrote: > On 08/19/2014 12:23 AM, Doug Evans wrote: >> Along the lines of dead code removal ... >> >> What should we do with this testcase? >> >> The messages it is looking for from gdb do not exist, > > Hmm. These are: > > # X is derived from A1 and A2; both A1 and A2 have a member 'x' > send_gdb "print x.x\n" > gdb_expect { > -re "warning: x ambiguous; using X::A2::x. Use a cast to disambiguate.\r\n\\$\[0-9\]* = \[-\]*\[0-9\]*\r\n$gdb_prompt $" { > pass "print x.x" > } > -re "warning: x ambiguous; using X::A1::x. Use a cast to disambiguate.\r\n\\$\[0-9\]* = \[-\]*\[0-9\]*\r\n$gdb_prompt $" { > pass "print x.x" > } > -re ".*$gdb_prompt $" { fail "print x.x" } > timeout { fail "(timeout) print x.x" } > } > > Actually enabling the test (removing the skip, and adding > nowarnings), we see that indeed GDB outputs no warning: But given the early exit the test itself is never run. And it's been this way since at least 2003 (commit 4d9eda44f), and longer (that commit just changed the style of the gcc test)! I'm all for filing a bug and recording the test in the bug report. I'm even ok with keeping the test as is. The high order bit for me is exploring what the community wishes be done with this kind of "dead code".