From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12497 invoked by alias); 10 Jul 2012 18:45:10 -0000 Received: (qmail 12486 invoked by uid 22791); 10 Jul 2012 18:45:09 -0000 X-SWARE-Spam-Status: No, hits=-5.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SARE_SUB_IMPROVE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Jul 2012 18:44:54 +0000 Received: by vbkv13 with SMTP id v13so271854vbk.0 for ; Tue, 10 Jul 2012 11:44:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=OBDyIyT4x4H2SUyMbx/foYCimm3/vejeTDLqAnl0Nx4=; b=loiWY9LqmxQ/IuZAL4EtvsMbc0HE97vNEd9zzz2djV2/qTlfx2/XoTpi473C47ojhU pTaqyWe6LnJAU6X2X3AtKChkCuIeQ4vnk+ekJK0mdHTFfM/lUWJoJkZaTjzFS+GkApYl YjUOnsT06IkH5MrCfjQO/Gj8DpxWMzhr/uIsALDXt5FeF7NzVN+29sWxos86+wc9Buqv 2VK3829USUV0SYIBlQR3GlH/bdJ2U6c7aM7wrS5K+x0LPelBAmivOnwvxcoOZYZpOFtK 1AP8nv8tV/yxCLjKqj9yR26XuNI9xwEyIKS8Th5iMQ2cVUW8zhzYOpwQfCxXvMaxmZzg hjRg== Received: by 10.221.12.145 with SMTP id pi17mr876306vcb.48.1341945893748; Tue, 10 Jul 2012 11:44:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.221.12.145 with SMTP id pi17mr876297vcb.48.1341945893613; Tue, 10 Jul 2012 11:44:53 -0700 (PDT) Received: by 10.52.34.45 with HTTP; Tue, 10 Jul 2012 11:44:53 -0700 (PDT) In-Reply-To: <87r4sjh894.fsf@fleche.redhat.com> References: <20120710080913.82E3B1E1253@ruffy2.mtv.corp.google.com> <87r4sjh894.fsf@fleche.redhat.com> Date: Tue, 10 Jul 2012 18:45:00 -0000 Message-ID: Subject: Re: [RFA 2/4] Improve DWARF Type Unit performance From: Doug Evans To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQmGSe/k3kL23XjA7cjyMdb6yRRVK0olmZld61lRsQej7PvAqmVUnPcDcxBoa3WPcWM992AM99K3LBh8HHlc6m00XNmcUFRYF7VqFtyO0SoFwhBzskUQXcxIW3MsOjyStwoz6e3vEHwj2qFaRnL55edU4reqWDYQAQCIUxywsdWpjOI2XYYITgKQtx3mu7KAccnEKU6N X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00137.txt.bz2 On Tue, Jul 10, 2012 at 9:48 AM, Tom Tromey wrote: >>>>>> "Doug" == Doug Evans writes: > > Doug> 2012-07-09 Doug Evans > Doug> * psympriv.h (struct partial_symtab): New member "anonymous". > Doug> * psymtab.c (partial_map_symtabs_matching_filename): Ignore > Doug> anonymous psymtabs. > Doug> (map_symbol_filenames_psymtab): Ditto. > Doug> (expand_symtabs_matching_via_partial): Ditto. > Doug> (dump_psymtab): Update. > > Does read_psymtabs_with_filename need to check 'anonymous'? > It wasn't clear to me. > > Other that that, this patch looks good to me. Yes indeed. Thanks.