From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24442 invoked by alias); 28 Aug 2013 14:55:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24430 invoked by uid 89); 28 Aug 2013 14:55:18 -0000 Received: from mail-qc0-f180.google.com (HELO mail-qc0-f180.google.com) (209.85.216.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 28 Aug 2013 14:55:18 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,NO_RELAYS autolearn=ham version=3.3.2 X-HELO: mail-qc0-f180.google.com Received: by mail-qc0-f180.google.com with SMTP id l13so3026817qcy.11 for ; Wed, 28 Aug 2013 07:55:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=jM58frVv+zx+Wa4wjKpLZRVXKr361InKTt1EDPCtrRU=; b=cHc/BjF+PmY4W+ZXHliO9RTA2PbhkuzTWCgmRCkqHySeW2r+SmQrNRfm85sS5po9aB B69knBDKZYCkHzQV/E9y6DSlZA/0ivMfBI2iF9kowcLs6rVX8VaO+GogrVV9VQs89w++ oor5iZCl8wYW5MhpCiGpOEy5c3XtpurR8oHg25WIVIIlG2fugNfwZvjGYgMd9TuTyfTr 2ScEUr07Abbvb12Bm/Zs1IENTKCRA1i097UNFdgwtbc2E9G78DaOrPxerDGhwiOZAVnz YNGucKvUoVrKZeqZrAMmD4kZ8svjRRhCnpwWkvLMS2x2Ac8wrwoLDpiDvtweEWDMiWY7 lpDg== X-Gm-Message-State: ALoCoQmvHBD0vzk7SfXdibnKLgg7nElqmQQsvXJK+ho018OVqAu1t3bSmwVv5s8DnfSbKKmMfPKvh/nv2tyjqq9k0fvYnyFIc23d4z/DNQV6H0jLKtZX97y93b1iNiVHMZphdnZVY1BEr8C0V/FzDHZKpGeOj0VnAcTb6JhQhaCYvca+CshvI4H9odIVIwUlXcaHrnN21gvg7qcW4VUjmKaVbOj4SZKBQg== MIME-Version: 1.0 X-Received: by 10.49.84.6 with SMTP id u6mr2957207qey.79.1377701714309; Wed, 28 Aug 2013 07:55:14 -0700 (PDT) Received: by 10.229.237.9 with HTTP; Wed, 28 Aug 2013 07:55:14 -0700 (PDT) In-Reply-To: <87vc2px5g3.fsf@fleche.redhat.com> References: <87vc2px5g3.fsf@fleche.redhat.com> Date: Wed, 28 Aug 2013 14:55:00 -0000 Message-ID: Subject: Re: FYI: fix test name in gdb-index.exp From: Doug Evans To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2013-08/txt/msg00831.txt.bz2 TIL: It's not just that test names have to be unique, but they can no longer include build directory names because the latter can be machine generated, and when diff'ing before/after runs it can lead to spurious output needing investigating. Good to know, thanks. And good thing to add to the testcase cookbook. On Wed, Aug 28, 2013 at 7:20 AM, Tom Tromey wrote: > I'm checking this in. > > The new gdb-index.exp test included a directory name in a test name. > This lead to spurious failures for me, because I ran the baseline tests > in a different directory. > > Tom > > 2013-08-28 Tom Tromey > > * gdb.dwarf2/gdb-index.exp (add_gdb_index): Use explicit test name > when saving index. > > Index: gdb.dwarf2/gdb-index.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.dwarf2/gdb-index.exp,v > retrieving revision 1.1 > diff -u -r1.1 gdb-index.exp > --- gdb.dwarf2/gdb-index.exp 26 Aug 2013 18:43:40 -0000 1.1 > +++ gdb.dwarf2/gdb-index.exp 28 Aug 2013 14:17:05 -0000 > @@ -36,7 +36,8 @@ > set index_file ${program}.gdb-index > verbose -log "index_file: ${index_file}" > remote_file host delete ${index_file} > - gdb_test_no_output "save gdb-index [file dirname ${index_file}]" > + gdb_test_no_output "save gdb-index [file dirname ${index_file}]" \ > + "save gdb-index for file [file tail ${program}]" > > # No point in continuing if generating the index failed. > # N.B.: There are times when gdb won't create an index, and it's not a