From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14588 invoked by alias); 16 Jul 2014 18:33:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14533 invoked by uid 89); 16 Jul 2014 18:33:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f176.google.com Received: from mail-vc0-f176.google.com (HELO mail-vc0-f176.google.com) (209.85.220.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 16 Jul 2014 18:33:41 +0000 Received: by mail-vc0-f176.google.com with SMTP id ik5so2419925vcb.21 for ; Wed, 16 Jul 2014 11:33:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=4d6G0JzMuxLlPArZLBoiOHQ/TEJTakBoS98lAz9v6VA=; b=N0AEjnYKNH7qGC7yxFwt7pddY1+Qn1Cge7Ly56G6MmkZcq3u6CaeaebCxhXDSAa/BI pm5coIbUnC3QESEsiu4cjn4ME6D16pvuJC/C8CwXqMDUXkMQRcmLpAjKEE3ShJg3fYue 7NhnpR1jMnWjAcfyzEKCuHp58I6RdVACJF4v0l9CYIkNmoDxonuajlhgUEQeqXo467sK KgmyqqG8/IEhCBAyjet2Fmmhmc5CHv6bpKZh4tyVKtcpX7FybhzZlGEQ5Hr8rVB3sH6w oLtVdSROGt3ybbsynlFCyR7LKQJ8+1/H9mefIfd868dnYpXlX+y9tUQOPe+IGSYiI6e0 mb3w== X-Gm-Message-State: ALoCoQmvinKmUzbfTih/M1IdmebXQjjIF2W+9gLHx5Q/DAi961yZwgNm1NfHjRjW1t4mOZBqsxcm MIME-Version: 1.0 X-Received: by 10.221.41.135 with SMTP id tu7mr4747451vcb.70.1405535618832; Wed, 16 Jul 2014 11:33:38 -0700 (PDT) Received: by 10.52.28.233 with HTTP; Wed, 16 Jul 2014 11:33:38 -0700 (PDT) In-Reply-To: <1405520243-17282-2-git-send-email-gbenson@redhat.com> References: <1405520243-17282-1-git-send-email-gbenson@redhat.com> <1405520243-17282-2-git-send-email-gbenson@redhat.com> Date: Wed, 16 Jul 2014 18:36:00 -0000 Message-ID: Subject: Re: [PATCH 01/15 v2] Introduce common/errors.h From: Doug Evans To: Gary Benson Cc: gdb-patches , Tom Tromey Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00449.txt.bz2 On Wed, Jul 16, 2014 at 7:17 AM, Gary Benson wrote: > This introduces common/errors.h. This holds some error- and > warning-related declarations that can be used by the code in common. > Clients of the "common" code must provide definitions for these > functions. > > gdb/ > 2014-07-16 Tom Tromey > Gary Benson > > * common/errors.h: New file. > * utils.h: Include errors.h. > (perror_with_name, error, fatal, warning): Don't declare. > * common/common-utils.h: Include errors.h. > (malloc_failure, internal_error): Don't declare. > > gdb/gdbserver/ > 2014-07-16 Tom Tromey > > * utils.h: Include errors.h. > (perror_with_name, error, fatal, warning): Don't declare. Hi. Comments inline. > --- > gdb/ChangeLog | 9 +++++++ > gdb/common/common-utils.h | 5 +--- > gdb/common/errors.h | 55 +++++++++++++++++++++++++++++++++++++++++++++ > gdb/gdbserver/ChangeLog | 5 ++++ > gdb/gdbserver/utils.h | 5 +--- > gdb/utils.h | 10 +------- > 6 files changed, 72 insertions(+), 17 deletions(-) > create mode 100644 gdb/common/errors.h > > diff --git a/gdb/common/common-utils.h b/gdb/common/common-utils.h > index 063698d..53be2f8 100644 > --- a/gdb/common/common-utils.h > +++ b/gdb/common/common-utils.h > @@ -24,6 +24,7 @@ > #include "ansidecl.h" > #include > #include > +#include "errors.h" > > /* If possible, define FUNCTION_NAME, a macro containing the name of > the function being defined. Since this macro may not always be > @@ -43,10 +44,6 @@ > #endif > #endif > > -extern void malloc_failure (long size) ATTRIBUTE_NORETURN; > -extern void internal_error (const char *file, int line, const char *, ...) > - ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (3, 4); > - > /* xmalloc(), xrealloc() and xcalloc() have already been declared in > "libiberty.h". */ > > diff --git a/gdb/common/errors.h b/gdb/common/errors.h > new file mode 100644 > index 0000000..5f998e3 > --- /dev/null > +++ b/gdb/common/errors.h > @@ -0,0 +1,55 @@ > +/* Declarations for error-reporting facilities. > + > + Copyright (C) 1986-2014 Free Software Foundation, Inc. > + > + This file is part of GDB. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +#ifndef COMMON_ERRORS_H > +#define COMMON_ERRORS_H > + > +/* The declarations in this file are, for the time being, separately > + implemented by gdb and gdbserver. However they share a common > + definition so that they can be used by code in common/. */ > + > +/* Like "perror" but throws an exception with the appropriate > + text. */ > + > +extern void perror_with_name (const char *) ATTRIBUTE_NORETURN; > + > +/* Throw an exception. */ > + > +extern void error (const char *fmt, ...) > + ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 2); > + > +/* Cause a fatal error. */ > + > +extern void fatal (const char *fmt, ...) > + ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 2); fatal is a confusing name IMO. In gdb it just throws RETURN_QUIT. That's not your fault of course, but I wonder if I can trouble you to expand on the function comment a bit. E.g., something like the following? /* Cause a fatal error. What this does in gdb is throw a RETURN_QUIT exception. */ One could expand on the comment, but I didn't want to turn it into a FIXME. [which is really what it should be, but that's a topic for another patch :-)] > + > +/* Issue a warning. */ > + > +extern void warning (const char *, ...) ATTRIBUTE_PRINTF (1, 2); > + > +/* Internal error. */ > + > +extern void internal_error (const char *file, int line, const char *, ...) > + ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (3, 4); > + > +/* Memory allocation failure. */ > + > +extern void malloc_failure (long size) ATTRIBUTE_NORETURN; > + > +#endif /* COMMON_ERRORS_H */ > diff --git a/gdb/gdbserver/utils.h b/gdb/gdbserver/utils.h > index 906924b..819fa35 100644 > --- a/gdb/gdbserver/utils.h > +++ b/gdb/gdbserver/utils.h > @@ -20,11 +20,8 @@ > #define UTILS_H > > #include "print-utils.h" > +#include "errors.h" > > -void perror_with_name (const char *string) ATTRIBUTE_NORETURN; > -void error (const char *string,...) ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 2); > -void fatal (const char *string,...) ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 2); > -void warning (const char *string,...) ATTRIBUTE_PRINTF (1, 2); > char *paddress (CORE_ADDR addr); > char *pfildes (gdb_fildes_t fd); > > diff --git a/gdb/utils.h b/gdb/utils.h > index a91f551..d9fe7e3 100644 > --- a/gdb/utils.h > +++ b/gdb/utils.h > @@ -24,6 +24,7 @@ > #include "cleanups.h" > #include "exceptions.h" > #include "print-utils.h" > +#include "errors.h" > > extern void initialize_utils (void); > > @@ -269,7 +270,6 @@ extern void fprintf_symbol_filtered (struct ui_file *, const char *, > > extern void throw_perror_with_name (enum errors errcode, const char *string) > ATTRIBUTE_NORETURN; > -extern void perror_with_name (const char *) ATTRIBUTE_NORETURN; > > extern void perror_warning_with_name (const char *string); > > @@ -286,17 +286,11 @@ extern char *warning_pre_print; > extern void verror (const char *fmt, va_list ap) > ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 0); > > -extern void error (const char *fmt, ...) > - ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 2); > - > extern void error_stream (struct ui_file *) ATTRIBUTE_NORETURN; > > extern void vfatal (const char *fmt, va_list ap) > ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 0); > > -extern void fatal (const char *fmt, ...) > - ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 2); > - It's odd to separate out fatal and not vfatal. [ditto for the others] Can you add vfatal, et.al. to this patch? > extern void internal_verror (const char *file, int line, const char *, > va_list ap) > ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (3, 0); > @@ -308,8 +302,6 @@ extern void internal_vwarning (const char *file, int line, > extern void internal_warning (const char *file, int line, > const char *, ...) ATTRIBUTE_PRINTF (3, 4); > > -extern void warning (const char *, ...) ATTRIBUTE_PRINTF (1, 2); > - > extern void vwarning (const char *, va_list args) ATTRIBUTE_PRINTF (1, 0); > > extern void demangler_vwarning (const char *file, int line, > -- > 1.7.1 >