From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15153 invoked by alias); 17 Jan 2013 18:42:25 -0000 Received: (qmail 14998 invoked by uid 22791); 17 Jan 2013 18:42:23 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,TW_BJ X-Spam-Check-By: sourceware.org Received: from mail-oa0-f47.google.com (HELO mail-oa0-f47.google.com) (209.85.219.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Jan 2013 18:42:18 +0000 Received: by mail-oa0-f47.google.com with SMTP id h1so2954032oag.20 for ; Thu, 17 Jan 2013 10:42:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=1bBwe1uQoz11UUm8KbjXnMxcdTqPlSAtq1VnXuHEdiI=; b=W5Pq3YTeoLt4wzewM1LkyjmEDZaHWYHUBH8izZUWI8oflrbwUbhrPVhPmf8MQnvKy4 V+N1uvSQOMTaDxf108kyw1H+bGTHJgMosF09XOHTC4cFYQu05DMBDStMFA7W1gyIFFZs 3NfqbZvqEGECllEQe745xHir/pUecFT7OG6GmwNF0MdQ7g7LX/hOZN0+naUjSJXNX1P+ /3+hQHeAUb+h5VS4JZIVDaKVREY4NGFtbBSsEvzYnYsgIaj/TKXJHL8iSBKpGWse69ji iE1Q3FrK8FII58ltTDNwisfLxiVVR4FehSnMF/+KGXG25SGgDfOpdp1VgQ6weN7dZujh doPw== MIME-Version: 1.0 X-Received: by 10.182.144.7 with SMTP id si7mr4744490obb.94.1358448137613; Thu, 17 Jan 2013 10:42:17 -0800 (PST) Received: by 10.76.13.228 with HTTP; Thu, 17 Jan 2013 10:42:17 -0800 (PST) In-Reply-To: <87ehhjd7dk.fsf@fleche.redhat.com> References: <87ehhjd7dk.fsf@fleche.redhat.com> Date: Thu, 17 Jan 2013 18:42:00 -0000 Message-ID: Subject: Re: [RFA] Work around binutils/15021 From: Doug Evans To: Tom Tromey Cc: gdb-patches , Cary Coutant , Sterling Augustine Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQn0MUDvaF3IY8w7REL8Wtk/AEA0nOh36hsqDkCyruD2nd5yJU2IKhSC4IoFpFjRTJdkywM/+l4ziU+n2NxjarDugIOh6qV+zDvLb4gSQrFtqXdMXPx7mbcS2CfwrEvakUFMkrnSlB1M2jbwtTC1DyXb0t6J9C3kGVDXL9yybVBf10ZxPY+3774n+wcyzApT79lmM9Y1mmnoZI0A1BYrHVDkAqefSA== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00370.txt.bz2 On Thu, Jan 17, 2013 at 9:52 AM, Tom Tromey wrote: >>>>>> "Doug" == Doug Evans writes: > > Doug> Regression tested with gdb-generated .gdb_index version 7 (by hacking the > Doug> gdb-under-test to generate version 7), version 8, with dwz, and with gold. > > I think index version bumps require a documentation update and also a > binutils patch. Blech. Must remember to type grep foo *.texinfo instead of *.texi. > Doug> Work around binutils/15021 > > IIUC, the version bump is part of the workaround for the gold bug, > right? The idea being that gold will generate version 7 indices, > causing gdb to take the "inclusion" path. (I'm just trying to make sure > I understand what is going on.) Yeah. In the end I may not be able to avoid always having to record the inclusions. But to handle an app with 10k CUs and 530k TUs I'd to know if I *can* avoid it before something goes into a spec that makes it really hard or impossible. > Doug> + This is also used to work around a difference between the way gold > Doug> + generates .gdb_index version <=7 and the way gdb does. Arguably this > Doug> + is a gold bug. > > To me it doesn't seem arguable, but I'm curious to know what the case is > for it not being a gold bug. I don't have a strong enough opinion on this. > Doug> @@ -19634,7 +19660,7 @@ dwarf2_per_objfile_free (struct objfile > > Doug> for (ix = 0; ix < dwarf2_per_objfile->n_comp_units; ++ix) > Doug> VEC_free (dwarf2_per_cu_ptr, > Doug> - dwarf2_per_objfile->all_comp_units[ix]->s.imported_symtabs); > Doug> + dwarf2_per_objfile->all_comp_units[ix]->imported_symtabs); > > If follow_die_sig can be called when one TU refers to another TU, then > it seems like the TU could have a non-empty 'imported_symtabs', meaning > that the loop here should also iterate over TUs. Ah, righto. Revised patch to follow.