Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Siva Chandra <sivachandra@google.com>
Cc: Tom Tromey <tromey@redhat.com>, Eli Zaretskii <eliz@gnu.org>,
	gdb-patches@sourceware.org
Subject: Re: [RFC - Python Scripting] New method gdb.Symtab.blocks_iterator - docs included
Date: Tue, 10 Apr 2012 17:16:00 -0000	[thread overview]
Message-ID: <CADPb22T=SkGJRQHtab55=5R_Qj9WJhG6ALwuhXicnTQSvKpk6Q@mail.gmail.com> (raw)
In-Reply-To: <CAGyQ6gyhM5UP9uoAGzuY2mTYp4K4XjO0FPPuq_G5Pu=wA57xEQ@mail.gmail.com>

On Tue, Apr 10, 2012 at 12:44 AM, Siva Chandra <sivachandra@google.com> wrote:
> Thanks Eli and Tom for taking a look.
>
> Tom, I have addressed all your comments.  For some of them, I have my
> own comments below.  The updated patch is attached.
>
> Code -
> 2012-04-10  Siva Chandra Reddy  <sivachandra@google.com>
>
>        Add a new method gdb.Symtab.blocks to iterate
>        over the scope blocks of a symbol table.
>        * NEWS (Python scripting): Add entry about the new method.
>        * python/py-symtab.c (symtab_blocks_iterator_object): New
>        iterator type to iterate over the scope blocks of a symtab.
>        (stpy_blocks): New function which implements the new method.
>        (symtab_blocks_iterator_dealloc): New function which serves
>        as the tp_dealloc function for symtab_blocks_iterator_object.
>        (symtab_blocks_iterator_iter): New function which serves as
>        the tp_iter function for symtab_blocks_iterator_object.
>        (symtab_blocks_iterator_iternext): New function which serves as
>        the tp_iternext function for symtab_blocks_iterator_object.
>        (gdbpy_initialize_symtabs): Add initializations for the new
>        iterator type.

[filed for reference sake]
I can imagine bug fixes and improvements meaning that iterating over
blocks can give different results one gdb release to the next.
I don't want our hands tied because we're afraid of breaking someone's
python script.  This is an area where I can easily imagine change.

I'm not saying this can't go in, to the contrary.
But IWBN to have it written down somewhere that we make no promises of
absolute consistency one release to the next.


  reply	other threads:[~2012-04-10 15:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-09 18:34 Siva Chandra
2012-04-09 20:47 ` Eli Zaretskii
2012-04-10  1:38 ` Tom Tromey
2012-04-10  7:45   ` Siva Chandra
2012-04-10 17:16     ` Doug Evans [this message]
2012-04-10 22:21     ` Tom Tromey
2012-04-11  4:59       ` Siva Chandra
2012-04-11  5:44         ` Doug Evans
2012-04-12 15:20         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADPb22T=SkGJRQHtab55=5R_Qj9WJhG6ALwuhXicnTQSvKpk6Q@mail.gmail.com' \
    --to=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=sivachandra@google.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox