Re: [PATCH] Support gzip compressed exec and core files in gdb

Michael Eager
2015-06-15T15:14:17Z

On 05/04/2015 12:50 AM, Mike Frysinger wrote:
> On 01 May 2015 15:03, Michael Eager wrote:
>> On 05/01/2015 10:53 AM, Eli Zaretskii wrote:
>>>> Date: Fri, 01 May 2015 07:40:26 -0700
>>>> From: Michael Eager <eager@eagerm.com>
>>>>
>>>> On 03/10/2015 04:01 PM, Michael Eager wrote:
>>>>> Add support to automatically unzip compressed executable and core files.
>>>>> Files will be uncompressed into temporary directory (/tmp or $TMPDIR)
>>>>> and are deleted when GDB exits. This should be transparent to users,
>>>>> except for disk space requirements. The name of the uncompressed file is
>>>>> mentioned, but all references to the file in GDB messages is to the file
>>>>> which the user specified.
>>>>
>>>> Attached is a revised patch. I discovered a logic error after refactoring
>>>> the code.
>>>
>>> OK for the documentation parts.
>>>
>>>> + decomp_fd = mkstemp (template);
>>>
>>> Do we have mkstemp on all supported platforms?
>>
>> It looks like there is a version in gnulib, if not supported natively.
>
> libiberty limits itself to "mkstemps" since it provides a fallback for that ...
> -mike
>

Any comment on this patch? Or approval?

--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077