From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23543 invoked by alias); 11 Mar 2015 18:10:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23472 invoked by uid 89); 11 Mar 2015 18:09:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 X-HELO: mail-oi0-f50.google.com Received: from mail-oi0-f50.google.com (HELO mail-oi0-f50.google.com) (209.85.218.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 11 Mar 2015 18:09:52 +0000 Received: by oigh136 with SMTP id h136so9466357oig.1 for ; Wed, 11 Mar 2015 11:09:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=LGoIIjuQVeJZz9w8ZJRsVsvcrhTxulx/D9k3PyHRg5M=; b=MTs9jEVgRHd2dIeBtr+L17iIiZSwVNRB8xISj+7bP7+b7bkoxGMocFsfJWgJFXdoZz yf/XiRmVPmVxaUISG/gY0zlKp6RTwK5zzkr+m1Y/qP0JMVlFc6dzTOURT4LSfYjz2XPN W8m0HVHuw1Hz73YkTQYvyhYqHuqWH7Rh2TbA+1hmk2rtPTGmCAKb3pRzV8LELc4Svdy8 FItx3OIdKMFYq4jbs7TJagSUrEu+0syd+3bz5gwagdMblXhu+iYV6yOiUclfXmINSlnU 8cVTDVEknXp1ugy1vmieawlRQg7tjPGozOHAsVd14QR68qJWsGaXWjMWteJng/u4JnsW ht1A== X-Gm-Message-State: ALoCoQkIK1B3dZ/HL7qVILrWnhEmuPflIvUtC6jzJl2xvXiX97sqZhPLAD+V8AxdNqcRPyfK97nb MIME-Version: 1.0 X-Received: by 10.182.24.97 with SMTP id t1mr30625245obf.77.1426097390496; Wed, 11 Mar 2015 11:09:50 -0700 (PDT) Received: by 10.182.142.226 with HTTP; Wed, 11 Mar 2015 11:09:50 -0700 (PDT) In-Reply-To: <20150311174236.GA13850@blade.nx> References: <54FF77D6.7010400@eagerm.com> <20150311100702.GA3698@blade.nx> <5500580C.6090400@eagerm.com> <20150311174236.GA13850@blade.nx> Date: Wed, 11 Mar 2015 18:10:00 -0000 Message-ID: Subject: Re: [PATCH] Support gzip compressed exec and core files in gdb From: Doug Evans To: Gary Benson Cc: Michael Eager , "gdb-patches@sourceware.org" , binutils Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00310.txt.bz2 On Wed, Mar 11, 2015 at 10:42 AM, Gary Benson wrote: > Michael Eager wrote: >> On 03/11/15 03:07, Gary Benson wrote: >> >Michael Eager wrote: >> > > Add support to automatically unzip compressed executable and core >> > > files. Files will be uncompressed into temporary directory (/tmp or >> > > $TMPDIR) and are deleted when GDB exits. This should be transparent >> > > to users, except for disk space requirements. The name of the >> > > uncompressed file is mentioned, but all references to the file in >> > > GDB messages is to the file which the user specified. >> >... >> > > diff --git a/gdb/common/filestuff.c b/gdb/common/filestuff.c >> > > index 14d6324..b2c31fd 100644 >> > > --- a/gdb/common/filestuff.c >> > > +++ b/gdb/common/filestuff.c >> >... >> > > +#ifndef GDBSERVER >> > >> > Please do not add GDBSERVER conditionals to gdb/common, I spent >> > half a year removing them all. >> > >> > It looks like this code is only used by GDB, not gdbserver, so >> > the fix is simple, just put the code somewhere GDB-specific. >> >> Sure. Any suggestions? gdb_bfd.c seems like the wrong place. > > gdb/utils.c maybe? Fine by me. Though, OTOH, there's nothing intrinsic in what's being done there that gdbserver (or anything else that might want to use common) couldn't use it tomorrow. I'd be ok with common/compression.c or some such.