From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10440 invoked by alias); 31 Jan 2012 23:14:05 -0000 Received: (qmail 10402 invoked by uid 22791); 31 Jan 2012 23:14:04 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-tul01m020-f169.google.com (HELO mail-tul01m020-f169.google.com) (209.85.214.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 31 Jan 2012 23:13:51 +0000 Received: by obbta7 with SMTP id ta7so709786obb.0 for ; Tue, 31 Jan 2012 15:13:50 -0800 (PST) Received: by 10.182.47.10 with SMTP id z10mr37106719obm.19.1328051630557; Tue, 31 Jan 2012 15:13:50 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.47.10 with SMTP id z10mr37106712obm.19.1328051630467; Tue, 31 Jan 2012 15:13:50 -0800 (PST) Received: by 10.182.62.9 with HTTP; Tue, 31 Jan 2012 15:13:50 -0800 (PST) In-Reply-To: References: Date: Tue, 31 Jan 2012 23:23:00 -0000 Message-ID: Subject: Re: RFA: fix PR python/13351 From: Doug Evans To: Tom Tromey Cc: gdb-patches@sourceware.org X-System-Of-Record: true Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg01023.txt.bz2 On Tue, Jan 31, 2012 at 1:59 PM, Tom Tromey wrote: > This fixes PR python/13351. > > The bug is that gdb.lookup_symbol required a current frame, but this > restriction doesn't really make sense. =A0It is ok to look up global > symbols without a current frame. > > This patch just lifts the restriction. > > This requires a doc review. > > Built and regtested on x86-64 Fedora 15. > > Tom > > 2012-01-31 =A0Tom Tromey =A0 > > =A0 =A0 =A0 =A0PR python/13351: > =A0 =A0 =A0 =A0* python/py-symbol.c (gdbpy_lookup_symbol): Work even when= there > =A0 =A0 =A0 =A0is no frame. I think a bit of discussion is needed. [Sorry!] There is also lookup_global_symbol. Are we sure we want lookup_symbol to work when there is no frame? [it doesn't feel very clean to me, but maybe I just need to look at it differently]